test: fix to skip power acpi cpufreq autotest

Message ID 1542117500-30499-1-git-send-email-pallantlax.poornima@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series test: fix to skip power acpi cpufreq autotest |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Poornima, PallantlaX Nov. 13, 2018, 1:58 p.m. UTC
  Power_acpi_cpufreq_autotest should not be run on VM and platforms
which dont have acpi_cpufreq module loaded.
Hence changed return as TEST_SKIPPED

Fixes: 0ea2dd4409 ("test: skip when required lib not available")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
 test/test/test_power_acpi_cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Pattan, Reshma Nov. 13, 2018, 4:07 p.m. UTC | #1
> -----Original Message-----
> From: Poornima, PallantlaX
> Sent: Tuesday, November 13, 2018 1:58 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Hunt, David
> <david.hunt@intel.com>; Poornima, PallantlaX
> <pallantlax.poornima@intel.com>; stable@dpdk.org
> Subject: [PATCH] test: fix to skip power acpi cpufreq autotest
> 
> Power_acpi_cpufreq_autotest should not be run on VM and platforms which
> dont have acpi_cpufreq module loaded.
> Hence changed return as TEST_SKIPPED
> 
> Fixes: 0ea2dd4409 ("test: skip when required lib not available")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.com>
  
Thomas Monjalon Nov. 14, 2018, 3:49 a.m. UTC | #2
13/11/2018 17:07, Pattan, Reshma:
> From: Poornima, PallantlaX
> > 
> > Power_acpi_cpufreq_autotest should not be run on VM and platforms which
> > dont have acpi_cpufreq module loaded.
> > Hence changed return as TEST_SKIPPED
> > 
> > Fixes: 0ea2dd4409 ("test: skip when required lib not available")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied, thanks
  

Patch

diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
index 22e541d65..6d637cc77 100644
--- a/test/test/test_power_acpi_cpufreq.c
+++ b/test/test/test_power_acpi_cpufreq.c
@@ -441,7 +441,7 @@  test_power_acpi_cpufreq(void)
 				"correctly(APCI cpufreq) or operating in another valid "
 				"Power management environment\n", TEST_POWER_LCORE_ID);
 		rte_power_unset_env();
-		return -1;
+		return TEST_SKIPPED;
 	}
 
 	/**