diff mbox series

[v10,09/12] telemetry: add ability to disable selftest

Message ID	20181027091750.17254-10-harry.van.haaren@intel.com (mailing list archive)
State	Accepted, archived
Headers	From: Harry van Haaren <harry.van.haaren@intel.com> To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com, Ciara Power <ciara.power@intel.com>, Brian Archbold <brian.archbold@intel.com>, Kevin Laatz <kevin.laatz@intel.com> Date: Sat, 27 Oct 2018 10:17:47 +0100 Message-Id: <20181027091750.17254-10-harry.van.haaren@intel.com> In-Reply-To: <20181027091750.17254-1-harry.van.haaren@intel.com> References: <20181026235933.79779-1-harry.van.haaren@intel.com> <20181027091750.17254-1-harry.van.haaren@intel.com> Subject: [dpdk-dev] [PATCH v10 09/12] telemetry: add ability to disable selftest Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Introduce Telemetry Library \| [v10,00/12] Introduce Telemetry Library [v10,01/12] eal: add option register infrastructure [v10,02/12] eal: make get runtime dir function public [v10,03/12] telemetry: initial telemetry infrastructure [v10,04/12] telemetry: add initial connection socket [v10,05/12] telemetry: add client feature and sockets [v10,06/12] telemetry: add parser for client socket messages [v10,07/12] telemetry: update metrics before sending stats [v10,08/12] telemetry: format json response when sending stats [v10,09/12] telemetry: add ability to disable selftest [v10,10/12] doc: add telemetry documentation [v10,11/12] usertools: add client python script for telemetry [v10,12/12] build: add dependency on telemetry to apps in meson

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Van Haaren, Harry Oct. 27, 2018, 9:17 a.m. UTC

  From: Ciara Power <ciara.power@intel.com>

This patch adds functionality to enable/disable the selftest.

This functionality will be extended in future to make the
enabling/disabling more dynamic and remove this 'hardcoded' approach. We
are temporarily using this approach due to the design changes (vdev vs eal)
made to the library.

Signed-off-by: Ciara Power <ciara.power@intel.com>
Signed-off-by: Brian Archbold <brian.archbold@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 lib/librte_telemetry/rte_telemetry.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff mbox series

Patch

diff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c
index 5b66b71c4..2e27491b5 100644
--- a/lib/librte_telemetry/rte_telemetry.c
+++ b/lib/librte_telemetry/rte_telemetry.c
@@ -660,6 +660,7 @@  rte_telemetry_initial_accept(struct telemetry_impl *telemetry)
 {
 	uint16_t pid;
 	int ret;
+	int selftest = 0;
 
 	RTE_ETH_FOREACH_DEV(pid) {
 		telemetry->reg_index = rte_telemetry_reg_ethdev_to_metrics(pid);
@@ -672,18 +673,20 @@  rte_telemetry_initial_accept(struct telemetry_impl *telemetry)
 	}
 
 	telemetry->metrics_register_done = 1;
-	ret = rte_telemetry_socket_messaging_testing(telemetry->reg_index,
-		telemetry->server_fd);
-	if (ret < 0)
-		return -1;
+	if (selftest) {
+		ret = rte_telemetry_socket_messaging_testing(telemetry->reg_index,
+				telemetry->server_fd);
+		if (ret < 0)
+			return -1;
 
-	ret = rte_telemetry_parser_test(telemetry);
-	if (ret < 0) {
-		TELEMETRY_LOG_ERR("Parser Tests Failed");
-		return -1;
-	}
+		ret = rte_telemetry_parser_test(telemetry);
+		if (ret < 0) {
+			TELEMETRY_LOG_ERR("Parser Tests Failed");
+			return -1;
+		}
 
-	TELEMETRY_LOG_INFO("Success - All Parser Tests Passed");
+		TELEMETRY_LOG_INFO("Success - All Parser Tests Passed");
+	}
 
 	return 0;
 }