diff mbox series

[v2,2/3] bus/fslmc: ignore dpaax pa-va table errors

Message ID 20181017100954.18284-3-shreyansh.jain@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series Reduce logging level for dpaax and fslmc |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Shreyansh Jain Oct. 17, 2018, 10:10 a.m. UTC 
  Presence of PA-VA Table is transparent to the drivers. Ignoring the
return values from table update call.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/bus/fslmc/fslmc_bus.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Jerin Jacob Oct. 23, 2018, 9:44 a.m. UTC | #1 
-----Original Message-----
> Date: Wed, 17 Oct 2018 10:10:36 +0000
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
> To: "thomas@monjalon.net" <thomas@monjalon.net>
> CC: "dev@dpdk.org" <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com>
> Subject: [dpdk-dev] [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table
>  errors
> x-mailer: git-send-email 2.17.1
> 
> 
> Presence of PA-VA Table is transparent to the drivers. Ignoring the
> return values from table update call.
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/bus/fslmc/fslmc_bus.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
> index 5ba5ce96b..db3026f4e 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -386,11 +386,11 @@ rte_fslmc_probe(void)
>          * This has to be done before probe as some device initialization
>          * (during) probe allocate memory (dpaa2_sec) which needs to be pinned
>          * to this table.
> +        *
> +        * Error is ignored as relevant logs are handled within dpaax and
> +        * handling for unavailable dpaax table too is transparent to caller.
>          */
> -       ret = dpaax_iova_table_populate();
> -       if (ret) {
> -               DPAA2_BUS_WARN("PA->VA Translation table not available;");
> -       }
> +       dpaax_iova_table_populate();
> 
>         TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
>                 TAILQ_FOREACH(drv, &rte_fslmc_bus.driver_list, next) {
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 5ba5ce96b..db3026f4e 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -386,11 +386,11 @@  rte_fslmc_probe(void)
 	 * This has to be done before probe as some device initialization
 	 * (during) probe allocate memory (dpaa2_sec) which needs to be pinned
 	 * to this table.
+	 *
+	 * Error is ignored as relevant logs are handled within dpaax and
+	 * handling for unavailable dpaax table too is transparent to caller.
 	 */
-	ret = dpaax_iova_table_populate();
-	if (ret) {
-		DPAA2_BUS_WARN("PA->VA Translation table not available;");
-	}
+	dpaax_iova_table_populate();
 
 	TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
 		TAILQ_FOREACH(drv, &rte_fslmc_bus.driver_list, next) {