[1/2] net/sfc: allow to query RSS key and HF in isolated mode
Checks
Commit Message
From: Ivan Malov <ivan.malov@oktetlabs.ru>
Isolated mode prevents global RSS from being enabled and configured.
However, an application may need to query default RSS key and hash
functions when a flow rule with RSS action is added which does not
contain custom RSS key or hash function choice. In this case
global RSS key and hash functions will be used to handle the rule,
and there should be some way for the application to query these
global default settings to clarify expectations on the traffic
distribution.
Fixes: 84a9b48128c1 ("net/sfc: support flow API isolated mode")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On 10/11/2018 3:51 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> Isolated mode prevents global RSS from being enabled and configured.
> However, an application may need to query default RSS key and hash
> functions when a flow rule with RSS action is added which does not
> contain custom RSS key or hash function choice. In this case
> global RSS key and hash functions will be used to handle the rule,
> and there should be some way for the application to query these
> global default settings to clarify expectations on the traffic
> distribution.
>
> Fixes: 84a9b48128c1 ("net/sfc: support flow API isolated mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Series applied to dpdk-next-net/master, thanks.
@@ -1354,9 +1354,8 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
{
struct sfc_adapter *sa = dev->data->dev_private;
struct sfc_rss *rss = &sa->rss;
- struct sfc_port *port = &sa->port;
- if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || port->isolated)
+ if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE)
return -ENOTSUP;
if (rss->channels == 0)