net/tap: fix reported number of Tx packets

Message ID 1539154893-20548-1-git-send-email-rasland@mellanox.com
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • net/tap: fix reported number of Tx packets
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Raslan Darawsheh Oct. 10, 2018, 7:01 a.m.
When writev fails to send packets it doesn't update the
number of Tx packets, but it still num_tx is updated.

the value that should be returned is the actual number
of sent packets which is num_packets.

Fixes: 02f96a0a ("net/tap: add TUN/TAP device PMD")
CC: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 drivers/net/tap/rte_eth_tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wiles, Keith Oct. 10, 2018, 12:39 p.m. | #1
> On Oct 10, 2018, at 2:01 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> 
> When writev fails to send packets it doesn't update the
> number of Tx packets, but it still num_tx is updated.
> 
> the value that should be returned is the actual number
> of sent packets which is num_packets.
> 
> Fixes: 02f96a0a ("net/tap: add TUN/TAP device PMD")
> CC: stable@dpdk.org
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>

Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 83c9288..228add2 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -707,7 +707,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> 	txq->stats.errs += nb_pkts - num_tx;
> 	txq->stats.obytes += num_tx_bytes;
> 
> -	return num_tx;
> +	return num_packets;
> }
> 
> static const char *
> -- 
> 2.7.4
> 

Regards,
Keith
Ferruh Yigit Oct. 16, 2018, 3:19 p.m. | #2
On 10/10/2018 1:39 PM, Wiles, Keith wrote:
> 
> 
>> On Oct 10, 2018, at 2:01 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
>>
>> When writev fails to send packets it doesn't update the
>> number of Tx packets, but it still num_tx is updated.
>>
>> the value that should be returned is the actual number
>> of sent packets which is num_packets.
>>
>> Fixes: 02f96a0a ("net/tap: add TUN/TAP device PMD")
>> CC: stable@dpdk.org
>> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> 
> Acked-by: Keith Wiles <keith.wiles@intel.com>

Applied to dpdk-next-net/master, thanks.

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 83c9288..228add2 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -707,7 +707,7 @@  pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 	txq->stats.errs += nb_pkts - num_tx;
 	txq->stats.obytes += num_tx_bytes;
 
-	return num_tx;
+	return num_packets;
 }
 
 static const char *