From patchwork Wed Oct 3 07:22:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Ostruszka X-Patchwork-Id: 45925 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E6784CC5; Wed, 3 Oct 2018 09:22:36 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 6F84037B0 for ; Wed, 3 Oct 2018 09:22:27 +0200 (CEST) Received: by mail-lj1-f194.google.com with SMTP id r83-v6so4109398ljr.7 for ; Wed, 03 Oct 2018 00:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+7Bzgs5Fo6HSPGnN7FLPOkOuD45Sa8gVMafoJwgRoC8=; b=GXU9IhZOuWGz5wTD0XPoLzkWy0MOfakYYYru1ExWwcXEWseI+xUUydM8RxC9aR4UWR dPBixOQGKymrVlVe1/Hrh0uVtJyqZHZdhhH+z820ZPTaHNshjse6Ubq+mTnwJWYkPBuh h/DIE+3VzbYvboQ/N+8HjbuFMiDmxMmhSV8bUvLI+qq4cCYvZx4rj09fLQihTzEvv0E5 7EIRAecOCevzL2BV6HFP8tUn1VmEh0syAkycJYjjJNWZiG5RmNLk/WXVrQQ9828yZD// kCvKO6Bjh66AlhxFJ8M7UuIeSnKywIYFjToskAJ8dD75wZZD5aXgGHCDCqAHxWWBZHzR 2uGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+7Bzgs5Fo6HSPGnN7FLPOkOuD45Sa8gVMafoJwgRoC8=; b=fWdHuu9rLb1l/9A7+QamXu8Dxc5onGZ/KT2Ar+7SDVOA2z4YgPIHz0RqN7XsZP55oS 7AKgjbPOaeeiFgOI60RmC02NAWMBrGHWPdyPnlCEsBTPMNv/56J3TtanRXwTsW1jNKdR +cpDNdM0aJ7oZ4kkVMup5OEDlEkfswquzyagvsdwrMD7xIfOZgeCJoWWgel/DdHSheob ydJtOhOlAspLWT7xj2puChWH+1mDvl8OIV9GsFT9jIeiPueyYu+pvuf3fSqN0/5n1lGm YRoBdgmsIXQlHJ7OOPp2k+A8RQaz2DIp2dhp2Jlvvn4jaQotxYFSHwgNTHuqxu6VbJpG U9vA== X-Gm-Message-State: ABuFfoiq+wYNwjjIq8B9v195heQUfvcoTBMTp09lrL2PefSyBxKXkLor 8pFlCxt8piYVPBawqsVNfDe3HWCMXi5CJQ== X-Google-Smtp-Source: ACcGV63L2HxKoKj/hkDOTUb3UlYAARmKuXNIiN4tshrPLUiwS0BQI1lvLsOaifOuhIwoIIdFMjvGQA== X-Received: by 2002:a2e:58e:: with SMTP id 136-v6mr168607ljf.130.1538551346920; Wed, 03 Oct 2018 00:22:26 -0700 (PDT) Received: from amok.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id f73-v6sm123659lfl.80.2018.10.03.00.22.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Oct 2018 00:22:26 -0700 (PDT) From: Andrzej Ostruszka X-Google-Original-From: Andrzej Ostruszka To: dev@dpdk.org Cc: mw@semihalf.com, nadavh@marvell.com, zr@semihalf.com, tdu@semihalf.com Date: Wed, 3 Oct 2018 09:22:15 +0200 Message-Id: <1538551336-19259-8-git-send-email-andrzej.ostruszka@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1538551336-19259-1-git-send-email-andrzej.ostruszka@gmail.com> References: <1538385970-21260-1-git-send-email-andrzej.ostruszka@gmail.com> <1538551336-19259-1-git-send-email-andrzej.ostruszka@gmail.com> Subject: [dpdk-dev] [PATCH v7 7/8] net/mvneta: add support for basic stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Zyta Szpak Add support for getting of basic statistics for the driver. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 47 +++++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+) diff --git a/doc/guides/nics/features/mvneta.ini b/doc/guides/nics/features/mvneta.ini index 59c9c36..701eb03 100644 --- a/doc/guides/nics/features/mvneta.ini +++ b/doc/guides/nics/features/mvneta.ini @@ -14,5 +14,6 @@ CRC offload = Y L3 checksum offload = Y L4 checksum offload = Y Packet type parsing = Y +Basic stats = Y ARMv8 = Y Usage doc = Y diff --git a/doc/guides/nics/mvneta.rst b/doc/guides/nics/mvneta.rst index 068b3a7..2132a81 100644 --- a/doc/guides/nics/mvneta.rst +++ b/doc/guides/nics/mvneta.rst @@ -38,6 +38,7 @@ Features of the MVNETA PMD are: - L3 checksum offload - L4 checksum offload - Packet type parsing +- Basic stats Limitations diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c index 7a64e5a..d004bfd 100644 --- a/drivers/net/mvneta/mvneta_ethdev.c +++ b/drivers/net/mvneta/mvneta_ethdev.c @@ -666,6 +666,52 @@ mvneta_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr) return 0; } +/** + * DPDK callback to get device statistics. + * + * @param dev + * Pointer to Ethernet device structure. + * @param stats + * Stats structure output buffer. + * + * @return + * 0 on success, negative error value otherwise. + */ +static int +mvneta_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) +{ + struct mvneta_priv *priv = dev->data->dev_private; + struct neta_ppio_statistics ppio_stats; + unsigned int ret; + + if (!priv->ppio) + return -EPERM; + + ret = neta_ppio_get_statistics(priv->ppio, &ppio_stats); + if (unlikely(ret)) { + MVNETA_LOG(ERR, "Failed to update port statistics"); + return ret; + } + + stats->ipackets += ppio_stats.rx_packets + + ppio_stats.rx_broadcast_packets + + ppio_stats.rx_multicast_packets; + stats->opackets += ppio_stats.tx_packets + + ppio_stats.tx_broadcast_packets + + ppio_stats.tx_multicast_packets; + stats->ibytes += ppio_stats.rx_bytes; + stats->obytes += ppio_stats.tx_bytes; + stats->imissed += ppio_stats.rx_discard + + ppio_stats.rx_overrun; + + stats->ierrors = ppio_stats.rx_packets_err + + ppio_stats.rx_errors + + ppio_stats.rx_crc_error; + stats->oerrors = ppio_stats.tx_errors; + + return 0; +} + static const struct eth_dev_ops mvneta_ops = { .dev_configure = mvneta_dev_configure, .dev_start = mvneta_dev_start, @@ -680,6 +726,7 @@ static const struct eth_dev_ops mvneta_ops = { .mac_addr_add = mvneta_mac_addr_add, .mac_addr_set = mvneta_mac_addr_set, .mtu_set = mvneta_mtu_set, + .stats_get = mvneta_stats_get, .dev_infos_get = mvneta_dev_infos_get, .dev_supported_ptypes_get = mvneta_dev_supported_ptypes_get, .rxq_info_get = mvneta_rxq_info_get,