eal: remove experimental from hotplug add/remove
Checks
Commit Message
rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
v17.08 as experimental
Commit a3ee360f4440 ("eal: add hotplug add/remove device")
When __rte_experimental tag created, APIs tagged with it on v18.02
Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
deprecated in v18.08 eal APIs are only ones for hotplug operations
Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
These APIs are around for a few releases now and without an alternative,
removing the experimental tag from them.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Ian Stokes <ian.stokes@intel.com>
CC: arybchenko@solarflare.com
---
drivers/raw/ifpga_rawdev/Makefile | 1 -
drivers/raw/ifpga_rawdev/meson.build | 2 --
lib/librte_eal/common/eal_common_dev.c | 7 ++++---
lib/librte_eal/common/include/rte_dev.h | 15 +++++----------
lib/librte_eal/rte_eal_version.map | 4 ++--
5 files changed, 11 insertions(+), 18 deletions(-)
Comments
On 10/2/18 2:04 PM, Ferruh Yigit wrote:
> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
> v17.08 as experimental
> Commit a3ee360f4440 ("eal: add hotplug add/remove device")
>
> When __rte_experimental tag created, APIs tagged with it on v18.02
> Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
>
> After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
> deprecated in v18.08 eal APIs are only ones for hotplug operations
> Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
>
> These APIs are around for a few releases now and without an alternative,
> removing the experimental tag from them.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Dup of http://patches.dpdk.org/patch/45791/ ?
On 10/2/2018 11:08 AM, Andrew Rybchenko wrote:
> On 10/2/18 2:04 PM, Ferruh Yigit wrote:
>> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
>> v17.08 as experimental
>> Commit a3ee360f4440 ("eal: add hotplug add/remove device")
>>
>> When __rte_experimental tag created, APIs tagged with it on v18.02
>> Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
>>
>> After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
>> deprecated in v18.08 eal APIs are only ones for hotplug operations
>> Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
>>
>> These APIs are around for a few releases now and without an alternative,
>> removing the experimental tag from them.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Dup of http://patches.dpdk.org/patch/45791/ ?
Ahh, yes it is, I will mark this as Rejected, thanks.
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, October 02, 2018 18:24
> To: Andrew Rybchenko <arybchenko@solarflare.com>; Xu, Rosen
> <rosen.xu@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Stokes, Ian
> <ian.stokes@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug
> add/remove
>
> On 10/2/2018 11:08 AM, Andrew Rybchenko wrote:
> > On 10/2/18 2:04 PM, Ferruh Yigit wrote:
> >> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
> >> v17.08 as experimental
> >> Commit a3ee360f4440 ("eal: add hotplug add/remove device")
> >>
> >> When __rte_experimental tag created, APIs tagged with it on v18.02
> >> Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
> >>
> >> After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
> >> deprecated in v18.08 eal APIs are only ones for hotplug operations
> >> Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
> >>
> >> These APIs are around for a few releases now and without an
> >> alternative, removing the experimental tag from them.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Dup of http://patches.dpdk.org/patch/45791/ ?
>
> Ahh, yes it is, I will mark this as Rejected, thanks.
Just back from holiday, a long story of this patch and 45791 :)
@@ -8,7 +8,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
#
LIB = librte_pmd_ifpga_rawdev.a
-CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
CFLAGS += -I$(RTE_SDK)/drivers/bus/ifpga
@@ -11,5 +11,3 @@ deps += ['rawdev', 'pci', 'bus_pci', 'kvargs',
sources = files('ifpga_rawdev.c')
includes += include_directories('base')
-
-allow_experimental_apis = true
@@ -127,8 +127,9 @@ int rte_eal_dev_detach(struct rte_device *dev)
return ret;
}
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devname,
- const char *devargs)
+int
+rte_eal_hotplug_add(const char *busname, const char *devname,
+ const char *devargs)
{
struct rte_bus *bus;
struct rte_device *dev;
@@ -193,7 +194,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
return ret;
}
-int __rte_experimental
+int
rte_eal_hotplug_remove(const char *busname, const char *devname)
{
struct rte_bus *bus;
@@ -189,9 +189,6 @@ __rte_deprecated
int rte_eal_dev_detach(struct rte_device *dev);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Hotplug add a given device to a specific bus.
*
* @param busname
@@ -204,13 +201,11 @@ int rte_eal_dev_detach(struct rte_device *dev);
* @return
* 0 on success, negative on error.
*/
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devname,
- const char *devargs);
+int
+rte_eal_hotplug_add(const char *busname, const char *devname,
+ const char *devargs);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Hotplug remove a given device from a specific bus.
*
* @param busname
@@ -220,8 +215,8 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
* @return
* 0 on success, negative on error.
*/
-int __rte_experimental rte_eal_hotplug_remove(const char *busname,
- const char *devname);
+int
+rte_eal_hotplug_remove(const char *busname, const char *devname);
/**
* Device comparison function.
@@ -265,6 +265,8 @@ DPDK_18.08 {
DPDK_18.11 {
global:
+ rte_eal_hotplug_add;
+ rte_eal_hotplug_remove;
rte_strscpy;
} DPDK_18.08;
@@ -292,8 +294,6 @@ EXPERIMENTAL {
rte_devargs_remove;
rte_devargs_type_count;
rte_eal_cleanup;
- rte_eal_hotplug_add;
- rte_eal_hotplug_remove;
rte_fbarray_attach;
rte_fbarray_destroy;
rte_fbarray_detach;