build: add drivers_install_subdir meson option
diff mbox series

Message ID 20180928175803.12955-1-bluca@debian.org
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • build: add drivers_install_subdir meson option
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi Sept. 28, 2018, 5:58 p.m. UTC
Allow users and packagers to override the default dpdk/drivers
subdirectory where the PMDs get installed under $lib.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 meson.build       | 3 ++-
 meson_options.txt | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Bruce Richardson Oct. 1, 2018, 9:17 a.m. UTC | #1
On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote:
> Allow users and packagers to override the default dpdk/drivers
> subdirectory where the PMDs get installed under $lib.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---

I'm ok with this change, but what is the current location used by distro's
right now? I mistakenly never checked what was done before I used
dpdk/drivers as a default value, and I'd like the default to match the
common option if possible.

/Bruce
Bruce Richardson Oct. 1, 2018, 9:25 a.m. UTC | #2
On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote:
> On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote:
> > Allow users and packagers to override the default dpdk/drivers
> > subdirectory where the PMDs get installed under $lib.
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> 
> I'm ok with this change, but what is the current location used by distro's
> right now? I mistakenly never checked what was done before I used
> dpdk/drivers as a default value, and I'd like the default to match the
> common option if possible.
> 
> /Bruce
> 
Replying to my own question, I've just checked on CentOS and Debian, and it
appears both are using directory "dpdk-pmds" as the subdir name. Therefore,
let's just make that the default. [Does it need to be configurable in that
case?]

/Bruce
Luca Boccassi Oct. 1, 2018, 9:46 a.m. UTC | #3
On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote:
> > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote:
> > > Allow users and packagers to override the default dpdk/drivers
> > > subdirectory where the PMDs get installed under $lib.
> > > 
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > 
> > I'm ok with this change, but what is the current location used by
> > distro's
> > right now? I mistakenly never checked what was done before I used
> > dpdk/drivers as a default value, and I'd like the default to match
> > the
> > common option if possible.
> > 
> > /Bruce
> > 
> 
> Replying to my own question, I've just checked on CentOS and Debian,
> and it
> appears both are using directory "dpdk-pmds" as the subdir name.
> Therefore,
> let's just make that the default. [Does it need to be configurable in
> that
> case?]
> 
> /Bruce

If the default is the one I expect then I'm fine without having an
option (actually happier - less things to configure).

But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last January :-)
We changed because using a single directory creates problems when
multiple different ABI versions are installed, due to the EAL autoload
from that directory. So we need a different subdirectory per ABI
revision.

We were actually talking with Timothy a while ago to make this
consistent across our distros, and perhaps Marco can chip in as well.

Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm not
too fussy on $something, it can be drivers or pmds or something else.
Bruce Richardson Oct. 1, 2018, 10:01 a.m. UTC | #4
On Mon, Oct 01, 2018 at 10:46:02AM +0100, Luca Boccassi wrote:
> On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote:
> > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote:
> > > > Allow users and packagers to override the default dpdk/drivers
> > > > subdirectory where the PMDs get installed under $lib.
> > > > 
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > ---
> > > 
> > > I'm ok with this change, but what is the current location used by
> > > distro's
> > > right now? I mistakenly never checked what was done before I used
> > > dpdk/drivers as a default value, and I'd like the default to match
> > > the
> > > common option if possible.
> > > 
> > > /Bruce
> > > 
> > 
> > Replying to my own question, I've just checked on CentOS and Debian,
> > and it
> > appears both are using directory "dpdk-pmds" as the subdir name.
> > Therefore,
> > let's just make that the default. [Does it need to be configurable in
> > that
> > case?]
> > 
> > /Bruce
> 
> If the default is the one I expect then I'm fine without having an
> option (actually happier - less things to configure).
> 
> But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last January :-)
> We changed because using a single directory creates problems when
> multiple different ABI versions are installed, due to the EAL autoload
> from that directory. So we need a different subdirectory per ABI
> revision.
> 
> We were actually talking with Timothy a while ago to make this
> consistent across our distros, and perhaps Marco can chip in as well.
> 
> Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm not
> too fussy on $something, it can be drivers or pmds or something else.
> 
Sounds like it needs to be configurable, just in case.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Timothy Redaelli Oct. 1, 2018, 10:42 a.m. UTC | #5
On Mon, 01 Oct 2018 10:46:02 +0100
Luca Boccassi <bluca@debian.org> wrote:

> On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote:  
> > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote:  
> > > > Allow users and packagers to override the default dpdk/drivers
> > > > subdirectory where the PMDs get installed under $lib.
> > > > 
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > ---  
> > > 
> > > I'm ok with this change, but what is the current location used by
> > > distro's
> > > right now? I mistakenly never checked what was done before I used
> > > dpdk/drivers as a default value, and I'd like the default to match
> > > the
> > > common option if possible.
> > > 
> > > /Bruce
> > >   
> > 
> > Replying to my own question, I've just checked on CentOS and Debian,
> > and it
> > appears both are using directory "dpdk-pmds" as the subdir name.
> > Therefore,
> > let's just make that the default. [Does it need to be configurable in
> > that
> > case?]
> > 
> > /Bruce  
> 
> If the default is the one I expect then I'm fine without having an
> option (actually happier - less things to configure).
> 
> But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last January :-)
> We changed because using a single directory creates problems when
> multiple different ABI versions are installed, due to the EAL autoload
> from that directory. So we need a different subdirectory per ABI
> revision.
> 
> We were actually talking with Timothy a while ago to make this
> consistent across our distros, and perhaps Marco can chip in as well.
> 
> Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm not
> too fussy on $something, it can be drivers or pmds or something else.
> 

LGTM.
If needed, we can just do a compatibility symlink using the current
dpdk-pmds path
Bruce Richardson Oct. 1, 2018, 11:06 a.m. UTC | #6
On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote:
> On Mon, 01 Oct 2018 10:46:02 +0100
> Luca Boccassi <bluca@debian.org> wrote:
> 
> > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote:  
> > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote:  
> > > > > Allow users and packagers to override the default dpdk/drivers
> > > > > subdirectory where the PMDs get installed under $lib.
> > > > > 
> > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > ---  
> > > > 
> > > > I'm ok with this change, but what is the current location used by
> > > > distro's
> > > > right now? I mistakenly never checked what was done before I used
> > > > dpdk/drivers as a default value, and I'd like the default to match
> > > > the
> > > > common option if possible.
> > > > 
> > > > /Bruce
> > > >   
> > > 
> > > Replying to my own question, I've just checked on CentOS and Debian,
> > > and it
> > > appears both are using directory "dpdk-pmds" as the subdir name.
> > > Therefore,
> > > let's just make that the default. [Does it need to be configurable in
> > > that
> > > case?]
> > > 
> > > /Bruce  
> > 
> > If the default is the one I expect then I'm fine without having an
> > option (actually happier - less things to configure).
> > 
> > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last January :-)
> > We changed because using a single directory creates problems when
> > multiple different ABI versions are installed, due to the EAL autoload
> > from that directory. So we need a different subdirectory per ABI
> > revision.
> > 
> > We were actually talking with Timothy a while ago to make this
> > consistent across our distros, and perhaps Marco can chip in as well.
> > 
> > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm not
> > too fussy on $something, it can be drivers or pmds or something else.
> > 
> 
> LGTM.
> If needed, we can just do a compatibility symlink using the current
> dpdk-pmds path
> 
One suggestion/comment. Would using a unique directory per release not lead
to clobbering up the lib directory unnecessarily? How about having a single
"dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as a subdir
under that?

E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/
dpdk-pmds/18.11

[The former of the above would be my preference, since I don't like having
hypenated names, and like having "dpdk" alone as a folder name :-)]

/Bruce
Luca Boccassi Oct. 1, 2018, 11:24 a.m. UTC | #7
On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote:
> On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote:
> > On Mon, 01 Oct 2018 10:46:02 +0100
> > Luca Boccassi <bluca@debian.org> wrote:
> > 
> > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson
> > > > wrote:  
> > > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi
> > > > > wrote:  
> > > > > > Allow users and packagers to override the default
> > > > > > dpdk/drivers
> > > > > > subdirectory where the PMDs get installed under $lib.
> > > > > > 
> > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > > ---  
> > > > > 
> > > > > I'm ok with this change, but what is the current location
> > > > > used by
> > > > > distro's
> > > > > right now? I mistakenly never checked what was done before I
> > > > > used
> > > > > dpdk/drivers as a default value, and I'd like the default to
> > > > > match
> > > > > the
> > > > > common option if possible.
> > > > > 
> > > > > /Bruce
> > > > >   
> > > > 
> > > > Replying to my own question, I've just checked on CentOS and
> > > > Debian,
> > > > and it
> > > > appears both are using directory "dpdk-pmds" as the subdir
> > > > name.
> > > > Therefore,
> > > > let's just make that the default. [Does it need to be
> > > > configurable in
> > > > that
> > > > case?]
> > > > 
> > > > /Bruce  
> > > 
> > > If the default is the one I expect then I'm fine without having
> > > an
> > > option (actually happier - less things to configure).
> > > 
> > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last
> > > January :-)
> > > We changed because using a single directory creates problems when
> > > multiple different ABI versions are installed, due to the EAL
> > > autoload
> > > from that directory. So we need a different subdirectory per ABI
> > > revision.
> > > 
> > > We were actually talking with Timothy a while ago to make this
> > > consistent across our distros, and perhaps Marco can chip in as
> > > well.
> > > 
> > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm
> > > not
> > > too fussy on $something, it can be drivers or pmds or something
> > > else.
> > > 
> > 
> > LGTM.
> > If needed, we can just do a compatibility symlink using the current
> > dpdk-pmds path
> > 
> 
> One suggestion/comment. Would using a unique directory per release
> not lead
> to clobbering up the lib directory unnecessarily? How about having a
> single
> "dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as a
> subdir
> under that?
> 
> E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/
> dpdk-pmds/18.11
> 
> [The former of the above would be my preference, since I don't like
> having
> hypenated names, and like having "dpdk" alone as a folder name :-)]
> 
> /Bruce

dpdk/pmds-XX.YY/ would work for me. Timothy and Marco?
Marco Varlese Oct. 2, 2018, 11:02 a.m. UTC | #8
On Mon, 2018-10-01 at 12:24 +0100, Luca Boccassi wrote:
> On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote:
> > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote:
> > > On Mon, 01 Oct 2018 10:46:02 +0100
> > > Luca Boccassi <bluca@debian.org> wrote:
> > > 
> > > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson
> > > > > wrote:  
> > > > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi
> > > > > > wrote:  
> > > > > > > Allow users and packagers to override the default
> > > > > > > dpdk/drivers
> > > > > > > subdirectory where the PMDs get installed under $lib.
> > > > > > > 
> > > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > > > ---  
> > > > > > 
> > > > > > I'm ok with this change, but what is the current location
> > > > > > used by
> > > > > > distro's
> > > > > > right now? I mistakenly never checked what was done before I
> > > > > > used
> > > > > > dpdk/drivers as a default value, and I'd like the default to
> > > > > > match
> > > > > > the
> > > > > > common option if possible.
> > > > > > 
> > > > > > /Bruce
> > > > > >   
> > > > > 
> > > > > Replying to my own question, I've just checked on CentOS and
> > > > > Debian,
> > > > > and it
> > > > > appears both are using directory "dpdk-pmds" as the subdir
> > > > > name.
> > > > > Therefore,
> > > > > let's just make that the default. [Does it need to be
> > > > > configurable in
> > > > > that
> > > > > case?]
> > > > > 
> > > > > /Bruce  
> > > > 
> > > > If the default is the one I expect then I'm fine without having
> > > > an
> > > > option (actually happier - less things to configure).
> > > > 
> > > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last
> > > > January :-)
> > > > We changed because using a single directory creates problems when
> > > > multiple different ABI versions are installed, due to the EAL
> > > > autoload
> > > > from that directory. So we need a different subdirectory per ABI
> > > > revision.
> > > > 
> > > > We were actually talking with Timothy a while ago to make this
> > > > consistent across our distros, and perhaps Marco can chip in as
> > > > well.
> > > > 
> > > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm
> > > > not
> > > > too fussy on $something, it can be drivers or pmds or something
> > > > else.
> > > > 
> > > 
> > > LGTM.
> > > If needed, we can just do a compatibility symlink using the current
> > > dpdk-pmds path
> > > 
> > 
> > One suggestion/comment. Would using a unique directory per release
> > not lead
> > to clobbering up the lib directory unnecessarily? How about having a
> > single
> > "dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as a
> > subdir
> > under that?
> > 
> > E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/
> > dpdk-pmds/18.11
> > 
> > [The former of the above would be my preference, since I don't like
> > having
> > hypenated names, and like having "dpdk" alone as a folder name :-)]
> > 
> > /Bruce
> 
> dpdk/pmds-XX.YY/ would work for me. Timothy and Marco?
That would work for us.
However, I would suggest to have the path to be configurable (feature to be
dropped in maybe next release). Just to make sure the transition can happen
without pain in the remote circumstance that something goes wrong with
packaging...
>
Bruce Richardson Oct. 2, 2018, 12:23 p.m. UTC | #9
On Tue, Oct 02, 2018 at 01:02:26PM +0200, Marco Varlese wrote:
> On Mon, 2018-10-01 at 12:24 +0100, Luca Boccassi wrote:
> > On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote:
> > > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote:
> > > > On Mon, 01 Oct 2018 10:46:02 +0100
> > > > Luca Boccassi <bluca@debian.org> wrote:
> > > > 
> > > > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > > > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson
> > > > > > wrote:  
> > > > > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi
> > > > > > > wrote:  
> > > > > > > > Allow users and packagers to override the default
> > > > > > > > dpdk/drivers
> > > > > > > > subdirectory where the PMDs get installed under $lib.
> > > > > > > > 
> > > > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > > > > ---  
> > > > > > > 
> > > > > > > I'm ok with this change, but what is the current location
> > > > > > > used by
> > > > > > > distro's
> > > > > > > right now? I mistakenly never checked what was done before I
> > > > > > > used
> > > > > > > dpdk/drivers as a default value, and I'd like the default to
> > > > > > > match
> > > > > > > the
> > > > > > > common option if possible.
> > > > > > > 
> > > > > > > /Bruce
> > > > > > >   
> > > > > > 
> > > > > > Replying to my own question, I've just checked on CentOS and
> > > > > > Debian,
> > > > > > and it
> > > > > > appears both are using directory "dpdk-pmds" as the subdir
> > > > > > name.
> > > > > > Therefore,
> > > > > > let's just make that the default. [Does it need to be
> > > > > > configurable in
> > > > > > that
> > > > > > case?]
> > > > > > 
> > > > > > /Bruce  
> > > > > 
> > > > > If the default is the one I expect then I'm fine without having
> > > > > an
> > > > > option (actually happier - less things to configure).
> > > > > 
> > > > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last
> > > > > January :-)
> > > > > We changed because using a single directory creates problems when
> > > > > multiple different ABI versions are installed, due to the EAL
> > > > > autoload
> > > > > from that directory. So we need a different subdirectory per ABI
> > > > > revision.
> > > > > 
> > > > > We were actually talking with Timothy a while ago to make this
> > > > > consistent across our distros, and perhaps Marco can chip in as
> > > > > well.
> > > > > 
> > > > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm
> > > > > not
> > > > > too fussy on $something, it can be drivers or pmds or something
> > > > > else.
> > > > > 
> > > > 
> > > > LGTM.
> > > > If needed, we can just do a compatibility symlink using the current
> > > > dpdk-pmds path
> > > > 
> > > 
> > > One suggestion/comment. Would using a unique directory per release
> > > not lead
> > > to clobbering up the lib directory unnecessarily? How about having a
> > > single
> > > "dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as a
> > > subdir
> > > under that?
> > > 
> > > E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/
> > > dpdk-pmds/18.11
> > > 
> > > [The former of the above would be my preference, since I don't like
> > > having
> > > hypenated names, and like having "dpdk" alone as a folder name :-)]
> > > 
> > > /Bruce
> > 
> > dpdk/pmds-XX.YY/ would work for me. Timothy and Marco?
> That would work for us.
> However, I would suggest to have the path to be configurable (feature to be
> dropped in maybe next release). Just to make sure the transition can happen
> without pain in the remote circumstance that something goes wrong with
> packaging...
> > 
> -- 
> Marco V
> 
Yes, I think it needs to be configurable for the forseeable future. If the
DPDK version is to be put in the path then we either need to always use a
configurable version, since we can't hardcode a version number in the
default, or else we need to put logic in the meson.build file to always
insert a version number.

/Bruce
Luca Boccassi Oct. 2, 2018, 1:07 p.m. UTC | #10
On Tue, 2018-10-02 at 13:23 +0100, Bruce Richardson wrote:
> On Tue, Oct 02, 2018 at 01:02:26PM +0200, Marco Varlese wrote:
> > On Mon, 2018-10-01 at 12:24 +0100, Luca Boccassi wrote:
> > > On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote:
> > > > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli
> > > > wrote:
> > > > > On Mon, 01 Oct 2018 10:46:02 +0100
> > > > > Luca Boccassi <bluca@debian.org> wrote:
> > > > > 
> > > > > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote:
> > > > > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce
> > > > > > > Richardson
> > > > > > > wrote:  
> > > > > > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi
> > > > > > > > wrote:  
> > > > > > > > > Allow users and packagers to override the default
> > > > > > > > > dpdk/drivers
> > > > > > > > > subdirectory where the PMDs get installed under $lib.
> > > > > > > > > 
> > > > > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > > > > > ---  
> > > > > > > > 
> > > > > > > > I'm ok with this change, but what is the current
> > > > > > > > location
> > > > > > > > used by
> > > > > > > > distro's
> > > > > > > > right now? I mistakenly never checked what was done
> > > > > > > > before I
> > > > > > > > used
> > > > > > > > dpdk/drivers as a default value, and I'd like the
> > > > > > > > default to
> > > > > > > > match
> > > > > > > > the
> > > > > > > > common option if possible.
> > > > > > > > 
> > > > > > > > /Bruce
> > > > > > > >   
> > > > > > > 
> > > > > > > Replying to my own question, I've just checked on CentOS
> > > > > > > and
> > > > > > > Debian,
> > > > > > > and it
> > > > > > > appears both are using directory "dpdk-pmds" as the
> > > > > > > subdir
> > > > > > > name.
> > > > > > > Therefore,
> > > > > > > let's just make that the default. [Does it need to be
> > > > > > > configurable in
> > > > > > > that
> > > > > > > case?]
> > > > > > > 
> > > > > > > /Bruce  
> > > > > > 
> > > > > > If the default is the one I expect then I'm fine without
> > > > > > having
> > > > > > an
> > > > > > option (actually happier - less things to configure).
> > > > > > 
> > > > > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last
> > > > > > January :-)
> > > > > > We changed because using a single directory creates
> > > > > > problems when
> > > > > > multiple different ABI versions are installed, due to the
> > > > > > EAL
> > > > > > autoload
> > > > > > from that directory. So we need a different subdirectory
> > > > > > per ABI
> > > > > > revision.
> > > > > > 
> > > > > > We were actually talking with Timothy a while ago to make
> > > > > > this
> > > > > > consistent across our distros, and perhaps Marco can chip
> > > > > > in as
> > > > > > well.
> > > > > > 
> > > > > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for
> > > > > > you? I'm
> > > > > > not
> > > > > > too fussy on $something, it can be drivers or pmds or
> > > > > > something
> > > > > > else.
> > > > > > 
> > > > > 
> > > > > LGTM.
> > > > > If needed, we can just do a compatibility symlink using the
> > > > > current
> > > > > dpdk-pmds path
> > > > > 
> > > > 
> > > > One suggestion/comment. Would using a unique directory per
> > > > release
> > > > not lead
> > > > to clobbering up the lib directory unnecessarily? How about
> > > > having a
> > > > single
> > > > "dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as
> > > > a
> > > > subdir
> > > > under that?
> > > > 
> > > > E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/
> > > > dpdk-pmds/18.11
> > > > 
> > > > [The former of the above would be my preference, since I don't
> > > > like
> > > > having
> > > > hypenated names, and like having "dpdk" alone as a folder name
> > > > :-)]
> > > > 
> > > > /Bruce
> > > 
> > > dpdk/pmds-XX.YY/ would work for me. Timothy and Marco?
> > 
> > That would work for us.
> > However, I would suggest to have the path to be configurable
> > (feature to be
> > dropped in maybe next release). Just to make sure the transition
> > can happen
> > without pain in the remote circumstance that something goes wrong
> > with
> > packaging...
> > > 
> > 
> > -- 
> > Marco V
> > 
> 
> Yes, I think it needs to be configurable for the forseeable future.
> If the
> DPDK version is to be put in the path then we either need to always
> use a
> configurable version, since we can't hardcode a version number in the
> default, or else we need to put logic in the meson.build file to
> always
> insert a version number.
> 
> /Bruce

Ok, in v2 I added a small bit of logic to set the default to the major
version number (and also the override option).

Patch
diff mbox series

diff --git a/meson.build b/meson.build
index c9af33532d..123e3e81d6 100644
--- a/meson.build
+++ b/meson.build
@@ -15,7 +15,8 @@  dpdk_libraries = []
 dpdk_drivers = []
 dpdk_extra_ldflags = []
 
-driver_install_path = join_paths(get_option('libdir'), 'dpdk/drivers')
+driver_install_path = join_paths(get_option('libdir'),
+	get_option('drivers_install_subdir'))
 eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
 
 # configure the build, and make sure configs here and in config folder are
diff --git a/meson_options.txt b/meson_options.txt
index cb58b1b607..0834ae364e 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,5 +1,7 @@ 
 option('allow_invalid_socket_id', type: 'boolean', value: false,
 	description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly')
+option('drivers_install_subdir', type: 'string', value: 'dpdk/drivers',
+	description: 'subdirectory of libdir where to install PMDs')
 option('enable_driver_mlx_glue', type: 'boolean', value: false,
 	description: 'Enable glue library for Mellanox ConnectX-3/4/5 NIC PMD')
 option('enable_kmods', type: 'boolean', value: true,