diff mbox series

test: reduce duration for timer autotest

Message ID 1537617311-1092-1-git-send-email-jananeex.m.parthasarathy@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series test: reduce duration for timer autotest |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jananee Parthasarathy Sept. 22, 2018, 11:55 a.m. UTC 
  Reduced the test duration of timer_autotest.
The number of iterations was very large to test the timer functionality.
Although the method to identify random timers can be different,
many iterations would be needed for stress or performance test only.

Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
---
 test/test/test_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pattan, Reshma Oct. 10, 2018, 4:24 p.m. UTC | #1 
Hi 

> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Saturday, September 22, 2018 12:55 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; rsanford@akamai.com;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
> Subject: [PATCH] test: reduce duration for timer autotest
> 
> 
>  	/* pick random timer to reset, stopping them first half the time */
> -	for (i = 0; i < 100000; i++) {
> +	for (i = 0; i < NB_STRESS2_TIMERS; i++) {

Just reduce the iteration to some number, instead of using macro NB_STRESS2_TIMERS, which seem to be specific for number of timers.

(Or) can this test be considered as perf ? and ignore above changes.? 

Any one any comments?

Thanks,
Reshma
Jananee Parthasarathy Oct. 22, 2018, 7:43 a.m. UTC | #2 
Hi Reshma,

>-----Original Message-----
>From: Pattan, Reshma
>Sent: Wednesday, October 10, 2018 9:54 PM
>To: Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
>dev@dpdk.org
>Cc: rsanford@akamai.com
>Subject: RE: [PATCH] test: reduce duration for timer autotest
>
>Hi
>
>> -----Original Message-----
>> From: Parthasarathy, JananeeX M
>> Sent: Saturday, September 22, 2018 12:55 PM
>> To: dev@dpdk.org
>> Cc: Pattan, Reshma <reshma.pattan@intel.com>; rsanford@akamai.com;
>> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
>> Subject: [PATCH] test: reduce duration for timer autotest
>>
>>
>>  	/* pick random timer to reset, stopping them first half the time */
>> -	for (i = 0; i < 100000; i++) {
>> +	for (i = 0; i < NB_STRESS2_TIMERS; i++) {
>
>Just reduce the iteration to some number, instead of using macro
>NB_STRESS2_TIMERS, which seem to be specific for number of timers.
>
>(Or) can this test be considered as perf ? and ignore above changes.?
>
>Any one any comments?
>
>Thanks,
>Reshma
>

NB_STRESS2_TIMERS is used for all iterations in the test and timer structure is allocated NB_STRESS2_TIMERS only, hence used the same.

This seems to be stress test so better to be considered as perf test and no changes are required.

Please let us know about it.

Regards
MP.Jananee
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
Pattan, Reshma Oct. 24, 2018, 12:21 p.m. UTC | #3 
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Monday, October 22, 2018 8:43 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>; dev@dpdk.org
> Cc: rsanford@akamai.com
> Subject: RE: [PATCH] test: reduce duration for timer autotest
> 
> 
> NB_STRESS2_TIMERS is used for all iterations in the test and timer structure is
> allocated NB_STRESS2_TIMERS only, hence used the same.
> 
> This seems to be stress test so better to be considered as perf test and no
> changes are required.
> 

I am fine to consider this as perf test category.

Thanks,
Reshma
Pattan, Reshma Nov. 5, 2018, 4:04 p.m. UTC | #4 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pattan, Reshma
> Sent: Wednesday, October 10, 2018 5:24 PM
> To: Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> dev@dpdk.org
> Cc: rsanford@akamai.com
> Subject: Re: [dpdk-dev] [PATCH] test: reduce duration for timer autotest
> 
> Hi
> 
> > -----Original Message-----
> > From: Parthasarathy, JananeeX M

When test was ran with reasonable number of lcores ex: 16 the test time is within targeted value of 10sec.
Without specifying the core limit test will run on all available cores and can take longer time. 

So this patch can be Nacked now as expected timings are achieved by limiting the number of cores.


Nacked-by: Reshma Pattan <reshma.pattan@intel.com>
diff mbox series

Patch

diff --git a/test/test/test_timer.c b/test/test/test_timer.c
index e2aab5308..d625f1f4d 100644
--- a/test/test/test_timer.c
+++ b/test/test/test_timer.c
@@ -358,7 +358,7 @@  timer_stress2_main_loop(__attribute__((unused)) void *arg)
 				timer_stress2_cb, NULL);
 
 	/* pick random timer to reset, stopping them first half the time */
-	for (i = 0; i < 100000; i++) {
+	for (i = 0; i < NB_STRESS2_TIMERS; i++) {
 		int r = rand() % NB_STRESS2_TIMERS;
 		if (i % 2)
 			rte_timer_stop(&timers[r]);