From patchwork Wed Sep 19 15:04:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44955 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B1EF5B16; Wed, 19 Sep 2018 17:04:59 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id AADF058CB for ; Wed, 19 Sep 2018 17:04:56 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id v90-v6so6194031wrc.0 for ; Wed, 19 Sep 2018 08:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=krp8cN+azK/Gl8HzMkdW39i9WC4ID5P84vDwzoRDGB0=; b=l5JEg87alTj0dMDBuFtq/TDF0NmOxbpR9EqUOhrluuTm4qTvuP8gNCR4lVn4Hq0K5O +FKrfVjTgljlNkpeZ5nK3DRi0mUK+v5Xkk93kT3BkSaMhbhXyvLF2oc6lBNGGJEterpo 1ZNNyDfITjjqjODxathuMVX0SidT/Gm+qLKv/B7E9Kqc6LVryJSQL/3GUcn6uQ+E97a6 69gKk1B9Rx0Cr563VLySqPgkytp7/18CTUqBqfS9KoWCoRhAjNFCZkyIvXbjJR6/dPYb 6dp9ATdIbzMmzjwQ9pvyYWGjJOjuwQqk+xzhaKQwpwcpjMt42sr16f4u206M32nvj7n6 FzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=krp8cN+azK/Gl8HzMkdW39i9WC4ID5P84vDwzoRDGB0=; b=Mh/LysfHX8P3icidd2/TP1SYNufDjLb2nbAycTwZI7c1IWzwGChhiwSYsV7b0axT5v DAtc/WdmCseGqUaQOQBwhTsuLVBy5fmBWVEvr0QxFtPFQ3iwVKLO7Iu/AXFjmWV2IOAT RgtlWK7o6h0koTm+9yrMA7sDWnpXHSDocRQGkIFb6giUtOr9BhRZumwMQgbdEZgmxoFd kQlRAGXB8XjTO79pkBjkzQwiBZ3Q2Fsu6g955qdRiDqlInHv3gyLs8CqrnM/JnSP5RdZ 0p+r6vFxBh4DqkPVVCGT3TAT1bgwcP/QY5WDhqvQoCd9K7eKUvUt9BeR9a55OWhsz8xh t1XA== X-Gm-Message-State: APzg51B8ySXAdK3GtSS8e77/IVm5+GUHPXenzXHiaFPiKyX/wDFo9liM +9dqrVhdSsw8TvWx5Fdn+6OckbhDDkKRkA== X-Google-Smtp-Source: ANB0VdbHnvxKfKlMvPskr4hMIXbwMRS0Luax0dasGOSsouW3x3ySOojzs9twM2rieVhtjUMnN0O4hw== X-Received: by 2002:adf:f112:: with SMTP id r18-v6mr11548999wro.29.1537369496129; Wed, 19 Sep 2018 08:04:56 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:55 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:09 +0200 Message-Id: <20180919150409.22880-5-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 4/4] net/ixgbe: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in ixgbe_vf representor. Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_vf_representor.c b/drivers/net/ixgbe/ixgbe_vf_representor.c index db516d9910b8..b0fbbc49f6ed 100644 --- a/drivers/net/ixgbe/ixgbe_vf_representor.c +++ b/drivers/net/ixgbe/ixgbe_vf_representor.c @@ -65,7 +65,7 @@ ixgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM | DEV_TX_OFFLOAD_SCTP_CKSUM | - DEV_TX_OFFLOAD_TCP_TSO; + DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_MULTI_SEGS; /**< Device TX offload capabilities. */ dev_info->speed_capa =