From patchwork Wed Sep 19 15:04:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44954 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 723DC5911; Wed, 19 Sep 2018 17:04:57 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 32F82532C for ; Wed, 19 Sep 2018 17:04:55 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id o18-v6so7404569wmc.0 for ; Wed, 19 Sep 2018 08:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o2ktDB/lkZv4sSowzcIf5JMxmbSHHQBzW0rDIfcwYGY=; b=0KCVsipAkAH9t8OUIlS4TSV81SVZXRQN5EC8V/pBVTkKad+03jHcRNgwB4RB2Zchka IjfPD5qS0G269JqAXHUig9Pog+Yp+++NBVa1JjsTLL50vS60XWWRmnwto4tI9gaBomDt /pTjRmF2rzrjOyY/qRdGF0mtZkacFuQ1PB56Ee/XKUOcczYzP0IFLv4qey4QvDNFdQms R3Gsh44sziWnUVbZ057G+UlYXcrZ829rLGsWk72vfBGVX7viLGbanbJuCTwruYstdJ4G nSP8H+i7m2SyOhx36ZSSJDscVM4UQtJNKFXXASwLtUzwjWLXMWm62B/4HRS53lR9ZanA bmww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o2ktDB/lkZv4sSowzcIf5JMxmbSHHQBzW0rDIfcwYGY=; b=iGyTuvRPxQwUGkSeyIEKeobU8+ols66j2QVEZ9VRbOUmLNDfyvpLf9NPXOYNew+PBY LrJ7lz5H04rDUcdrZe0GNcC+DGhunBPossVcOf/U7+B2PAU3OyQgm8b2EQfTPrLN1H24 L3CJcjgD4+KS04icfGeU85svI5K8fDKNh8sAe8JevuTIaEFtqhQc14dUk2xCUa+76UlX AhXs1+Uu4Q5YE9XrlekcVnu8L5hq9YB37Mp7Jy+RqM+6mR/cPZEBC2qb+peiHDoYU+BM QdQDEi8zeBPLEjeFnLYIBqehn0WHixURJzVAt+kxcbOqhNnrfY6sszPcsYyIC0IsDNZu JGlg== X-Gm-Message-State: APzg51A0i6Q8sKdyB+gX/hxOFjw+8lBzHxjfpidi1wvtc9QXvgWlMbT6 qbQGBd8Ej25/TysWWj7AFI2QXvb9nMlydA== X-Google-Smtp-Source: ANB0Vdbbx45FfCwHwm2tMDvn4MoDAQFmqu/HvKQOk7JfF6SguxozCHFuftLoggK2Th38e+j9zGqRwQ== X-Received: by 2002:a1c:e0d7:: with SMTP id x206-v6mr21345761wmg.74.1537369494709; Wed, 19 Sep 2018 08:04:54 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:53 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:08 +0200 Message-Id: <20180919150409.22880-4-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 3/4] net/i40e: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in i40e_vf representor. Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/i40e/i40e_vf_representor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c index f9f131611016..0bfbb4f6011f 100644 --- a/drivers/net/i40e/i40e_vf_representor.c +++ b/drivers/net/i40e/i40e_vf_representor.c @@ -48,6 +48,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM; dev_info->tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_QINQ_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM |