From patchwork Wed Sep 19 15:04:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44952 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74CD14F98; Wed, 19 Sep 2018 17:04:53 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 9E4A54CA6 for ; Wed, 19 Sep 2018 17:04:51 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id q8-v6so7391252wmq.4 for ; Wed, 19 Sep 2018 08:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=++gUUWGZ9jmHHtmsGPA93Ez1c+sgVSFgHgOnbAzbNB8=; b=XRg5R+xGQiVNzZdItLBmDSvywXuLnOVdtsrs6BBBLyOwn4kBBX+iBAwx704nKjaT8o 7+6DWal7yuB0/Fe/+urKXSnTgzhF1fxPQRWTa2WOU6V+u7rtTi986htUr40UqWSZrd3+ sqGezwwJxHnXGm/R3dK4VauBqSZocjahUjU0zYA+0wJzLfWkm9OP7V0BQe0K7s2qxd6n fSjJiBrZDP7im1nK+NifoHv2kSmNqnnLIGiMa2+ig67a1XbK1dKY4J0DSRFE/8+G/JoP Oq0oL+5ygeqFfC3cYT5NuGoBSbhs6LD23h1KD5oSvC26DRSFuENlG6b98FdZC3WEOPj8 UPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=++gUUWGZ9jmHHtmsGPA93Ez1c+sgVSFgHgOnbAzbNB8=; b=fqEEGiAEZvUI+ghovWnL3phFugT0e41jfPK2QuhGGEWf9+m6vCiLDIXq5TTfqOWrXS W7JJlGZkIBhr/WNVFqoeKOdMB7AiKtmBKNEvnlkvdy6jzBPPotaU27+tzV8Oa3RKEmDT xrwGUsKAb/OeWYKLm6LEHWNlhtTqAVDSSM876kvsQWqXzTP5MT8bKNDJGBpmtElvEYCP AcDYiDLW0KqVHQ+aP3LxIsj6lZ9DTTUUqFg9kOambtNu7apVK2kCQdShMc0nJP5JrMdb RE7BNWp5b7+hG0gn4qxdGW+uHoXb/uVA+x73fDnI8qPolHBroya9krxHHF066oIOVHU+ Ur8g== X-Gm-Message-State: APzg51ApBGUk6SFfiEFLS2Qag4ss55/2rY/lgFACkJKYAJIicVGF1A4U sI8Vil4jKI04T6/R33XgI23MfoJR0iMZLA== X-Google-Smtp-Source: ANB0VdbKD91OrPM26n5/g98dQuqkfajyEVpvSdGuH5fJz1tYIcvIudZi/n4PBVHoSBF4jxGRW2Mubg== X-Received: by 2002:a7b:c18a:: with SMTP id y10-v6mr21902939wmi.87.1537369491121; Wed, 19 Sep 2018 08:04:51 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:50 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:06 +0200 Message-Id: <20180919150409.22880-2-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 1/4] net/e1000: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Fixes: e5c05e6590ea ("net/e1000: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/e1000/em_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 1103a1839058..087e68304cc8 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -1160,6 +1160,7 @@ em_get_tx_port_offloads_capa(struct rte_eth_dev *dev) RTE_SET_USED(dev); tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM |