From patchwork Fri Aug 31 09:01:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 44074 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8696A56A3; Fri, 31 Aug 2018 11:01:47 +0200 (CEST) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 730994F91 for ; Fri, 31 Aug 2018 11:01:30 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id y2-v6so4483493wma.1 for ; Fri, 31 Aug 2018 02:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IzPbNQ/8NnpkShHPveVJrOxLQ4CzraLvD61cufN3nAo=; b=hBuyLcZjXlPLvwFv0njmJSttlO3fGNbfL44UCo8IClmg3LEsT69WJXFzB9RV65Nltz FcL6FfosVF0gJ0oAXKxOI8L4tmDFRgDsOjKSHLUYXq9Qaf1t+VV1UOgnW+TT6P3Qdv01 MKQVnuIGpoMXesdlLPcuxs7lY1m7G/Dxh0ug35kV4OhnEWSV9fmyrupC5rMvEgOkIfLy z22oU8YbTu+WfABA+j7Dw8xhxi1ruUHjkPuLpDLg5f+RbhXCjbXW6f1byOmGohvfmBCK o7S+bpwujQIeGB37Y/3AAlOdaskDUSR68V0TC1Mre+0cmxohrCz1+VnxCamrLbv999bK 6V1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IzPbNQ/8NnpkShHPveVJrOxLQ4CzraLvD61cufN3nAo=; b=Z4H0yt4/pGnsVUoZi/DAO7zfHR3a4fd0xJBwQ0hUKCNZvdB4HJgoKi3b3x4UOuju2e 2URk82uvf60EqGdR+6k4XDaRQrhrEs0zn6Ivot3d+ANFXfG/55g0t1PHXXqpsf/Bgs+C JvmTPYn4D4QL07li+CbvJ/Lf7b/PjfiNyauMkIhrEhAQf1JKNvF3bl/jN1AFksT9GELn KMQH2mDZ7nMIa072Rn6YfYQdhgn/jV7bomjHqPLCgV0yvga+59TZ9NN9AhHn7jymHPZ+ Nzg+BkOghhlHOYwUDCfn+tLAjc4MEc4ySmAjSnCAuT/yBN621S1NjF2LZEUGavff5qe4 gkLQ== X-Gm-Message-State: APzg51Cim3xh0Q1/2qOcEsVLkYh54EFNrXujQWJE8ZuHwXf6HJhVM6ow DAhYGUXtRorhQEdv8fhwctKJEA== X-Google-Smtp-Source: ANB0VdaKWdRCEB1IVmg6RfJUAMA40AM+Mw8Dh2Xd/2JDpA+MKtTq2r4g/jEC6Vp0g0ZxX3Sn6p+7kw== X-Received: by 2002:a1c:a94d:: with SMTP id s74-v6mr4334212wme.39.1535706090172; Fri, 31 Aug 2018 02:01:30 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d10-v6sm14039839wrv.70.2018.08.31.02.01.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Aug 2018 02:01:29 -0700 (PDT) Date: Fri, 31 Aug 2018 11:01:13 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Gaetan Rivet Message-ID: <20180831085337.21419-8-adrien.mazarguil@6wind.com> References: <20180803132032.29038-1-adrien.mazarguil@6wind.com> <20180831085337.21419-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180831085337.21419-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v3 7/7] ethdev: deprecate rte_flow_copy function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" No users left for this function, time to deprecate it. Signed-off-by: Adrien Mazarguil Cc: Thomas Monjalon Cc: Ferruh Yigit Cc: Andrew Rybchenko Cc: Gaetan Rivet --- v3 changes: - Removed deprecation notice (finally got Ferruh's point), made patch last in series. v2 changes: - Patch was not present in original series. --- doc/guides/rel_notes/deprecation.rst | 7 ------- lib/librte_ethdev/rte_flow.h | 7 ++++++- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e2dbee317..48cfb266b 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -88,10 +88,3 @@ Deprecation Notices - ``rte_pdump_set_socket_dir`` will be removed; - The parameter, ``path``, of ``rte_pdump_init`` will be removed; - The enum ``rte_pdump_socktype`` will be removed. - -* ethdev: flow API function ``rte_flow_copy()`` will be deprecated in v18.11 - in favor of ``rte_flow_conv()`` (which will appear in that version) and - subsequently removed for v19.02. - - This is due to a lack of flexibility and reliance on a type unusable with - C++ programs (struct rte_flow_desc). diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index 052ceefb6..f062ffead 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -2332,6 +2332,7 @@ rte_flow_error_set(struct rte_flow_error *error, const char *message); /** + * @deprecated * @see rte_flow_copy() */ struct rte_flow_desc { @@ -2343,10 +2344,13 @@ struct rte_flow_desc { }; /** + * @deprecated * Copy an rte_flow rule description. * * This interface is kept for compatibility with older applications but is - * implemented as a wrapper to rte_flow_conv(). + * implemented as a wrapper to rte_flow_conv(). It is deprecated due to its + * lack of flexibility and reliance on a type unusable with C++ programs + * (struct rte_flow_desc). * * @param[in] fd * Flow rule description. @@ -2365,6 +2369,7 @@ struct rte_flow_desc { * If len is lower than the size of the flow, the number of bytes that would * have been written to desc had it been sufficient. Nothing is written. */ +__rte_deprecated size_t rte_flow_copy(struct rte_flow_desc *fd, size_t len, const struct rte_flow_attr *attr,