From patchwork Thu Aug 30 13:42:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ga=C3=ABtan_Rivet?= X-Patchwork-Id: 44034 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BDB865F0D; Thu, 30 Aug 2018 15:43:04 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by dpdk.org (Postfix) with ESMTP id 73EBB559A for ; Thu, 30 Aug 2018 15:42:47 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id v16-v6so8113621wro.11 for ; Thu, 30 Aug 2018 06:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KW0k/wg4c/tlyFq0Qo9mW75M4ncJIyCls2QoUCXssyk=; b=JcLlZc716WIXRHjWcxh2wdLcnbSOv07rEPwsoz2f7aOIj/S9zEtFBl0GdNdUagIV0E KEfMFWrR2zfwMXIK58EIKCX5KirgnC8/aNsdNQ5n/Z6TGOs5fgoO5pDRoy5QI7TJtsUQ M0Nhdk2u/NWYPjtqg+VRooJX0WQbR/LjdaDGsCgD21ENU4q5MbLOOTx1ghY45vsmgK/1 0Sofco87HZIt6QXlqVDoPC9OL9X4+e25cuqwxEFMYP8bNV7ornJibXNMPQhD06KU9hcc cSbFUp3JRNstudPgs4UntmV2Q7gZHEAWnmhFhYP/KLVBQpNPaUDigKoSOUF5HGDwB5BJ MJDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KW0k/wg4c/tlyFq0Qo9mW75M4ncJIyCls2QoUCXssyk=; b=IijzQfQvidQx6kqmx5bY5PEcUYu0SPXZyYSiNRkxOyLd8ne7+NqarWxX0iW8EKEKlP xFb/WNulstaCcBnmkYef4CsyZtKi9+Aj2ewKhURs4CXA4p9P0rKflt6HZqey3+bJNYn5 kS2RRPo+rsC2y0CRS9YjXoOMjLErR9Lh1aqnznD89IRYddsK8W0FEx+vxUZ1Xf3eocV5 Msrjd359zoZ2LwN6lHzkW6nODKVoOqfnVSknIMWSWyxA1wAM/r06zlpsuqBaf/7KhzGJ U/3o1WzcTSxLEtUQmg4xqHQ4XAv9jkO+49LSAsmm/64cp/NpdSeWkXvvrK25nJpV4ste Ka6A== X-Gm-Message-State: APzg51C3RBky+1Ic5pPFzvkCbP9jo2aK4xkbP/kpESZmpqvIoliLE/J7 AaPuQMlGDXadHpaabX+llymBwNm1zX0= X-Google-Smtp-Source: ANB0VdakDTy1PSyCnsrXlqvVRgCTpSi9QV+12cM4Z1Cm4IToh8bY8KH2pjPzf3bXD5Tl/ewC5SOGBA== X-Received: by 2002:adf:c4b1:: with SMTP id m46-v6mr8030218wrf.103.1535636566845; Thu, 30 Aug 2018 06:42:46 -0700 (PDT) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w10-v6sm5247731wrp.31.2018.08.30.06.42.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 06:42:45 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Thu, 30 Aug 2018 15:42:03 +0200 Message-Id: <712878880719df833be5c45f866fae04ba5379aa.1535633784.git.gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 12/13] ethdev: process declarative eth devargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Process the class-specific arguments in a devargs. This processing takes the form of setting the proper eth_dev fields when relevant. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/eth_private.h | 5 +++ lib/librte_ethdev/rte_class_eth.c | 62 +++++++++++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 7 ++++ 3 files changed, 74 insertions(+) diff --git a/lib/librte_ethdev/eth_private.h b/lib/librte_ethdev/eth_private.h index 0f5c6d5c4..c0c065165 100644 --- a/lib/librte_ethdev/eth_private.h +++ b/lib/librte_ethdev/eth_private.h @@ -19,6 +19,11 @@ struct rte_eth_dev * eth_find_device(const struct rte_eth_dev *_start, rte_eth_cmp_t cmp, const void *data); +/* Generic rte_eth_dev parameters processor. */ +int +rte_eth_dev_args_parse(struct rte_eth_dev *eth_dev, + struct rte_devargs *da); + #ifdef __cplusplus } #endif diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c index d8d8e8845..18fdef605 100644 --- a/lib/librte_ethdev/rte_class_eth.c +++ b/lib/librte_ethdev/rte_class_eth.c @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -35,6 +36,19 @@ struct eth_dev_match_arg { .kvlist = (k), \ }) +typedef int (*eth_dev_set_t)(struct rte_eth_dev *edev, const char *value); + +static enum eth_params +ethdev_param_id(const char *key) +{ + int i; + + for (i = 0; i < RTE_ETH_PARAMS_MAX; i++) + if (strcmp(key, eth_params_keys[i]) == 0) + return i; + return RTE_ETH_PARAMS_MAX; +} + static int eth_dev_match(const struct rte_eth_dev *edev, const void *_arg) @@ -79,6 +93,54 @@ eth_dev_iterate(const void *start, return edev; } +static int +eth_dev_set_name(struct rte_eth_dev *edev, + const char *value) +{ + snprintf(edev->data->name, + sizeof(edev->data->name), + "%s", value); + return 0; +} + +static int +ethdev_args_process(const char *key, + const char *value, + void *_edev) +{ + static eth_dev_set_t eth_dev_set[] = { + [RTE_ETH_PARAMS_NAME] = eth_dev_set_name, + [RTE_ETH_PARAMS_MAX] = NULL, + }; + struct rte_eth_dev *edev = _edev; + int param; + + param = ethdev_param_id(key); + if (eth_dev_set[param]) + return eth_dev_set[param](edev, value); + return 0; +} + +int +rte_eth_dev_args_parse(struct rte_eth_dev *edev, + struct rte_devargs *devargs) +{ + struct rte_kvargs *kvargs = NULL; + + if (devargs == NULL || devargs->cls_str == NULL) + return 0; + + kvargs = rte_kvargs_parse_delim(devargs->cls_str, eth_params_keys, "/"); + if (kvargs == NULL) { + RTE_LOG(ERR, EAL, "cannot parse argument list\n"); + return -EINVAL; + } + if (rte_kvargs_process(kvargs, NULL, ethdev_args_process, edev)) + return -1; + rte_kvargs_free(kvargs); + return 0; +} + struct rte_class rte_class_eth = { .dev_iterate = eth_dev_iterate, }; diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 4c3202505..633c7ee82 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -41,6 +41,7 @@ #include "rte_ethdev.h" #include "rte_ethdev_driver.h" #include "ethdev_profile.h" +#include "eth_private.h" int rte_eth_dev_logtype; @@ -3496,6 +3497,12 @@ rte_eth_dev_create(struct rte_device *device, const char *name, } } + retval = rte_eth_dev_args_parse(ethdev, device->devargs); + if (retval) { + RTE_LOG(ERR, EAL, "ethdev parsing failed"); + goto probe_failed; + } + retval = ethdev_init(ethdev, init_params); if (retval) { RTE_LOG(ERR, EAL, "ethdev initialisation failed");