| Message ID | 1535634012-17832-1-git-send-email-amo@semihalf.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
On Thu, Aug 30, 2018 at 4:00 PM, Andrzej Ostruszka <amo@semihalf.com> wrote: > On some systems /bin/sh does not support '-d' option of 'read'. > So instead of /bin/sh use /bin/bash. > > Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") > Cc: arnon@qwilt.com > Signed-off-by: Andrzej Ostruszka <amo@semihalf.com> > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index ba795ad..db7afc4 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -1,4 +1,4 @@ > -#! /bin/sh > +#! /bin/bash > # SPDX-License-Identifier: BSD-3-Clause > # Copyright 2015 6WIND S.A. > > -- > 2.7.4 > > Acked-By: Arnon Warshavsky <arnon@qwilt.com> thanks /Arnon
On Fri, Aug 31, 2018 at 10:00 AM, Arnon Warshavsky <arnon@qwilt.com> wrote: > On Thu, Aug 30, 2018 at 4:00 PM, Andrzej Ostruszka <amo@semihalf.com> wrote: > >> On some systems /bin/sh does not support '-d' option of 'read'. >> So instead of /bin/sh use /bin/bash. >> >> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") >> Cc: arnon@qwilt.com >> Signed-off-by: Andrzej Ostruszka <amo@semihalf.com> >> --- >> devtools/checkpatches.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >> index ba795ad..db7afc4 100755 >> --- a/devtools/checkpatches.sh >> +++ b/devtools/checkpatches.sh >> @@ -1,4 +1,4 @@ >> -#! /bin/sh >> +#! /bin/bash >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright 2015 6WIND S.A. >> >> -- >> 2.7.4 >> >> > > Acked-By: Arnon Warshavsky <arnon@qwilt.com> Tested on Ubuntu 18.04, thanks. Tested-by: David Marchand <david.marchand@6wind.com>
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index ba795ad..db7afc4 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -1,4 +1,4 @@ -#! /bin/sh +#! /bin/bash # SPDX-License-Identifier: BSD-3-Clause # Copyright 2015 6WIND S.A.
On some systems /bin/sh does not support '-d' option of 'read'. So instead of /bin/sh use /bin/bash. Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") Cc: arnon@qwilt.com Signed-off-by: Andrzej Ostruszka <amo@semihalf.com> --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)