examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion

Message ID 20180825192240.6503-1-ramirose@gmail.com
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series
  • examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Rami Rosen Aug. 25, 2018, 7:22 p.m.
This patch removes an unnecessary definition of MAX_PRINT_BUFF 
in examples/vhost/main.c, since it is no longer being used.

Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 examples/vhost/main.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Tiwei Bie Aug. 30, 2018, 4:40 a.m. | #1
> [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion

s/defintion/definition/

Apart from that,

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks

On Sat, Aug 25, 2018 at 10:22:40PM +0300, Rami Rosen wrote:
> This patch removes an unnecessary definition of MAX_PRINT_BUFF 
> in examples/vhost/main.c, since it is no longer being used.
> 
> Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  examples/vhost/main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 2175c1186..5d28d03f6 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -58,9 +58,6 @@
>  /* Max number of devices. Limited by vmdq. */
>  #define MAX_DEVICES 64
>  
> -/* Size of buffers used for snprintfs. */
> -#define MAX_PRINT_BUFF 6072
> -
>  /* Maximum long option length for option parsing. */
>  #define MAX_LONG_OPT_SZ 64
>  
> -- 
> 2.17.1
>
Maxime Coquelin Sept. 10, 2018, 1:30 p.m. | #2
On 08/25/2018 09:22 PM, Rami Rosen wrote:
> This patch removes an unnecessary definition of MAX_PRINT_BUFF
> in examples/vhost/main.c, since it is no longer being used.
> 
> Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   examples/vhost/main.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 2175c1186..5d28d03f6 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -58,9 +58,6 @@
>   /* Max number of devices. Limited by vmdq. */
>   #define MAX_DEVICES 64
>   
> -/* Size of buffers used for snprintfs. */
> -#define MAX_PRINT_BUFF 6072
> -
>   /* Maximum long option length for option parsing. */
>   #define MAX_LONG_OPT_SZ 64
>   
> 

Applied to dpdk-next-virtio/master, with changing the title to
pass check-git-log.sh script.

Thanks,
Maxime

Patch

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 2175c1186..5d28d03f6 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -58,9 +58,6 @@ 
 /* Max number of devices. Limited by vmdq. */
 #define MAX_DEVICES 64
 
-/* Size of buffers used for snprintfs. */
-#define MAX_PRINT_BUFF 6072
-
 /* Maximum long option length for option parsing. */
 #define MAX_LONG_OPT_SZ 64