net/ixgbe: fix ixgbevf link status
Checks
Commit Message
For ixgbevf kernel driver, link status changes from down to up
will trigger vf kernel driver send IXGBE_VF_RESET message to pf
kernel driver, after this, vf kernel driver will disable and enable
it self. By these series operations, the vf kernel driver report
link up. Besides, all these operations handles in kernel thread.
For DPDK user space driver, it only gets link status changes from
down to up, but miss IXGBE_VF_RESET message sending and reset itself.
If we will add fully implementation of link status change for DPDK
user space driver, we need take much more modification. We have
aligned that for link status changes from down to up we only notify
link is up, users need to reset vf port.
Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
Comments
Hi Yanglong:
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Friday, August 10, 2018 4:10 PM
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Wang, Dong1 <dong1.wang@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH] net/ixgbe: fix ixgbevf link status
>
> For ixgbevf kernel driver, link status changes from down to up will trigger vf
> kernel driver send IXGBE_VF_RESET message to pf kernel driver, after this, vf
> kernel driver will disable and enable it self. By these series operations, the vf
> kernel driver report link up. Besides, all these operations handles in kernel
> thread.
> For DPDK user space driver, it only gets link status changes from down to up,
> but miss IXGBE_VF_RESET message sending and reset itself.
> If we will add fully implementation of link status change for DPDK user space
> driver, we need take much more modification. We have aligned that for link
> status changes from down to up we only notify link is up, users need to reset
> vf port.
OK, the commit log described the gap between kernel driver and DPDK driver, and the workaround which require proper change in application.
But what is the problem the patch is going to fix?, what's the relationship between the fix and commit log, I can't figure out.
Basically the patch remove the no_pflink_check branch, so it will always check with PF for the link status. I guess this help to guarantee that application can always get correct link status, but why we need that commit log here? would you explain more?
>
> Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 26b192737..4d5f4441b 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3865,13 +3865,12 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
>
> static int
> ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
> - int *link_up, int wait_to_complete)
> + int *link_up, __attribute__((unused)) int wait_to_complete)
I think we can just remove "wait_to_complete", right?
> {
> /**
> * for a quick link status checking, wait_to_compelet == 0,
> * skip PF link status checking
> */
> - bool no_pflink_check = wait_to_complete == 0;
> struct ixgbe_mbx_info *mbx = &hw->mbx;
> struct ixgbe_mac_info *mac = &hw->mac;
> uint32_t links_reg, in_msg;
> @@ -3931,15 +3930,6 @@ ixgbevf_check_link(struct ixgbe_hw *hw,
> ixgbe_link_speed *speed,
> default:
> *speed = IXGBE_LINK_SPEED_UNKNOWN;
> }
> -
> - if (no_pflink_check) {
> - if (*speed == IXGBE_LINK_SPEED_UNKNOWN)
> - mac->get_link_status = true;
> - else
> - mac->get_link_status = false;
> -
> - goto out;
> - }
> /* if the read failed it could just be a mailbox collision, best wait
> * until we are called again and don't report an error
> */
> @@ -3949,7 +3939,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw,
> ixgbe_link_speed *speed,
> if (!(in_msg & IXGBE_VT_MSGTYPE_CTS)) {
> /* msg is not CTS and is NACK we must have lost CTS status */
> if (in_msg & IXGBE_VT_MSGTYPE_NACK)
> - ret_val = -1;
> + mac->get_link_status = false;
> goto out;
> }
>
> --
> 2.11.0
Hi, qi:
This patch we are going to fix the problem H3C: 82599 Niantic VF can't get correct link status when use cable :https://jira01.devtools.intel.com/browse/DPDK-5543?filter=-3
The commit log describe about the gap between kernel and dpdk and why we design this workaround to get right link status.
Regard
Yanglong wu
-----Original Message-----
From: Zhang, Qi Z
Sent: Thursday, September 6, 2018 1:34 PM
To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
Cc: Xu, Rosen <rosen.xu@intel.com>; Wang, Dong1 <dong1.wang@intel.com>
Subject: RE: [PATCH] net/ixgbe: fix ixgbevf link status
Hi Yanglong:
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Friday, August 10, 2018 4:10 PM
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Wang, Dong1
> <dong1.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu,
> Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH] net/ixgbe: fix ixgbevf link status
>
> For ixgbevf kernel driver, link status changes from down to up will
> trigger vf kernel driver send IXGBE_VF_RESET message to pf kernel
> driver, after this, vf kernel driver will disable and enable it self.
> By these series operations, the vf kernel driver report link up.
> Besides, all these operations handles in kernel thread.
> For DPDK user space driver, it only gets link status changes from down
> to up, but miss IXGBE_VF_RESET message sending and reset itself.
> If we will add fully implementation of link status change for DPDK
> user space driver, we need take much more modification. We have
> aligned that for link status changes from down to up we only notify
> link is up, users need to reset vf port.
OK, the commit log described the gap between kernel driver and DPDK driver, and the workaround which require proper change in application.
But what is the problem the patch is going to fix?, what's the relationship between the fix and commit log, I can't figure out.
Basically the patch remove the no_pflink_check branch, so it will always check with PF for the link status. I guess this help to guarantee that application can always get correct link status, but why we need that commit log here? would you explain more?
>
> Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 26b192737..4d5f4441b 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3865,13 +3865,12 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
>
> static int
> ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
> - int *link_up, int wait_to_complete)
> + int *link_up, __attribute__((unused)) int wait_to_complete)
I think we can just remove "wait_to_complete", right?
> {
> /**
> * for a quick link status checking, wait_to_compelet == 0,
> * skip PF link status checking
> */
> - bool no_pflink_check = wait_to_complete == 0;
> struct ixgbe_mbx_info *mbx = &hw->mbx;
> struct ixgbe_mac_info *mac = &hw->mac;
> uint32_t links_reg, in_msg;
> @@ -3931,15 +3930,6 @@ ixgbevf_check_link(struct ixgbe_hw *hw,
> ixgbe_link_speed *speed,
> default:
> *speed = IXGBE_LINK_SPEED_UNKNOWN;
> }
> -
> - if (no_pflink_check) {
> - if (*speed == IXGBE_LINK_SPEED_UNKNOWN)
> - mac->get_link_status = true;
> - else
> - mac->get_link_status = false;
> -
> - goto out;
> - }
> /* if the read failed it could just be a mailbox collision, best wait
> * until we are called again and don't report an error
> */
> @@ -3949,7 +3939,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw,
> ixgbe_link_speed *speed,
> if (!(in_msg & IXGBE_VT_MSGTYPE_CTS)) {
> /* msg is not CTS and is NACK we must have lost CTS status */
> if (in_msg & IXGBE_VT_MSGTYPE_NACK)
> - ret_val = -1;
> + mac->get_link_status = false;
> goto out;
> }
>
> --
> 2.11.0
@@ -3865,13 +3865,12 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
static int
ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
- int *link_up, int wait_to_complete)
+ int *link_up, __attribute__((unused)) int wait_to_complete)
{
/**
* for a quick link status checking, wait_to_compelet == 0,
* skip PF link status checking
*/
- bool no_pflink_check = wait_to_complete == 0;
struct ixgbe_mbx_info *mbx = &hw->mbx;
struct ixgbe_mac_info *mac = &hw->mac;
uint32_t links_reg, in_msg;
@@ -3931,15 +3930,6 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
default:
*speed = IXGBE_LINK_SPEED_UNKNOWN;
}
-
- if (no_pflink_check) {
- if (*speed == IXGBE_LINK_SPEED_UNKNOWN)
- mac->get_link_status = true;
- else
- mac->get_link_status = false;
-
- goto out;
- }
/* if the read failed it could just be a mailbox collision, best wait
* until we are called again and don't report an error
*/
@@ -3949,7 +3939,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
if (!(in_msg & IXGBE_VT_MSGTYPE_CTS)) {
/* msg is not CTS and is NACK we must have lost CTS status */
if (in_msg & IXGBE_VT_MSGTYPE_NACK)
- ret_val = -1;
+ mac->get_link_status = false;
goto out;
}