doc: fix PDF build

Message ID 20180808212509.8302-1-thomas@monjalon.net
State Accepted, archived
Headers show
Series
  • doc: fix PDF build
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon Aug. 8, 2018, 9:25 p.m.
The SVG images must be referenced without their extension,
because it is converted to PNG for PDF.

Fixes: 54c4cbb6ccf1 ("doc: add graphics to bbdev guide")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/prog_guide/bbdev.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mokhtar, Amr Aug. 8, 2018, 9:29 p.m. | #1
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday 8 August 2018 22:25
> To: Mokhtar, Amr <amr.mokhtar@intel.com>
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Kovacevic,
> Marko <marko.kovacevic@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; dev@dpdk.org
> Subject: [PATCH] doc: fix PDF build
> 
> The SVG images must be referenced without their extension,
> because it is converted to PNG for PDF.
> 
> Fixes: 54c4cbb6ccf1 ("doc: add graphics to bbdev guide")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>

Thanks!
Thomas Monjalon Aug. 8, 2018, 10:03 p.m. | #2
> > The SVG images must be referenced without their extension,
> > because it is converted to PNG for PDF.
> > 
> > Fixes: 54c4cbb6ccf1 ("doc: add graphics to bbdev guide")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> 
> Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>
> 
> Thanks!

Applied

Patch

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index 426d31f09..9de14443e 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -571,7 +571,7 @@  TB-mode. CB-mode is a reduced version, where only one CB exists:
 
 .. _figure_turbo_tb_encode:
 
-.. figure:: img/turbo_tb_encode.svg
+.. figure:: img/turbo_tb_encode.*
 
     Turbo encoding of Code Blocks in mbuf structure
 
@@ -665,7 +665,7 @@  TB-mode. CB-mode is a reduced version, where only one CB exists:
 
 .. _figure_turbo_tb_decode:
 
-.. figure:: img/turbo_tb_decode.svg
+.. figure:: img/turbo_tb_decode.*
 
     Turbo decoding of Code Blocks in mbuf structure