[v3,2/2] eal: remove experimental tag from user mbuf pool ops func

Message ID 20180807213443.24847-2-zer0@droids-corp.org
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [v3,1/2] eal: remove deprecated function returning mbuf pool ops name
Related show

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Olivier Matz Aug. 7, 2018, 9:34 p.m.
From: Olivier Matz <olivier.matz@6wind.com>

Remove experimental tag from rte_eal_mbuf_user_pool_ops().

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---

v3:
* nothing
v2:
* remove rte_eal_mbuf_user_pool_ops from .map in this patch instead of previous one

 lib/librte_eal/bsdapp/eal/eal.c         | 2 +-
 lib/librte_eal/common/include/rte_eal.h | 5 +----
 lib/librte_eal/linuxapp/eal/eal.c       | 2 +-
 lib/librte_eal/rte_eal_version.map      | 7 ++++++-
 lib/librte_mbuf/Makefile                | 1 -
 lib/librte_mbuf/meson.build             | 1 -
 6 files changed, 9 insertions(+), 9 deletions(-)

Comments

Hemant Agrawal Aug. 8, 2018, 11:40 a.m. | #1
On 8/8/2018 3:04 AM, Olivier Matz wrote:
> From: Olivier Matz <olivier.matz@6wind.com>
>
> Remove experimental tag from rte_eal_mbuf_user_pool_ops().
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
   Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Thomas Monjalon Aug. 8, 2018, 10:46 p.m. | #2
07/08/2018 23:34, Olivier Matz:
> From: Olivier Matz <olivier.matz@6wind.com>
> 
> Remove experimental tag from rte_eal_mbuf_user_pool_ops().
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -261,6 +261,12 @@ DPDK_18.08 {
>  
>  } DPDK_18.05;
>  
> +DPDK_18.08 {
> +	global:
> +
> +	rte_eal_mbuf_user_pool_ops;
> +} DPDK_18.05;
> +

There is already a section DPDK_18.08 so I moved the function there.

Series applied with above fix, thanks

Patch

diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 89e8110a2..d7ae9d686 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -147,7 +147,7 @@  eal_get_runtime_dir(void)
 }
 
 /* Return user provided mbuf pool ops name */
-const char * __rte_experimental
+const char *
 rte_eal_mbuf_user_pool_ops(void)
 {
 	return internal_config.user_mbuf_pool_ops_name;
diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h
index 0c9c3f13b..e114dcbdc 100644
--- a/lib/librte_eal/common/include/rte_eal.h
+++ b/lib/librte_eal/common/include/rte_eal.h
@@ -490,15 +490,12 @@  static inline int rte_gettid(void)
 enum rte_iova_mode rte_eal_iova_mode(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get user provided pool ops name for mbuf
  *
  * @return
  *   returns user provided pool ops name.
  */
-const char * __rte_experimental
+const char *
 rte_eal_mbuf_user_pool_ops(void);
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 511eb062f..e59ac6577 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -155,7 +155,7 @@  eal_get_runtime_dir(void)
 }
 
 /* Return user provided mbuf pool ops name */
-const char * __rte_experimental
+const char *
 rte_eal_mbuf_user_pool_ops(void)
 {
 	return internal_config.user_mbuf_pool_ops_name;
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index de9abc812..67a89e6a6 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -261,6 +261,12 @@  DPDK_18.08 {
 
 } DPDK_18.05;
 
+DPDK_18.08 {
+	global:
+
+	rte_eal_mbuf_user_pool_ops;
+} DPDK_18.05;
+
 EXPERIMENTAL {
 	global:
 
@@ -286,7 +292,6 @@  EXPERIMENTAL {
 	rte_eal_cleanup;
 	rte_eal_hotplug_add;
 	rte_eal_hotplug_remove;
-	rte_eal_mbuf_user_pool_ops;
 	rte_fbarray_attach;
 	rte_fbarray_destroy;
 	rte_fbarray_detach;
diff --git a/lib/librte_mbuf/Makefile b/lib/librte_mbuf/Makefile
index 8749a00fe..e2b98a254 100644
--- a/lib/librte_mbuf/Makefile
+++ b/lib/librte_mbuf/Makefile
@@ -6,7 +6,6 @@  include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_mbuf.a
 
-CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
 LDLIBS += -lrte_eal -lrte_mempool
 
diff --git a/lib/librte_mbuf/meson.build b/lib/librte_mbuf/meson.build
index 869c17c1c..45ffb0db5 100644
--- a/lib/librte_mbuf/meson.build
+++ b/lib/librte_mbuf/meson.build
@@ -2,7 +2,6 @@ 
 # Copyright(c) 2017 Intel Corporation
 
 version = 3
-allow_experimental_apis = true
 sources = files('rte_mbuf.c', 'rte_mbuf_ptype.c', 'rte_mbuf_pool_ops.c')
 headers = files('rte_mbuf.h', 'rte_mbuf_ptype.h', 'rte_mbuf_pool_ops.h')
 deps += ['mempool']