net/mlx5: fix VLAN POP action on switch flow rules

Message ID 20180802101928.15510-1-adrien.mazarguil@6wind.com
State Accepted, archived
Delegated to: Shahaf Shuler
Headers show
Series
  • net/mlx5: fix VLAN POP action on switch flow rules
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Adrien Mazarguil Aug. 2, 2018, 10:20 a.m.
TC message for VLAN POP is broken due to an unfinished nested attribute.

Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow rules")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5_nl_flow.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shahaf Shuler Aug. 2, 2018, 12:48 p.m. | #1
Thursday, August 2, 2018 1:21 PM, Adrien Mazarguil:
> Subject: [PATCH] net/mlx5: fix VLAN POP action on switch flow rules
> 
> TC message for VLAN POP is broken due to an unfinished nested attribute.
> 
> Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow
> rules")
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to next-net-mlx, thanks.

Patch

diff --git a/drivers/net/mlx5/mlx5_nl_flow.c b/drivers/net/mlx5/mlx5_nl_flow.c
index 8803ffc32..a1c8c340b 100644
--- a/drivers/net/mlx5/mlx5_nl_flow.c
+++ b/drivers/net/mlx5/mlx5_nl_flow.c
@@ -991,6 +991,7 @@  mlx5_nl_flow_transpose(void *buf,
 			goto error_nobufs;
 		if (i == TCA_VLAN_ACT_POP) {
 			mnl_attr_nest_end(buf, act);
+			mnl_attr_nest_end(buf, act_index);
 			++action;
 			break;
 		}