From patchwork Wed Aug 1 18:19:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 43510 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EF5D1B39C; Wed, 1 Aug 2018 20:30:13 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0054.outbound.protection.outlook.com [104.47.37.54]) by dpdk.org (Postfix) with ESMTP id 206FB1B39A; Wed, 1 Aug 2018 20:30:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0jVHjMqR81HfRV7/+e/MboITfY+/CUF+B0v4SWh2/mI=; b=IkWU28IWKUVAeWGkFjz48ZV6bXEuSfQTTgP4zXk8stVlVGHuaSK0rBz2CEdtT2+lU6PtKoCgCLJL6PGiKNcBz7h/ZSj1u+UhMAzMHUPom/kN612A/pRcXf02vnEOJPnLIqiplShM1j9oyFAhd0jbKyEuesiVH8IklFTaypkdIxY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.5) by BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.4; Wed, 1 Aug 2018 18:19:41 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Wed, 1 Aug 2018 11:19:20 -0700 Message-Id: <1533147560-10897-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 X-Originating-IP: [198.186.1.5] X-ClientProxiedBy: CO2PR06CA0063.namprd06.prod.outlook.com (2603:10b6:104:3::21) To BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b83a7c2-6e96-4eb0-0a35-08d5f7db59ec X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5365; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 3:zov4W1viSyTQ6cfSzYNf1HzlQi6VWJVxLnqMLkmgx6yUmrRvHqQm/9KWHK3tVTclyKriHoQZOGYiSWKABEbM20q7D7pYVqzaql9sVW9BfEDcjJ3SRx6ovZP9ZXVygmBeBNEcvgDQBX8quBGlzyTfcFJi0lvDnZM2Ia1CcHzCP78Bs4jZptSqkM9y789EVILy295ppOEAhsSTHbGQTpS/MKVuVF2Zc3+fgvjfOZCGYU1PiLSvO8MVidISHF6q37nN; 25:rh1JICX0tuy4J9DOvNliKkdx8o/Jml12KG6XqvBq0NGzWeA+UkU+Y3AozhEP0T4hGVl+14StJT6Y81lX3/9yQV3S9eujirtAqt8MnuR/BsSSDqfV4p+8Wluz8uUHKXRKJWqwHl3qibKPPMQ84rmee7eRpPBNwSG2bQk7XG3q1C4wp0D1GEUQ/tUyikoWZIIP2eVCh9oy7O0cIAZO5PIj10A3fSy+pqdbw5WW1c2PJVTYBWcodQS6DfY23VOmNXbWyNYoV6PNgVcmm+zQYTv8y/XOqSNLNw/sh/VevDgJZQh3ru7P9d0rc7av6wM5BfQC3lI1EaMk8q3U+Aw4J2QiGg==; 31:aVOhuLD+yThuuW5Wr9I+4aZA4/nANVTK7UvPgO4h/w2b/dPf6PHqHocQ5vcZtiK3bfck+rBLwMZzsgyJ/LymOPHrh8rNFbB6pyFrR2Zy3E9LM31FD/IChWIbkNlIjDrvi+439056T187Z1NfMsAG31fT/0p6aH809I6ZMjmL8EDAbpFmWWh4dZ2ZEShtkZiwQP0qurEeW2Fwun39Ud3MEY4Ir1H6m3Aa14YrgbtSnlo= X-MS-TrafficTypeDiagnostic: BYAPR07MB5365: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 20:GNCmYRagIq61yQBWcAggSRwSsy7SgzFFQc6Qwx/uj/mZlBrcxa9qy3zy/Y1yRMqqWfKgoJ+QFb3fLm7BtjXkwdj6lls4rMntpV4b97quCUA6n80k5690R4E4Eq8KPucoiC9IRqVJaIaTt2xkKNEMlSq84GGLYq7IuZPsc3YMK8cX/YrFHYPeft5Sl1BuZ/tbl+Nz9CPpLbTfDAjOpaScaS4U94brL8FNh7XE0uZBQxn+xHNHipS5pC+Ko4daoTPAY7+Ppa01/ZYkescEyjwnpjinHa89wNWZEfPONG9/w8A2Vmg0wiSLCUHwW853reowst9DfJMw5Xuu341ulSrHdsB0OTMjz/zZWj3plmIIhPOnYSsyRARTCy45ZXO7yKMBZ5v+Prv/+7IXz/ZL5nRf1A6rzhNrZeUTIf6o6xlGZ3LjqvrIGjItyMnVmUfATXTPlB8TIJQZUjYzrO0BrtQ1MiRB7Dwr30Ui4x4IUmbKOhIE/3GYrPcS35iTzQ8ZmtDn; 4:/Mozdi7vUQz5IS/6tz+TYqvakuu0apyruPtXeT+7/EamvRlNf07ZmE2EKXbOPQ9HbOCLmDdCNNznoWT4FuY7zcdaL6WMwIq2mMsN6tPz5A4gItiyHabwvOzUDXKypyMM+HRicriO2oJdhbAKj7I9FQM8yzWigEgq5r8uRcbIxvdnY7Z+g3PJb6AhyRQtHK9opU9sxzaaR2g77xtPqA0KuA4uuhMz9yVtWVoQBYbl2rTlm7UK1p3m4GM7gJP8bWBwiRT0TfkV/T4aPc32yBuyfQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BYAPR07MB5365; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5365; X-Forefront-PRVS: 0751474A44 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(136003)(39850400004)(346002)(376002)(189003)(199004)(16586007)(8676002)(81156014)(47776003)(386003)(476003)(1857600001)(2361001)(21086003)(81166006)(956004)(316002)(69596002)(26005)(25786009)(4720700003)(53936002)(14444005)(55016002)(3846002)(478600001)(72206003)(305945005)(2616005)(6666003)(2906002)(97736004)(66066001)(6116002)(7736002)(2351001)(8936002)(5660300001)(44832011)(105586002)(186003)(486006)(50226002)(36756003)(68736007)(106356001)(48376002)(52116002)(4326008)(51416003)(6916009)(86362001)(16526019)(7696005)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5365; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB5365; 23:Af+x+n80JaUqpG+UhPrh9GPemvk4awtTNzLXvx0l6?= JhYW2U+J/S/NF//+kZSb4Lp26wlbyhPZ9UFth4CnMiwZJsgSIV/mNEkA9lwgMYKz93ebcdALUuE/L6OT2DHscnbQsjxSGb0BbKF8Yu50MFTWdW9b66jF0ADaN0WWowWSrVa0yWRZXlqNp3cZZz8QNFLrCbak0neL5DHWyLLuAMIta61MDHIjZy8uBuzTK0cBMNGzt4ae5aLGd4nbIY6qySd+u2ix+VdujdYqqu8fntmoBV+R43LOH4WIruLbFRom7l+ynFWf3lo3B0d1Qr3ccj6oUp8wkLc8gfpAyUKMIuWRfxyHbCYjDNthsMD0DbJodfmhjgd3kM2Voj3jLsQ0dODthQxIAFXI3w9/LGzBLlGHrj6y1CfBRH5knKxo3fFqcBtAFpQwUr92hTML2jAUv9L9X/b4F2dU0+8DZ9cTigyEmsGiXxql4dlrDNKHCC66zCJE6KRIGsbc7VxrwVY/F3i0nOHzeA76phzEQj3ukZuyV5N8ArBby6fahbztrziAgpxrKYqnJ38848i/Ggk/NzP3txlxhrfr9O+lLDf69z5PgEpjx4HOtOW3cMTalKUvSFR4tV07FVccGi6VEJNKSyGF8XaOGCpNTEuG59/fRR7A6lh6Acua5/RwVTZay0mf2O2xVk0s8wrXwDYTvcyIdUcmhk6Sm8AfsHw2x0B4j3+G+s6C12cVuz3WvOHI5JGbBtH1Zy6nr+vCmjCjoYPxLe0snYCIwwOVQ9cOZke8cEGnAvH+lN3lQWlEesg1ZaSlEln9xd1leBV2PJxcV91u45Z2GnT+ZhZw48t29UBYMDtg9wLVa0OMtkGMu4Psmw1iArDwbJ00OUwwCBmWXqPNz+vnR+lCazbfWxEweU8TnnHJUsp4CdinFmJfLmz3aYdnzCE/xVgDRbTfcafKfj9JyR1cvl1TxTkrkImFXqr7J0wKTN7VZslxg5GtGMgF9AnSLETnLpCOS/fYY4tdwRoILNEIO0qLwm0WqeBDL6P3A1QttutW01jAirJa/9s3+ZOCzz0qoiumuLs5mTiaxiAKMRILwMsrbQTkMubq+0FNZIkMGXTj05NBLqHOZ+8bmlpCuogY6xhDWYiMfU9Rb+wMt7rYbdomkoNDluIhqYKiaJuKR7/MEOWgRnvQjbrTKC7Cy/omVqU+OLN8nLrS5QaJRxxH1MLm9XfmV0K6KW2pHix8UCodSQBn0KBHsEb9gimaWUIDTu9QdEMu4oQf9hazuJrMoKLMqIPRNVjXrGvPNGAlg== X-Microsoft-Antispam-Message-Info: uZLxgab/VDHlS5N0aJS/9AhKWoSOqidYj0+2sQtxsfTiSlKTPGWjAXRDXR/LEOv2cb/2Vip4eGoQAbq/l/phXgfHgHXhdENNhv//zXkyiWofAMYjFTQSlnpuXgrxKQERGQSKhFIKedy8AKxpE/A+eHg4iJjh2cjr4WOHInXpzHwd9wfMB25QHiitoC2Z46Dlt8mwgTyweOVWYM9miZfQDwZWUn2Rv4rKL8di5kgn/EIgcBeoXvIKcbiDWWChv9/Tl8U5daVZ2EoT3tF4/1Jsd7y61unK+9WlJARBIugUOozhJqbEFwC0ztZh4mvDl6HYNVrWnga7UWm2mTm665+eVBYLuapSpWkWSHAhx6UWFDk= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5365; 6:Z5ltW5v94go+URTm27S96MZ0eogD/7wAa9pbXE1oPs/94V3jKap8u7PkmCVHQZFXM8Mi04gMnwhqcboXGbpuETd4Sc2ilAl5xgT8lk3mNy7ZPsgiOmHM02zZdFQw48WttaZXZK7yvcXHbHafKuOrwwZZq6lv+kqMC1u23giri6bOgLyHVVyEOZ/vwFa5uUKDt6zCkcRx5UDQtWxP37ViDZiiW4OfRN0VC43+Ce4B+x9Wzq0c1HDB4zYD0eftUkNeXhalUNj35onYaNmQ3Sn+MyntSo00fw3uKTy0pe5ERUMZo5qKuTSRVFU/lOH3QDxcuTmESsrpRUbCOV/sBV0RXOVI+L+xa4uNSdtQzeFvT9therHVZx7/1yJKCd5Q6YX8UKkkzKpL0L6NnKVHCIwoDYCo/O+VNY4NuGPo3Kec1/wMSH3Pz0Uopke0Tn4PkD8wKpmE5jgQFNhFgsi66VxeRg==; 5:8PHfvGqIC5ukDAnq8M154+wRfeMXwEmdSyYYhVFm2ikzfCcxbmii5FtTwBZdkkRPevGHJ1PQHc3zWGlb9r99QdkOd20Nm2pL7zJq1sZGi3yzp4tVj320MgUgdAfr4qHgMjROSAd4YCdUQCHwr3AW3WlQa3LWSUmV9RbeFx6x6FE=; 7:3J7+kSyHQuNaV95/Awte7OSpbfz5704U0xWhoqHavYKVnGHICH60URHUpbt+CL0epLloXlHQCNEdYhvbQ5fKQN9SN8/Sr7B31du/nV2W/5Bdksk/+R9jTHlYXzu+C98x+bvNsG6bDL4tDd8PR5pwiuck9nHX9burGd1yAzL2i0I2+gz90Jxmo6TKjtKaOnnWQQ2ZW6tLXUYYVcftyF0pmxHocE0WHaxvIGKbSkdznTLtw5aKh1R/hA80O6jthUOa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2018 18:19:41.7426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b83a7c2-6e96-4eb0-0a35-08d5f7db59ec X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5365 Subject: [dpdk-dev] [PATCH] net/bnx2x: fix FW cmd timeout duting device stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes firmware command timeout error seen during device stop while stopping queues. It patially reverts an earlier preventive change commit 91b7e432bcef ("net/bnx2x: disable fast path interrupts") to now enable fast path interrupts. The original issue of performance degradation is not observed anymore, with or without the fix. Fixes: 91b7e432bcef ("net/bnx2x: disable fast path interrupts") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 84ade5f..6228744 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -4490,6 +4490,8 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp) struct bnx2x_softc *sc = fp->sc; uint8_t more_rx = FALSE; + PMD_DRV_LOG(DEBUG, "---> FP TASK QUEUE (%d) <--", fp->index); + /* update the fastpath index */ bnx2x_update_fp_sb_idx(fp); @@ -4506,7 +4508,7 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp) } bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID, - le16toh(fp->fp_hc_idx), IGU_INT_DISABLE, 1); + le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1); } /*