test: fix ethdev config offloads in bond unit test

Message ID 1533125958-18263-1-git-send-email-reshma.pattan@intel.com
State Accepted, archived
Headers show
Series
  • test: fix ethdev config offloads in bond unit test
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Reshma Pattan Aug. 1, 2018, 12:19 p.m.
From: Reshma Pattan <reshma.pattan@intel.com>

Link bonding unit tests uses net_null vdev as slaves,
and trying to configure DEV_RX_OFFLOAD_CRC_STRIP as offload
flags to vdev is not correct as vdev doesn't support offloads.

The unit test is reporting this as failure, so fix this by
removing the offloads.

Fixes: c6698a3e8f ("ethdev: convert remaining apps to new offload API")

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 test/test/test_link_bonding_rssconf.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Monjalon Aug. 1, 2018, 2:16 p.m. | #1
01/08/2018 14:19, Reshma Pattan:
> From: Reshma Pattan <reshma.pattan@intel.com>
> 
> Link bonding unit tests uses net_null vdev as slaves,
> and trying to configure DEV_RX_OFFLOAD_CRC_STRIP as offload
> flags to vdev is not correct as vdev doesn't support offloads.
> 
> The unit test is reporting this as failure, so fix this by
> removing the offloads.
> 
> Fixes: c6698a3e8f ("ethdev: convert remaining apps to new offload API")
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>

Applied, thanks
Wu, ChangqingX Aug. 3, 2018, 1:44 a.m. | #2
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
Sent: Wednesday, August 1, 2018 8:19 PM
To: dev@dpdk.org; Nicolau, Radu; Doherty, Declan
Cc: Pattan, Reshma
Subject: [dpdk-dev] [PATCH] test: fix ethdev config offloads in bond unit test

From: Reshma Pattan <reshma.pattan@intel.com>

Link bonding unit tests uses net_null vdev as slaves, and trying to configure DEV_RX_OFFLOAD_CRC_STRIP as offload flags to vdev is not correct as vdev doesn't support offloads.

The unit test is reporting this as failure, so fix this by removing the offloads.

Fixes: c6698a3e8f ("ethdev: convert remaining apps to new offload API")

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Tested-by: Wu,ChangqingX <changqingx.wu@intel.com>

Patch

diff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c
index e6e798f5b..d82de2cef 100644
--- a/test/test/test_link_bonding_rssconf.c
+++ b/test/test/test_link_bonding_rssconf.c
@@ -83,7 +83,6 @@  static struct rte_eth_conf default_pmd_conf = {
 		.mq_mode = ETH_MQ_RX_NONE,
 		.max_rx_pkt_len = ETHER_MAX_LEN,
 		.split_hdr_size = 0,
-		.offloads = DEV_RX_OFFLOAD_CRC_STRIP,
 	},
 	.txmode = {
 		.mq_mode = ETH_MQ_TX_NONE,
@@ -96,7 +95,6 @@  static struct rte_eth_conf rss_pmd_conf = {
 		.mq_mode = ETH_MQ_RX_RSS,
 		.max_rx_pkt_len = ETHER_MAX_LEN,
 		.split_hdr_size = 0,
-		.offloads = DEV_RX_OFFLOAD_CRC_STRIP,
 	},
 	.txmode = {
 		.mq_mode = ETH_MQ_TX_NONE,