diff mbox series

app/eventdev: fix order test service init

Message ID 20180713085114.25356-1-pbhagavatula@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series app/eventdev: fix order test service init |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Pavan Nikhilesh July 13, 2018, 8:51 a.m. UTC 
  Previous modification to evt_service_setup() broke order_queue/atq
tests.

Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
Cc: stable@dpdk.org

Reported-by: Gage Eads <gage.eads@intel.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 app/test-eventdev/test_order_atq.c   | 12 ++++++++----
 app/test-eventdev/test_order_queue.c | 12 ++++++++----
 2 files changed, 16 insertions(+), 8 deletions(-)

--
2.18.0

Comments

Eads, Gage July 13, 2018, 5:52 p.m. UTC | #1 
> -----Original Message-----
> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Friday, July 13, 2018 3:51 AM
> To: jerin.jacob@caviumnetworks.com; Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Pavan Nikhilesh
> <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> 
> Previous modification to evt_service_setup() broke order_queue/atq tests.
> 
> Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
> Cc: stable@dpdk.org
> 
> Reported-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---

Acked-by: Gage Eads <gage.eads@intel.com>

Thanks for the quick turnaround,
Gage
Jerin Jacob July 24, 2018, 3:36 p.m. UTC | #2 
-----Original Message-----
> Date: Fri, 13 Jul 2018 17:52:42 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
>  "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> 
> External Email
> 
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Friday, July 13, 2018 3:51 AM
> > To: jerin.jacob@caviumnetworks.com; Eads, Gage <gage.eads@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Pavan Nikhilesh
> > <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> >
> > Previous modification to evt_service_setup() broke order_queue/atq tests.
> >
> > Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Gage Eads <gage.eads@intel.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> 
> Acked-by: Gage Eads <gage.eads@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

>
Jerin Jacob July 25, 2018, 1:33 p.m. UTC | #3 
-----Original Message-----
> Date: Fri, 13 Jul 2018 17:52:42 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
>  "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> 
> External Email
> 
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Friday, July 13, 2018 3:51 AM
> > To: jerin.jacob@caviumnetworks.com; Eads, Gage <gage.eads@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Pavan Nikhilesh
> > <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> >
> > Previous modification to evt_service_setup() broke order_queue/atq tests.
> >
> > Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Gage Eads <gage.eads@intel.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> 
> Acked-by: Gage Eads <gage.eads@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.

> 
> Thanks for the quick turnaround,
> Gage
diff mbox series

Patch

diff --git a/app/test-eventdev/test_order_atq.c b/app/test-eventdev/test_order_atq.c
index c57fbbfa6..35debcfdc 100644
--- a/app/test-eventdev/test_order_atq.c
+++ b/app/test-eventdev/test_order_atq.c
@@ -151,10 +151,14 @@  order_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt)
 	if (ret)
 		return ret;

-	ret = evt_service_setup(opt->dev_id);
-	if (ret) {
-		evt_err("No service lcore found to run event dev.");
-		return ret;
+	if (!evt_has_distributed_sched(opt->dev_id)) {
+		uint32_t service_id;
+		rte_event_dev_service_id_get(opt->dev_id, &service_id);
+		ret = evt_service_setup(service_id);
+		if (ret) {
+			evt_err("No service lcore found to run event dev.");
+			return ret;
+		}
 	}

 	ret = rte_event_dev_start(opt->dev_id);
diff --git a/app/test-eventdev/test_order_queue.c b/app/test-eventdev/test_order_queue.c
index f603a0230..17f7b9845 100644
--- a/app/test-eventdev/test_order_queue.c
+++ b/app/test-eventdev/test_order_queue.c
@@ -164,10 +164,14 @@  order_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt)
 	if (ret)
 		return ret;

-	ret = evt_service_setup(opt->dev_id);
-	if (ret) {
-		evt_err("No service lcore found to run event dev.");
-		return ret;
+	if (!evt_has_distributed_sched(opt->dev_id)) {
+		uint32_t service_id;
+		rte_event_dev_service_id_get(opt->dev_id, &service_id);
+		ret = evt_service_setup(service_id);
+		if (ret) {
+			evt_err("No service lcore found to run event dev.");
+			return ret;
+		}
 	}

 	ret = rte_event_dev_start(opt->dev_id);