From patchwork Fri Jun 29 17:27:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Hu X-Patchwork-Id: 41986 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B62FC1B8C9; Fri, 29 Jun 2018 19:28:08 +0200 (CEST) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 08D751B69B; Fri, 29 Jun 2018 19:27:58 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70D6F1529; Fri, 29 Jun 2018 10:27:57 -0700 (PDT) Received: from net-debian.shanghai.arm.com (net-debian.shanghai.arm.com [10.169.36.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B42393F5AD; Fri, 29 Jun 2018 10:27:56 -0700 (PDT) From: Gavin Hu To: dev@dpdk.org Cc: nd@arm.com, gavin.hu@arm.com, stable@dpdk.org Date: Sat, 30 Jun 2018 01:27:38 +0800 Message-Id: <20180629172738.2121-7-gavin.hu@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180629172738.2121-1-gavin.hu@arm.com> References: <20180625024913.17219-1-gavin.hu@arm.com> <20180629172738.2121-1-gavin.hu@arm.com> Subject: [dpdk-dev] [PATCH v14 6/6] devtools: expand meson cross compiling test coverage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The default test script covers only default host cc compiler, either gcc or clang, the fix is to increase the coverage by adding one more to cover clang and the others for gcc. Fixes: a55277a788 ("devtools: add test script for meson builds") Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Phil Yang Reviewed-by: Song Zhu Acked-by: Bruce Richardson --- devtools/test-meson-builds.sh | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 9bb5b93bd..f38304e6e 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -15,7 +15,7 @@ if command -v ninja >/dev/null 2>&1 ; then elif command -v ninja-build >/dev/null 2>&1 ; then ninja_cmd=ninja-build else - echo "## ERROR: ninja is missing, please install..." + echo "ERROR: ninja is not found" exit 1 fi @@ -45,10 +45,16 @@ done build build-x86-default -Dmachine=nehalem # enable cross compilation if gcc cross-compiler is found -for f in config/arm/arm*gcc ; do - c=aarch64-linux-gnu-gcc - if ! command -v $c >/dev/null 2>&1 ; then - continue - fi - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f -done +c=aarch64-linux-gnu-gcc +if command -v $c >/dev/null 2>&1 ; then + # compile the general v8a also for clang to increase coverage + export CC="ccache clang" + build build-arm64-host-clang --cross-file \ + config/arm/arm64_armv8_linuxapp_gcc + + for f in config/arm/arm*gcc ; do + export CC="ccache gcc" + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) \ + --cross-file $f + done +fi