[V4,8/9] app/testpmd: show example to handle hot unplug
diff mbox series

Message ID 1530267871-7161-9-git-send-email-jia.guo@intel.com
State Superseded, archived
Headers show
  • hot plug failure handle mechanism
Related show


Context Check Description
ci/checkpatch success coding style OK

Commit Message

Guo, Jia June 29, 2018, 10:24 a.m. UTC
Use testpmd for example, to show how an application smoothly handle
failure when device being hot unplug. If app have enabled the device event
monitor and register the hot plug event’s callback before running, once
app detect the removal event, the callback would be called. It will first
stop the packet forwarding, then stop the port, close the port, and finally
detach the port to remove the device out from the device lists.

Signed-off-by: Jeff Guo <jia.guo@intel.com>
remove some unused code
 app/test-pmd/testpmd.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff mbox series

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 24c1998..42ed196 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2196,6 +2196,9 @@  static void
 eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,
 			     __rte_unused void *arg)
+	uint16_t port_id;
+	int ret;
 	if (type >= RTE_DEV_EVENT_MAX) {
 		fprintf(stderr, "%s called upon invalid event %d\n",
 			__func__, type);
@@ -2206,9 +2209,12 @@  eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,
 		RTE_LOG(ERR, EAL, "The device: %s has been removed!\n",
-		/* TODO: After finish failure handle, begin to stop
-		 * packet forward, stop port, close port, detach port.
-		 */
+		ret = rte_eth_dev_get_port_by_name(device_name, &port_id);
+		if (ret) {
+			printf("can not get port by device %s!\n", device_name);
+			return;
+		}
+		rmv_event_callback((void *)(intptr_t)port_id);
 		RTE_LOG(ERR, EAL, "The device: %s has been added!\n",
@@ -2736,7 +2742,6 @@  main(int argc, char** argv)
 			return -1;
 	if (start_port(RTE_PORT_ALL) != 0)