From patchwork Tue Jun 26 12:39:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 41569 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6775E1B59E; Tue, 26 Jun 2018 14:40:09 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by dpdk.org (Postfix) with ESMTP id D59D31B57F for ; Tue, 26 Jun 2018 14:40:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q8HEK9RyZQlwvgukjVXRuD+J2WdRY38cQ77XfJZjgeE=; b=HOtCKefWOyZkV4qLaVFGcc5iw7uMblrpWNX2agdbKSbT8TNL3J++D6K0B0qcS9c+kBgcesyKL/84UeE5gKscXLmo7uOq3fjOEsTaIewkqrRAtcIvtuMlp4FZK/ewYlhHJ3buCr9L6R/pBxcLX4CoRYJbZ9E/sVtpiMfqc8tkU2s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Tue, 26 Jun 2018 12:39:56 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, shahafs@mellanox.com, Yongseok Koh Date: Tue, 26 Jun 2018 05:39:23 -0700 Message-Id: <20180626123925.37439-4-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180626123925.37439-1-yskoh@mellanox.com> References: <20180626123925.37439-1-yskoh@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0100.namprd15.prod.outlook.com (2603:10b6:101:21::20) To HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c9d2499-99b6-4e61-c89c-08d5db61ed58 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2043; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 3:xNShbep+MInC1USnxXIgujJEebbLYbqVq6NQVrQYzwqdrfFJ/YWLjzafbI+BZ4BYLLUoALGU//MqlI0E+l7FKsSnB9j3oGGn7CmHXFsiC6HnGNsO78HRNDZ3yjn12DuZTuEQfFwgBcAfOhRC1np5UZH9pOcqodL/QhOmyWDNyGLpoedtrv5o1HaEi6dy6iro9QxsClDRkQ7mgCi5dgMy6XWjRbH+8rMS8SmTgQuLsQfgaz+evLzTIw0ugEuH9a1c; 25:xGScUcS6QRImiE4f6OEhU45A9O0t4nLfCZAZTkz/wWLZsob2uE43VWDVLFwjGisWYCVrURidVSHi31GhYo9v6dKaMb3d9Vkv66/36GR3/8mcopsZ4j5vkrzdh7PejQ+WYyi1f1mblkBg7NoQb7z7isLERnEPlKNIR63AwaqUt4kLBs1eM/9LmFjP2o6icBAcsSXS1PDfMpHLnb4WmveAcb7pwtJb0/PK/cm+6NbMAGzF/0RoMEn359JTEmMw9rSvd8dWgDj3ubxLR4Wbr7TV/ABrK7DKHgBzBtD1Od1Bs9sp8T1fTRLDGIst7ZPn/ApxQLyxsLgWbbcx0aIPWNHSyQ==; 31:SOC0XB9JZbHavD9ggQaJEYdlAD+tFYOHbcj7nEzS7bQkVzNezByIWXjouz1ApUU9Cmoo6SPUeEK5r24AgbtKwWPMVnSGHpq1XaZ86HP7R1+I35YL+h7YpRemwWQoZhUkNU7WQNqM71WmcqHs0FxupXiSco4XKW3flW4FqaZicbC28cYfQtO8w6FsJszpmCOoOC/WkSbTJ+Lk058bL/YAhAYnJ+vh7vFpJlUv0p95Lt8= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2043: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 20:B7fer1X1He841z5z4kvG3bRK0iCSPRufeZbL5cizUqvEV4uKKOSRoNFl1eWA0FnWyjK3E+cYmObsyM1aOuy6t5k77E7bYFoKjEoAJAvdGhBVwbh3yeq5aCxTkpo/DP4P/ibd2crOomqXKr7g+E6CS16bZnJ7+VPDJy0RaNtGe0cIPpmtaDF/KSyFk3HcEZJfAY1Mk+k/WGH/JgOCtgNb45dqd6lZxZ9/fckEx71Mp7On2y+rT1f5jgrmZh29DypqnSnDOdtnDxA2z1w402LVxIqF0ACCtcInt+MzbC9R6+KGcrOtymF0UDaZFcG7dbLpCvlYGSBMfFM3iv3VDxUveu2MOHF10pCkmkEcLP83pG0NkPofFSNtj1OpoDMVS9uQzxCuoxwiMrlUhk6U6ZhInEVX+Zw4a/LlA0JZwRLJUObRP316Vpv82jjCgEth4vAVwi5kBNDCQ2m9rpK8nX4HxoWN8mkrjxqsJR6hWxFExCfOH6EM/smakHvbADASeaoO; 4:FEkOTSm8ZY2W5Cxp2x4wc81KKJAHE74krrizrNE9T/Q8tq4AEWoN7kq9e+tAfmen8IwjHYw7+TJGSi6kw5yUgFiyTbVImtjE0gF2J84pmS0NIe1nxOOlxccR21brElbJq+U44R6VN77vRJ+GEun8ptuyU3Xv6lJRHNYTmjZ2ItYNW1AhVvR+hFihxmShyM95hwKkMlv8iBjXiSLEKrdxcKtK/1jLvCrMghzCMtssZQTLJBZ4kDQiuUwQ9eEtUdPwPvNBwV9RFIP7ypYIhcX80A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2043; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2043; X-Forefront-PRVS: 071518EF63 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(136003)(39860400002)(376002)(366004)(189003)(199004)(66066001)(7736002)(956004)(478600001)(386003)(8676002)(48376002)(575784001)(50466002)(486006)(15650500001)(107886003)(86362001)(16586007)(47776003)(316002)(186003)(68736007)(6666003)(4326008)(69596002)(25786009)(2616005)(11346002)(305945005)(476003)(446003)(81166006)(81156014)(21086003)(55016002)(2906002)(53936002)(76176011)(51416003)(97736004)(26005)(1076002)(105586002)(7696005)(5660300001)(36756003)(50226002)(3846002)(52116002)(6116002)(106356001)(8936002)(16526019)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2043; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2043; 23:2qsqvztERZvuh1zuZnX5IeyXFAERuFMgfZTqq8d?= DVzI25Ksf44Od/hC6GxQH3TA/5d/F1s0wh6fb5mzsWSW3EVxE0pGCJOGJNmf/bsIAujsKt18PIg+ljEtpjOe0SE/UoalZVZrVY92vPtZsznKpYcTPyBiD26M9VwOqkHKLbSNpJYkq6GGlLgiMKSG9ZORHtis+sXKMHs7s3w7mtSw2o+AkKI0hJrC7caPrOVC0GkenpJU43hWkaqs5UaKtpO9f3QEu32nrEFMb2g6JvypcZC/sII17OdVKaom9Z/92nBCWarQMmB1PM8yTqT0Umbsdtw8mdhtIDscaFCiVPlJzBnmUBkgB2MiGSEzy1OzII6biNQ23Rf75rcOu6s/kKTgeMwO9tvU95MsafSnwuashoMYI2QW8a9g1cAz4oyHcRNcBpaXds863IzY2KFITUdK+LLPP7ctT4JyBYm2Nfi0k8PpP9g2/PkGv7hCJU1G+7tZEIh1iWAAnpqZP2XBOlFUFWjp+30C2fJ3MNhZ1jB+4BAbgwEloYVskxV8E6lhWwm2uq+pgOcajb1RkK/ps333gaOqdxB2qfKCPMt6Gzb97PphubnndhpqXiqVHmLyMmz5S+bPP/TdjD5OcmNt5Cx+TOD3Z7JDg702u5yVbPNJk5AvnQHnkbZ9R7hIOex6DMllf6nW5juGsVF83NSPXcWnzWBHoefEkRKzEybhNfAbCUrauPkMWOCUE84MYen8uC2+Ke7zIFDH0JI3TxqpBMZVHjJy1jpEU2+VDDGl6l9PHo9rRq9vCIQ/kLVwOCQQd/WBHk0/dHTZbEK1LVHIuTIaTo3KWVW8VqQWtiVtbrAmBprMmdhRy8DOXMB+38LbkMZeqeXTjI7J93r7uM1urN7dm68UKpFddr70LGiUCizEx0i+T9rXdDMH9T1czmnIOx1L8rC5g5jUOYZmRgjqJZFY93zzygGzv3SaDoR7FIOtcQvIoFrQ4hXR4NhJ1ow5bgntvO9aEB5lqmiL7dF6k2g3nRQIGwc0V7LvCa8gkaNcR2etrtIE5dQ28qDiFd1dRAii3qbWNhpgXHrL9ZxYqexGBqcdhq9kRbhN3mlT5Ko+cpT9Oc+zTx+XSHB7ly0VJ8rresmwcnBokMjxT5DtzT/IhdXMIKrZTQmqPJ7s0GABcTYlOFjR3gGx78Wxa60YwS0qnEdtRcAwryGcXlyA3z5A0sn+7d2TmkB3Q2NIdo9HB2ISrtrPOLIgpdTGb1sq5Nqm555lS3jXdoQVsaf2HoQiW73ivD4M4WeasrYMgEJhayA== X-Microsoft-Antispam-Message-Info: Q0hv5LkagDIqhjXU6IwkbFx8v7gGoriQ/8rr3s+bgtk7kzbCOgKZM/4LG8Lo3uETRc9LEKrW+yQ7WkrRN9XStdchRDvX/NVGK1rwPvGycf2KcQhuTvQ4Ll+HUYd1UVmrkPybJvjhOLFO4t+IBe19yew9ohgXAdgv39Q9IUnezvDRcByLhf1UhWpH1Y5QnHXz0lH7m4MyxApukmBaWxkC174ID6CCUBMDaVYVS9jR9VSgiTzouCqbJRSaEdNCdnfscy+AIIumzI6ay3gJMNiX0at1B0B6nNRqGV+axhfOqXxTA8kvgYHDCM+8RIblW67f10iveYxWpY41Ik4HwMkqi6IwPK1Y8PxZxA1sbcVZXvg= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 6:RS/mikmBEfUQd837hug4w1qt7AHlK1hNRfY5QGtW8GOIwF4QLngNL9lLQOPhjs0TwgtAfx3E5N7A+/FQL0OkVYnHEmPKDSkZogE1tU+l9BObsen6LNnoRKybSBuaQE3rqe8ScZBvRbaUm3ZYh887LlP+DMxXfUwmgbbNDdSlIT/2PTVvkedX2HzlatwIUoupk/PTC7ep4JbMSqfQIcG+AWewporvM/RHKjeifIT5PS6PMD546c7aVcVwsewbZJYuDoRUHG/823Fb9MvZDD5qA2fWaaNmrAJZW1BRxiKflolJkM10xRmY3UShzv+SPjSjV/g9i0i/Z2YcqQRaIgLRoZlH0gvhQ+jlBcf0A3Lt+laBdd9+DuiZmfx4r5iNbWT2AIirPdL4jjUONWbVj5VTpvUwoj5axekUdtmej1KVP3izGn0M6dRJbgCooc32PEtl/hd/xObyqcJKrCViKtncww==; 5:SP4kFgW1d/NKIx4kk6xAZ8WPAslkzx604JIzQpvvJSNZWy2qLtdXeWbY5kvRB2zupYhq2AVUL4lR/ZvvQJJnZFze+AQ22fDV8FJGDiy4Ks1Jq7u+II0JYQZKVnrZylbZHokRfjWZqwEu5UOS85VGK6pEHvuGhsOA7geKOmCS0Tc=; 24:9ENVzA9pR3bZLJ9MViq/Vcx4oMqUlZ++MfNyb1NFWTkvYGh8GywRp1bJP9BawIsLQQgwKxvc7UvQexnHLnBJRBpqpD4ZSwV2hXQEKxguBvo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 7:A2ufTaAiQaepRd9qwq05gBU+I9VoMgNkVjM4b30lwFUzd1/wUGqlDhKVQjEu2f1nIbvBVBMtyDHzcNBm6Qhe56/Rg9GJCqZ1BVQxh2Q0oOAjz28X32VpPAR1LA+P8VU1t5RLjiDyeTzvbUxCgHeCOAGzwKAy+SYTiNz9Gh2P5LyQ2ugVIDcoyt0ffeMWeeMi7VKzDuk5Hnms1tA9EExSeCRjvErXJBuJdrQQda1MWNlfOj0MDxfz6/D3paJ2BVIy X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2018 12:39:56.9059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c9d2499-99b6-4e61-c89c-08d5db61ed58 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2043 Subject: [dpdk-dev] [PATCH v2 3/5] net/mlx5: add warning message for Multi-Packet RQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If Multi-Packet RQ is enabled but not supported by device or kernel/library, print out a warning message. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 49b400503..f0e6ed726 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1024,8 +1024,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, DRV_LOG(WARNING, "Rx CQE compression isn't supported"); config.cqe_comp = 0; } - config.mprq.enabled = config.mprq.enabled && mprq; - if (config.mprq.enabled) { + if (config.mprq.enabled && mprq) { if (config.mprq.stride_num_n > mprq_max_stride_num_n || config.mprq.stride_num_n < mprq_min_stride_num_n) { config.mprq.stride_num_n = @@ -1039,6 +1038,9 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, } config.mprq.min_stride_size_n = mprq_min_stride_size_n; config.mprq.max_stride_size_n = mprq_max_stride_size_n; + } else if (config.mprq.enabled && !mprq) { + DRV_LOG(WARNING, "Multi-Packet RQ isn't supported"); + config.mprq.enabled = 0; } eth_dev = rte_eth_dev_allocate(name); if (eth_dev == NULL) {