From patchwork Tue Jun 19 13:08:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 41269 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B76D4CA6; Tue, 19 Jun 2018 15:10:56 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) by dpdk.org (Postfix) with ESMTP id E02D54B4B; Tue, 19 Jun 2018 15:10:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B5RvDbU8LyaLBDnJc/K89WpXCOSlU4Y+CVxRq98WwEM=; b=uHvp+vOoAlejLbLoae57esoIw1czAr3r2W56qKgHv/zywbTIJEBh3ow86rt7I455Ki8WsVgvbt7ceZGDj5ZsuJpxJNaYpyePbjLE6NntGe/rIziSWkjYTj3jKzXyJyI84M47owdlcaD/qnP+exXcgoCVFMJMLbpMcDG4VM3025U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR05MB1263.eurprd05.prod.outlook.com (2a01:111:e400:5188::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Tue, 19 Jun 2018 13:10:39 +0000 From: Raslan Darawsheh To: shahafs@mellanox.com Cc: dev@dpdk.org, matan@mellanox.com, stable@dpdk.org Date: Tue, 19 Jun 2018 16:08:58 +0300 Message-Id: <1529413738-28378-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR04CA0053.eurprd04.prod.outlook.com (2603:10a6:802:2::24) To VI1PR05MB1263.eurprd05.prod.outlook.com (2a01:111:e400:5188::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a546daf-c88c-4046-8e40-08d5d5e61253 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB1263; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1263; 3:f+VxFFQzNyVkTZj8NpMXsH3qJNRH93LafyGw3Mxgkl2HtfwwMihJjQIwCicuDuheWub48f6D6LhkcBLn7KxbHLY1jyVPGRJLYt1W6fAp3/6OE+FLXHBkGOQTejacgkHepfY0zndYu1ASbRRnx7oVoXXE9/gsDwXLnjU0IipMaVJ6y/5Kuryh/x/kseDCG6ORbQYszhJwVD1JsDuKnhOdJ6L9ofwg43LPFyQjx3C6NhZCVr944roYIDI8mloJ8zJR; 25:7rbxo1hIUUSQKQHucQjZ2ph+rzFo/6ZigPtW3a53SSvDvNGzmnTqT/PuuFBj4c6yfPjoRuOYft1eAYIkcVgYi+F0oVKQFKnrnyNCgZISMD2B2ZyPku2YEdORGvw2k5w0sGMZMNbsVBWbuz1GAB/lQGFKKn5G6+kc02EomqliTKcXNgw9rEa99Bq0W3ydXGJGS5DmMt4ogWggpTTmhnBdDMw5S+9judbrx1NhaPwdLn2aME9qtk9GVPnxcdd9+hzJdverBMV/0MKHFWUwCE6B+ImHz64mE5czQLh6WicuZ35Jvp3lPnDx8YRsPNzqO7QW/NCeJmceUn79shT8ThpABw==; 31:OaCPgEXd1VABpU+FRwqGmDdvf6iZoU4uNRzDQC2bJCdLaVPGG8hsVcLkCm7zsIufhhzBtYeywMNQEPrGqMbsmCao9pXkxgDzMkMhDRy44HGXc5+WzWn/p52kdsXPVQOgcsDRjVWnxAijQ6eL9mD3NkLNFCQB8dJkoh0fZjqCR4+czQt0SaYeeoIedwLuWaY3b2QqPEsdMIiC/S1EdApFTqv3L+SUJrqtWqe8n3E9Brw= X-MS-TrafficTypeDiagnostic: VI1PR05MB1263: X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1263; 20:rXBzmau9Tls1sZf6aGXXgyAHgBeg+tPJJ8rw+u2S9R5iHku5uDGxX96I5aSaPk6LJ1lDxb862SBLF6I2dBGEExcCPycUMvRFDBkqssGU0XDMFABc1sVH4ObMS8dq//T/yfJzxFEoXNFM3ZkH8IFiI7hIRgoNIvO8VdZ1V+3qwGn4Q5rcMDoQQiueOKZ922PgmIKyygCoWYjO9bD1Vt5cuvgTU+hadzVNfJxUoC5jOXdl5I0AVRdcB9/TmGBShDe1BJNNJN/ToKGUIAFtd8zRKncaycfvKaUAxqOurnt5kwRgBtuFgr26XywPEhlghueEUbmAq7dQVoAPdkOYuyEjj9LVeXY3xOpD2E6yjhFK2FYO68YolHmzDaXfJxJ1wJfnCy6XF+pLrpve833bBpv+AYzx7lDVz8PUkmb9LjuSjo/7P+0MaRSlmBq8wvevtFP7XbbGN8eczMn73fRuAuKCWmL8snV17OfV7RLyhA1JfK97tMqtY2yXbutedLTQ0qQ+; 4:lH1XJNhARK18yqNBuQDZK+pOzd0gzAfaIw5Cs7VEFx61muqnaZeda3uIJj4bkzoq73/7muA0F9tEuvcOHJ/Us/6tGwyfkvrLv2D2BAt7H/rtmXuwLMM6UEEaZ09m/CJEvxmZMQcBVvqFEP6aAHKpkjme+N2UODqUHCTfg5mYba2Q99r5iEvLb/WGs+B6TuTjwUy8QlKniefdh2HDT8MfRKM7J0FtqKGRVmk4UqkaMC4BOIjg0ow33Iaja201/j/NUyWmA/sj4S+f4wLyg275xg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR05MB1263; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1263; X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(39860400002)(39380400002)(346002)(199004)(189003)(7696005)(6116002)(305945005)(48376002)(51416003)(81156014)(3846002)(2361001)(450100002)(25786009)(68736007)(8936002)(81166006)(476003)(8676002)(50226002)(5660300001)(2351001)(34206002)(52116002)(478600001)(50466002)(4326008)(105586002)(2906002)(2616005)(7736002)(486006)(37006003)(106356001)(21086003)(956004)(97736004)(316002)(53936002)(66066001)(47776003)(33026002)(36756003)(16586007)(6636002)(6666003)(55016002)(386003)(26005)(1857600001)(69596002)(86362001)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1263; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB1263; 23:iabrmWHa5aRwqXRsZQqwpL3CQVSsTxth5uhixDbPV?= l56fW5IYK9jw0aMAxLoiO69EPRBMn8bT5jRG+1n0l52P7k2XCZ+LVx0QjTyBwLuxjcxTHt09omVW/m6K7CNmBE2jnqOAjGxabpTOnzPLCD3Ix2lBifQ403wtKfMCEQ3OKiqIhwdj57xL4n2SSY4jYwM/JFnFXhISHuROqKpasGnh/syL9TMPTG3WHgtAdki8LM1RIV5UYSJ/hBSz3oygluXdK+KQ0vIa3XOjop/Hfh6/L2twjAPDnyjZ07nzkeSiGZnOcg454PG2OOG++RUByIah0rNxUY4J8MKHFss1jLXdguhNjYvzhisO7V9xzZbtDbVH6mah4JC1j54fCViTDrOw9y/HlfDcb8n7UDoPcRgFLxu6jl2kRDF7JrGoDwQMh5TkH83SlMxEhLLKhuZ0QPqXxvj9et27a32SLcDjXRNPktDBL/CkwCdBFC6X24hc7eQ2L4WKnONmvxGVFvleqIVBojDjrLsWzdeziSJQ8Etb/E87K15NAn0R9M2njqdmHECOI+ykEY++xdsNBo0M0w5z65AOehoE8gmAnxE2e31VPDPeNt2qM6oeOY+AVenp3KO2+9aKBn20xtsMtuF/qS4IJL+FMhOd/4T1JB6YsCpAVkraxiRSVJ0h9rcb4NbFdZmsunjTw5nkw2gx4PYJWxWKqxfbDygLGRjZYCZHaVxXbaynovltWevdssSTwcKyUKw0nV9jbJJXz2WhFB7j0BoPVBsWZpRrIkz461ngY/BQpjgyzN4cSWforkgHsHZfsTN7XiDQyjdIrv+8CUC9LJz67B/GKElTEZc3lLEE9jDy5qs/KopPecib1MSgcZP0Xvv69sAmYmpEqnp8fkhQIjBudfUSeLPew8drM5xcqGun1txeOSKgIHyHGYrggVx5wTMr2lu6gt9uP2WdGKoRQfDlr2tws1X15HsAixSaTrmAHXPBUTBLsdkLe+MwI7Y8qqvQi5wiCaH5EchvDmp4yH2VSXMQrwe7U2HQgD0lLdT95vEe0XI3bvT+p7byOvSy0Tj/wUxGBBXlJo9OxJu/SpEtogiEKeCt61Up7DuE/7Ke4nmO3fbJns3uvnDaieR5IaOcMYV47sHdbT85+JUgVMvXTtyKC84K+XNA15tgstJ8aUOpl0QP1vmatBqa76gX9X+YIZ66V0lUTCNsxQfS491r9pUTf+vQJJYXZ1MTMAIA055FTA5bFPBZOwLWKpinWBzcOC/3FilWzxn/4Tg4yJm7DZXFSAIsgf12EcnIBuHPg== X-Microsoft-Antispam-Message-Info: bjZmCQjgP5L09svu+Nwot+VTUaebjVe3ih0mJmvAHxktNJ1DL9TRIis3fP95QFwq9/Z1VoqVrGNdF126GJLEas+q/6Df/ZqtlHDvYMEcDIFowkAHlTUerP6jj0JyRTJ01WS4RZdyL/kOMv+bB8E0rd+uxRZ4W006qYj6asaW7CmJYMSjNO9mTMCfqKJOJNDsLFRjwSc51RVUbzFOU3ZDUmGnKyUp3o08D/4hwEUa7d+Lw2UE/hMX4NXSaFw7bBfL4C35kK1CwvvxJuymThqBtty8OD1R6j41qHAHWZOgAWGzqKag82ZPKv+lMhvvnPprNsQ4G2UbZk3XYn9jfEqlpw== X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1263; 6:bhfAgFqR6XcAwe/eXuE9DO5c4UiSfRkBRI0289jOIrN/sWHbs2cx00SiY6CcbCNt4v48KGM1GWm5Te40o3xn8IYYkliRUixthNcKgIXc7bbWa6Co3diQ9HFy4wQRoJHuN1DnhbK7Mh2YveuYsiFEUa8WfFsgi0nVm34/Q4WWaGtyY1Lwh5ituiI1bSmlBB/V2gkxQyP63vadEn21yEUhCLe+AJsg8Iq75iC7T9y7sUU2BkTINTRcdRbNA2esUzNDZOjaNgcCA6ECmu19SNs+1mHxYH24AoFnscu4p0debGDXEAKwdZ0zEskPvmy8olr6FTlENZxQJ7t/PU8xMTySGfdjfM/6wYx5tV+YFGXuzk0hQWmO0XuqJYG5DWfvQzmKU89hERR9xaEjl/lErlLONLGb37ZhzshDqQ0BGdCjQjEyrGNtEokd+0nm35pgiZ5peLLIyH6JLitXgzeYHljqeA==; 5:Bz7bp+m0NGqFOc9xb3JMm1NOp/AQ1wuQKVR768Xn4CcP0RHJEvw0KgyhSY0MF8EeKl3Q3lqXsc3av3vcWBm9BBLUZbIka/iBjDm2w/4lAgo3E+PjMkBh6mQpXuu7wWybS5z3yPHHb0plIfN3w5yqUbcPi7o48D6uLrHwp9oE/TI=; 24:2qEsMseKyWRuZrXjKTaLE6ZOdLm+E3XxGLUnw5SOnBL4/a7d46ol6RDUVjmCYRpPHDOQVkX3ARaiYbV0lIeGv/NOA05bQt8Sl2MuLn12w78= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1263; 7:V/1DexJogdQanpqka+M1RClnU+WpLOolk0yuYzCETkPLfvhsHYtO32WyFb6bTxTIFdEKXYReMfkY+EhBAITd/kRXRbxXveEbk0GVrvEyeY5UDQ41eOKtd1GdVZyOdryFt8bXR1MOshj65TWfFo8l0uvXXLms7qcv0qSs7+2GLOB7dwSew1vDVbvmQSPjca5vGbB/XzWdprBp+3Q4EZr/MG9o7Tk/t+OHB8FM0HU7o1ioVVlWgCrtI09A1ACaAvNs X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 13:10:39.5797 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a546daf-c88c-4046-8e40-08d5d5e61253 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1263 Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. this change the check to be for the requested action insted. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 994be05..40df633 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT - if (parser->rss_conf.level > 1) { + if (rss->level > 1) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, @@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #endif - if (parser->rss_conf.level > 2) { + if (rss->level > 2) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions,