From patchwork Tue Jun 19 13:07:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 41268 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32B1B4C96; Tue, 19 Jun 2018 15:08:06 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0058.outbound.protection.outlook.com [104.47.0.58]) by dpdk.org (Postfix) with ESMTP id 8A2DB4C8B; Tue, 19 Jun 2018 15:08:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B5RvDbU8LyaLBDnJc/K89WpXCOSlU4Y+CVxRq98WwEM=; b=BBGtLT25kwrWkE8DdsF16uH1wMF6ENqNPw8auzmZ/GaS8OL2ySMAcmUgFrEGxwp17hWiL3IAKtubBxFyyuhsJNul1a+FzyqMupF2TexqpHnK2+MGVhNsbAoM2ZHoqzsD7BIlKzljgBPCqIF+VBMbGOm4NAP06CXiMlSdXRtCi34= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB5PR05MB1254.eurprd05.prod.outlook.com (2a01:111:e400:51cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Tue, 19 Jun 2018 13:08:02 +0000 From: Raslan Darawsheh To: shahahfs@mellanox.com Cc: dev@dpdk.org, matan@mellanox.com, stable@dpdk.org Date: Tue, 19 Jun 2018 16:07:20 +0300 Message-Id: <1529413640-28316-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0501CA0039.eurprd05.prod.outlook.com (2603:10a6:800:60::25) To DB5PR05MB1254.eurprd05.prod.outlook.com (2a01:111:e400:51cc::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 69141c67-98c1-4d4d-c20d-08d5d5e5b0d2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1254; X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1254; 3:zvhMaKT74Mny4rn4gQvAgAlEoyiKeunVAWTSixv9sd5re6hS0W5TUzUKQgE82xf1ZC4zDkjm+hIQz1P2JYMCUbArexDQQGl6J22sm/f4wJDK2FLorLKOPRXX56RG4xYzFkMEXAzzHwM7ZDaFl0eKl3THz2Sy0VRiOjK+sxlfaZEVzZLMp3cyrGYRM3Pzj8/9kB98BW/u55M2PZ9DrC5C7bZFbw4WHw6LtSwavoFynD7x4C6AOWMYnMfia0ZvyxN3; 25:VuTFLhXe1yi1lzq4lQIfiVyfzewhP+NWcHb4AEa+ZvLn3QyLqE/uJXM3RLL/lTDiG8Y7+Q69FASYwrk/YGQhzN2EIvZLlPGJE9ixz7h2VfxcYB+g+VjRD/BO+2VjsiTSqoYlofDAsAtVq0rAMiWOhdrGoVBf2vOBGVemXEA+05I8jFCvTkC3tUm1k+z5lq/s6yTsW/ACjhYB6GCrjdHEJw8He1HbrtzCplpbbLfBmz4ti2tH4YopPiAT++nrJmz889BDZTEtJpGV0F8rUPyCUb7bvmYv42B3/Bob9rtpMld1i1q7+DM6SJuNr0nNXi7ZRtiLd2G2WKxSxapLIF3CBw==; 31:ISes0w3eZSTz+i1lbrD1fnFA1YVqBfu9u0f5KqQXmI3fkobUgsAfStexOrS4UIz8Ryj3PjORLxSxnFQvkPdi/vzA+rpTZm6j1Nohi0GF9J8JMoEDSDwLsGzir/3l6ZTQTOVqsm5mC7eRAle3OgDtG5VGBHg+Gn+g6rF7MmSCy8HP340JfwyW3IKnCDxccxx7/nFlPJFGNe1lA6Xnq5ZPi3i+9eho7L6oUUjlL3WoPyI= X-MS-TrafficTypeDiagnostic: DB5PR05MB1254: X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1254; 20:TFEFT4unUArsu3QoESA/dDqkqSezxQZMwIzhWj7nVNUhXPtVSdEuYgzUL9FI5iSFBRRuAg4lch3MsRv2ZO/RAxCQPdqYFf/jyuQ6zJF+AMFrel6w24/APf7CM5AHw4a7MhLU8xaUDFv9fZl9wYjh7x/ePDB1JPOT3zWctozc+GySrOatBJhlTlkAlPIDCtau0/rWdq/aIIEmfdj5nnFq/D7GQ+T2I2eXc2jpabhRavClcIQ1cmzEB6I6Oz/F7dJgNKlkDy0V3XB5oHhr41bhDEr80i1sdgst0mBL2UUHKPR7fvGluQY6U3y9EJPrqzxZAjdiFSXNgwm61AxgRJx0DsNcWJ51OSS45Q82fm0KKh3awhVgKZFJh3EUZuRJrvVjal0YWoarPEle+E6MF/WJ1ezGsl/nEPKp6H6Mfs91Z4IMzXdvLlLbzDDD6hPUHr5NFKusN/xj8AAJ8zfcicyaq6p+5qC9UJLpJue3aygM5dBeVmDjzbOxSX21gzvT/cI+; 4:yQwqaoUa0Uf/SGP3332pY2ImDueLlW3Ldaevf/06AWYa/Ot47F6iWULF7yE2vt+tjNNJnagpdWjcK1vjYSql2GTmOf3gehbbzgHdgeHGue/bMEQjkCKKd8Nws7Lv1CAakgoN2sbJFH7Z3dQFWRlW/G/2iyBBSMgPyykfCPehJZY0F+7ZwsOYIQnBih/DrKFa2gmlBcqbSARljgxZHjDb4vLQ6DrD0w6rIIb5/byslkl8PfstM/HWSjjYbLkpx1nu9EelFXLppqAUyOnS16Knwg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB5PR05MB1254; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1254; X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(366004)(39380400002)(39860400002)(189003)(199004)(16526019)(386003)(8936002)(476003)(6666003)(6636002)(50226002)(21086003)(2616005)(55016002)(956004)(37006003)(47776003)(16586007)(81156014)(305945005)(26005)(1857600001)(86362001)(8676002)(486006)(36756003)(3846002)(6116002)(81166006)(7736002)(68736007)(5660300001)(97736004)(53936002)(2351001)(2906002)(106356001)(50466002)(105586002)(51416003)(316002)(48376002)(478600001)(450100002)(7696005)(52116002)(2361001)(69596002)(4326008)(33026002)(34206002)(25786009)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1254; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB5PR05MB1254; 23:WrVUgd/0K4qF9hRJMWx5PD7mwut6mzGis/qN6dkON?= eE2o4WD8rIuMEt8XrvBZmbBU0ltScR2rnpJeRO6nOCudkTCHADyb4meRkinro5jbTXkB8eTx40K+FpHEN+Wv263ChMU7lc5mNW+dnuS/DELrHR2j8QwH0KVujBC3g0khEQga20zWOMghDCOS5OYjQW0Ukgvyi5aF703/5Sj6uL/0/ubIJ43ulKuAvWEICzlFicBkDJSvaMFbPw8rraUqPizlmYSWsR5AiLL2q6fVW5NPmvlti9MVrRdtc/iBVCjTKWdIKkkDESg2G7T+E4rq/dcQCtefLak684R2zRiledFizNKp/HfrpwyQIQoO9CEXV/pR/vMZlk3dGfHum2MSGf1yHiR5u6R2NyszZ9Eql8KX7CVQPPjX7dsLJCv7PgiM0mp64TfwNpzF+JDglzMO/KlssNZvQ24//1VC243iJt3pWipkkFDdq8HCct9fX0gygVKIg6Ygb4PBMaBg4/5PTO4j7K+8/VUSCKlYblihCx5KPoBBpd5lOl5ejIbCWV0WyFrICkegtV6AE4Qge6hMdAny1UuiKFpJ/5XC1DlUQjOZ+jprjsBeLFzwDY1hXAdeHKKt1qbm8PzSnUfAVPNYLG0IdnNthE/LWfSybF6dhePWxguEm1USfehQlCGijs+LaUL8RSt0iD9LrbP/Gmy8DfrysVw31cd60M7HqQPjhGqR0f8xbbEVb1uBTW5IlN4p0m1pqCZV4HSsLY/ey4i4mOXSX0VX1YLmlPKjCyBaoQR7JBb4u2yXj+hCT5E4wlA0q+RIStwravHMuI0fCdrSUq5LNqcZV9ZHvuQMRJNuBGnF0HVaUNea+HhOMW7nDFa2cdWJGghjm6gHwHJtS/ez1lRRMuH6DXK65CDQ5d4kCZ7O5oOqj2mFC1sRuD8exTC6bbdXM4TqVqiWuOAbWgRneF4b5jAH1Pd2jrLt6vnnmJ0JJO7m1Gk7vB3mqUGjwr/w4+xX5p16vyVYye3G+8SlQsKYZvfmAqbjJ4WJ1A3zYM9Mo5DHE7vTp8b/p2RTY6MXcSS7gKG1UxJvEr+oTph0NHZZu9c7Xw9wqo8k43tNbHAlL0Ph4wm0DxhrqzSH+YKi6ATEbjuQjJKm0lMZwBQVgw7t6kmuSKQaAlpjiZ+j0aX/Jrx1zzzTVFQ+/Z9ek3Tu/wBQ32g2j9nBmz+cZJjECKQW6K3iPnPUf57wXVukh1Vh81YpoWQFtruGfJCunf0XeBNuLMuZ1DtPzcHDAiZ15MmDrJMvdJFVZYrzdbwe3tD4w== X-Microsoft-Antispam-Message-Info: U0qm6JZMuAzucQJwyfdghvIcj97LK5jS5CK6xaf+YmP9M9pahGvhtMwN54MTQtt9iurDq5MVuJwOAeA4CA9S6XBye0gK1uK4FSDEEjqoXuJEfkHCinIzM7MO+n8jMmGySxRmVIMyl2aLgriUb1SQtMxN10SitKoFgs7CzcJkFiNhplua5jqvcVxLCUDOz3m+FycHRnL0rA/4kbqDEu0KT6PV3IMhVR5Vqq3XREXtI94+EqG+X3akICcJWvSbGlvJwFQObSVejWTxVeQufCEeCcQu4NX3sVJDRevUeDxP97TQ0CCMhKQUb6RO6Y88yTlOHyAgsoZjbb1KR+SPnnaIAQ== X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1254; 6:VpIAYvCHw7lwaEWjdSHnsCD6yfyvZ6I0VGW9y8tixcP1X2R/cXMhQqNu+EmWf9ao3osswXteSGYDxK0b+0uj9pTCuAJUw+AFxT114hm7FyZNulVabXrIjDNnxcX3ITeyFIuFcxhT+gS0Wj2Dfk1g3MTXqVkEmnBsIqGy8aPB3fvgIaHRxiHC2X9V1OU0y0tp1r8UQsa/Yog7Rl4llFqHoHfLHW8SIczJYUplOuCxQPbx0Z3huomXMbUav6VAGVjEBfHO5xXNEUFiPsbV/o98t6vSgpz1yCvZLFKPW9pHSQkKWyfvVZuNt5v4HLhOuhtMNdMhdR9AktEZb87k6k8zDN9q67uFBcNTIDNf1ijPFYD6uvDaVA6WZMM9mWqZiVliHib21vwA/CsGnYQjHAqMmHblQ+GmdykxB6BxZrkrEJhOShHdwA54bmePa66gkpYcoOnFcegjiXoR8xA9494JWA==; 5:06NZjoNHpSc36HjqJAkUOYjRaNySj7Gm8zPaOfg7Ln4Wj/qkn92rUQLJnhJNxzGHn91phL4B6SO6LMrsL8yKtEGSax5Bt5TxvlnBRdTrtJ99KOgHk0+e5SEZINGJawb7UTGI7Lfzjou7YSxGtVMHrlAqbdmAEaHU6UlWWAxxy4w=; 24:B2ZZ9J79VDRNLLIMBKPyNwAQ3aI6cXlawou3M8JMlntWRKtUf3luD6MMgOC7wJtnxqGg+SSD/0T4KGwp/Id4C+NGCvbntnlvIjkEDKhzbaM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1254; 7:n28WrWI1naHDVi0DHy7qzdcag5cVZyTQBSJ1rgaTbnoiHVeHSja9UC44hgzZmw57BnT7Yf4lt6Q1ZZuYtfbmPsgesZwoVscnRxyTDB2fBGCg3LL8LWb365JtRh+anndsX+l5MhEsqaVVlB/6ZomAhOKsDk8aOsgRuZMRM4V/ZysVFc7ZD73CShtRCKfZjlvm4V7raFex3fpAqBHurqnVYvJLefh9BYFQcIpQQqUo8Ut3OcOohqJsC+1wySZOHoks X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 13:08:02.5045 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69141c67-98c1-4d4d-c20d-08d5d5e5b0d2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1254 Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. this change the check to be for the requested action insted. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 994be05..40df633 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT - if (parser->rss_conf.level > 1) { + if (rss->level > 1) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, @@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #endif - if (parser->rss_conf.level > 2) { + if (rss->level > 2) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions,