From patchwork Thu Jun 14 10:17:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 41104 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF7451E9EA; Thu, 14 Jun 2018 12:19:20 +0200 (CEST) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690077.outbound.protection.outlook.com [40.107.69.77]) by dpdk.org (Postfix) with ESMTP id 58CF61E9B6 for ; Thu, 14 Jun 2018 12:19:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5EJBjODc5pxkd6a5n+Or+MPf6mc8SdDdN4esUzXMWak=; b=UKIRw7uJCddi2cQFZlQidSYwnR00itVt1hUFVzcF6put0N7v50282ji27llbMqiQXqZ8X6wiTvdaNQobrGVkA6M1Swyssnm+uuiXzwDFOUxWZLOyI/ew95jPDR01GiH0durA5DKTZyvBGpOLfrolSQj9hgnp1oKNuoMZluUOSwM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BYAPR07MB4902.namprd07.prod.outlook.com (2603:10b6:a02:ef::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.19; Thu, 14 Jun 2018 10:19:14 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Thu, 14 Jun 2018 15:47:51 +0530 Message-Id: <1528971477-14156-10-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528971477-14156-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528477766-15788-1-git-send-email-anoob.joseph@caviumnetworks.com> <1528971477-14156-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BM1PR0101CA0031.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::17) To BYAPR07MB4902.namprd07.prod.outlook.com (2603:10b6:a02:ef::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65061339-4019-4881-4148-08d5d1e048e9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4902; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 3:cG6VSjzeEji4hwYfXAtaDl47eFo/+NAoJ0s4/WUtoIPlDqVDIvsg21oYwIcyXtrZobjIgwOM3mJVgSbrh9VcoM4EnjAo/GbQhnRcwU/R3tie7FCKjR03DN569to8IC8/bkQUDV7RgYr6yWTnE47ZIUnjqIB1AEQPtOLEhN3Y0GuNOiutcmc4jTt7T4LdLcJhEvjBAekQBJMvtia1i23rTNT/u/6+bBGNwEsxzzH8F/0zPRWb02LDEf0WuA5gJ5o0; 25:dnTew3N1ErA9SOUGimqBHcDTjo8G/cv/7QUwrxo2etZIqFgIFlq4CwF+0sKGZpe+jRZ1Kq+6IPsbpJKhY+8Yn2Uc2e6WcU4PlikDpRDPHqK8ofbXFMK3YaRKYbHDgNmtfdWoZ+gVH/rCTgeKsndbS7O0WFeBckN2VrB5+o7cfTTAwuRQ3nghcenBaZo84oy/upCuuhdFAz/ZpmozNB4bDY/7pnta4naYn4zIjZJqGnkEWOxHL6ixT4ZUgJvWZmKnRkOvVqeHfu4V8a6VvDdIL52laG6lNU8AcNUsEXwWjN/aG5Nc7iIVvg+138HLBcK8Dnhxkmj7n5sc3xtUlHpr4w==; 31:zpTntrIveH7m7huqiJLyNGzjVknDPSL0z81uLa72JUhtKXCnOXW4xrlRRraSfXSML9eSk3OZ1260o008Aet7j/pwe0J8gB6Bn1m2TVRHor/sE6yqQu2PAkkUhsvQGYz4oQiCJDlyowRDF/x4Y6NfKuB1Sz84PuGOqjgBIKJ47YMgY8hIfegPXdarbJLOIxYk+r1snomjap9z3Bcx8LA1GdN/e5eklAO+9MafgDjZW80= X-MS-TrafficTypeDiagnostic: BYAPR07MB4902: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 20:ksgNdjJ1mLj9eY2OZ9J61ZtED1uBi9hSivulWYJG+l3inPDPT7ERSfE2aP2TpESt5ENCSvmbL8IwSXgrqsbMYgZKW8h544TwRZC3sQnVIG8bZHikx4Qplbga3dZVzb9YooR1aiYMW9ZWvY3U6e2xLkZ1ekzraCK/TlmBk0TIom7AZQ4bnymqNrU487z1wPHz+l/XcbA9HxCMv9rImK2yRycdarH5EIp0cgEPqkWhyXjEeuSzy+VvWdRQBbcje02fpwpUtCoXYFf9n6tYJk+T1hg2q8ZSN9xsDEE7qapnTOs15vnbPNpF702jvrwlGmXFydfkCXICiwM0Y1XnZ9B1GaH3aL01sxQ+jCXG9501iMMxZVuym87MN5QQfsxQisc5mzvZFFC7Fw9teM1miHRF3wAhhIfSsXRTQaNq6d1QBRNZLTDy64O1nqIKvZ4frutbpIgCWc1rqCGcysqlLMRoD6VOXOQOYUVuEXUr62icHqNKW3GyKRwZ9Nncg4Yi8n9UX1lPcXfFnVAAtXIYyIPzs6NwrGy239jjXZSz/yq+3KwbjOFUH15dLqT322U5Vlru08GWeNVZtNYW03NKugb8jXuwD3bm0Fx1auntfYO3NMQ=; 4:uOn4SaaH/Ch1wR5Su3gec5MrKgpW4+PBnoWeuyhCMPIwdjjrFrhcGoEYDt8Lhs7oORc/hsQ/tILPcrLaQjUzdZj3F3niYfmRkUMwwh+3JJuCf0Buuk65h0r2AYLBaQtdeHPxlupfZllJbL0Yv+po9WQYo3O2ZECN6xW4P94IU5aG+JvvBK3gcXwxwySZ1aztkZpDZGjCN9PT7P6ihcqruyVXihKh3Ws0mNdBH7Wvady5hRDxJjGS7Y02c7ThnvcSW0M+9KxoAz4UhqCbGQFfnA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BYAPR07MB4902; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4902; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(39380400002)(376002)(396003)(366004)(189003)(199004)(316002)(6666003)(110136005)(68736007)(2906002)(66066001)(54906003)(47776003)(6512007)(5660300001)(50466002)(72206003)(48376002)(97736004)(6116002)(3846002)(53936002)(16586007)(105586002)(478600001)(6486002)(106356001)(6506007)(36756003)(11346002)(956004)(25786009)(4326008)(50226002)(16526019)(186003)(81156014)(486006)(81166006)(8676002)(7736002)(26005)(8936002)(2616005)(476003)(386003)(44832011)(55236004)(52116002)(42882007)(51416003)(76176011)(446003)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4902; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4902; 23:8oyweKYODU43+xA5528M0ge5jBQWa4/of/tF+SlB8?= FAiTxKZFPOqmsyRVWQGBYx29/7FYnirRY3JqSWAf2iTTj0kl4GMP28VCfcLd4tR2C76B0bn7maI08KYV92JAsk9zP84pNikjVhT0e4R9p747xsRPF7CbkbLSvT0uMBirT0NlhXggG04/r0c2vcKHV9lWj2QmXzhLkHRrjgz8HtHqtQrD7zXmVG0IXxl4QT08o8/6pszBJ9McCJ+RPLjE7Wk6+4SEQKbUE7QTVMoTkr1ug+fZvY2ay2keOVhPHr9bogHBuJvpkTJ8yR8xIXgXwQ3dExzOW8LojTfL1Dsnsr2d1jBBCqlbQOcmwWomhj0IdN6bM62AfXKP2q0UDN5rhsG3GpafjvccY/MjEZkDOqz1cqSYHJdCoX1kQsjkPs9de81O2OWj/iLU4vG8fPw2qior/zx0AY2ypd64yg6vFgdobP2dJoRV/5h4R9DRqWI478bL0cbFJweoHq5roe6/Qm9TAlsHWXWV8rGE/vTcsJZwJH6SK9RQmQcmEbz+EVXchsYWEUa6sXJIst9e9b3U7t0tZDR1saTu1sNRHTudggxtncEPQAHBmUTW0R6/bRxbe6rmdZu10OPafqXRoKPDg2TsOUGV6IuQ7sHn4wV408H6GXdxRHU6+QSgcGPYncwPF+iFbTvLg92sIl5UB9XgGGHTpzxfh8sStM/HOdjPgcdJzbNiwP+umhwvu1tQP6xv6bP/gJ03CeqphW/9VGDY2156N757TM1PNsvgzYExctHhwqRihoJoKyxPxGerIHGvTapnymTM+rWc+V5DkDtIOdfhijUhG0qrBqvnhG7hJlqvZgR/TzEGyUMZuvSnmNoZfqwJzPRY9eTlg52pDQitkVyVGiNVZvO0BIjbGVMoc9cgQ45Qs7yYBjPQlYVpVvL6D396HAoPPBUhC6znqiSCMsbKLGV1lkH5FeIYrlPCuRtUEKbxTi3sYDcx+IlqOO4n9xfyNGeCJ61p9wQ+ftwGotbVLwMyySu0wwJUY3TEmRrqabktuEmf8ub9FL5YNR9HMZCMZzgdjFRvN5lK6C6Z8qT+4ZBogW7oyKOU1rtYa/2YgttmrbM5/8d/JVYq3bmiwx/0hK+30Myc6+8swDi9IOfpiPy1s1gt+gx7EiJJUxlFfN2eGm//UW5VbOHXDAldcuTgXHbW57HIQsEEN9C5A86n/BBCBLvznz7nM5XDnuJ/PzZXGQCT7Y8CRKqaEN+11aliXOUuzmn6PVZsqkJ3Kbg X-Microsoft-Antispam-Message-Info: Q5V7FXPGTqGvkGuLsAIyvOPHu2J8HXh+75kNbCanVgPCJqtw2O08l3D8XE3KnVRt/BPK1k/6p+Peo6+s1IOv6zqAW7UyD1GFgwzP09MbXfENwteq7MK0EqwBeD/XmzgdbOk2vImLQXVamUQ90rHyMGMNQuwNOMEXtfwEeXaElXvHtX/Ce5eTJ2bSiI8JULMQ X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 6:/4EPA9xGyiFm/j//+YWGA1dWnQLEhuKwo10Y53yY8bR+zHQUrMcc3jsSaRsl2w9bWKoXFmgGVJCVHXwCtVdh7RCnZJ+KD0hiGm0jfKb1sts7OVKOa1hWkBGWWwMSp+eOH8NhtNrxXn10GhQo1WLUq4IRhuLzOzmnjjTl6Y/vb8GxoA0YyygneuyI7IBno8FwRtjLUwLzD7CO1ZaamZf0+jkkwrQIPkSyshPQaZKkthXm4HSc0H0b0OmxcRo/IcAQvxLCu1Y+ChFM0JYGrq8UbqeMWIl282tElVFYsVDZ/6Zi9ehREwlGpACIDYChh5UJkw2pSw991Fs1NWB83X0bNwlvETVkBmGVlyluZXa2eXaeMn+gZHl2+4DuuxpiPvCNhd3EMaD9YdwjdRBp032c+DtKAd176vxKoJQpL2I8uXWtOYCDQ+HjldL96ODf0SiShWJyY558porjVysgd9c2Bw==; 5:itjwKiJAsV1gpKxLj4IrGpwT7iDRClpL7n49u/N1Z4m2mpa6XauIBtXSeHCZk6e/9Fcj6wsIcATuqn+bOpx8l/2JNh7SuwqjjWkch3SuVixLgvJsP3TzfDxzyhmMeMQZfRC4Vc/wmJCCp1FGp/zOqFm3CoJ/G32he3Zt8faRtZQ=; 24:a/cuSbH5TH1E2DuOBD7Uk66MXSQkyq2jPfipJmZDgLWCBgrOZQ5uu0+jJFPzhK/UfQV950aTPaGFnIl5SmZg13JBYqvSSbjmwgalMRIeMvc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 7:LcBktpJGR5+FpbihHiQcPWFSy+rpsV+to0Yaqi1YWRkU5ocWepRrm8GeOvuz2u1twwB3OUHiWsWrw8ePpyiFnNTNySSFYy4B6PPUbKc5pj5oMZE4UUbhWx0ZLRhkEUlOe1OhKp3N7rda+n3zJtcoPmKwGwYT9lnuyfUVlRrlREdjq++p6/iDwRspXkM7QDKeSV75wf6UrD6oyMJ5UrGExq+2nZk+HmxrbhCl+yp93fqjgXWDW5zj802zhl0ERnwg X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 10:19:14.5512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65061339-4019-4881-4148-08d5d1e048e9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4902 Subject: [dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" v1: * Replaced 'unsigned' with 'unsigned int' Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_worker.c | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index ad5468a..dfa78ed 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -76,6 +76,24 @@ print_stats(void) printf("\n====================================================\n"); } +static inline void +l2fwd_drain_buffers(struct lcore_queue_conf *qconf) +{ + unsigned int i, sent; + unsigned int portid; + struct rte_eth_dev_tx_buffer *buffer; + + for (i = 0; i < qconf->n_rx_port; i++) { + + portid = l2fwd_dst_ports[qconf->rx_port_list[i]]; + buffer = tx_buffer[portid]; + + sent = rte_eth_tx_buffer_flush(portid, 0, buffer); + if (sent) + port_statistics[portid].tx += sent; + } +} + static void l2fwd_mac_updating(struct rte_mbuf *m, unsigned int dest_portid) { @@ -116,7 +134,6 @@ l2fwd_main_loop(void) { struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; struct rte_mbuf *m; - int sent; unsigned int lcore_id; unsigned int master_core_id; uint64_t prev_tsc, diff_tsc, cur_tsc, timer_tsc; @@ -124,7 +141,6 @@ l2fwd_main_loop(void) struct lcore_queue_conf *qconf; const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) / US_PER_S * BURST_TX_DRAIN_US; - struct rte_eth_dev_tx_buffer *buffer; prev_tsc = 0; timer_tsc = 0; @@ -159,18 +175,8 @@ l2fwd_main_loop(void) diff_tsc = cur_tsc - prev_tsc; if (unlikely(diff_tsc > drain_tsc)) { - for (i = 0; i < qconf->n_rx_port; i++) { - - portid = - l2fwd_dst_ports[qconf->rx_port_list[i]]; - buffer = tx_buffer[portid]; - - sent = rte_eth_tx_buffer_flush(portid, 0, - buffer); - if (sent) - port_statistics[portid].tx += sent; - - } + /* Drain buffers */ + l2fwd_drain_buffers(qconf); /* if timer is enabled */ if (timer_period > 0) {