diff mbox series

[v1,01/15] examples/l2fwd: add new header to move common code

Message ID 1528971477-14156-2-git-send-email-anoob.joseph@caviumnetworks.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series preparing l2fwd for eventmode additions |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Anoob Joseph June 14, 2018, 10:17 a.m. UTC 
  v1:
* No change

Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
---
 examples/l2fwd/l2fwd_common.h | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 examples/l2fwd/l2fwd_common.h

Comments

De Lara Guarch, Pablo July 9, 2018, 10:46 p.m. UTC | #1 
Hi Anoob,

> -----Original Message-----
> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
> Sent: Thursday, June 14, 2018 11:18 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
> Subject: [PATCH v1 01/15] examples/l2fwd: add new header to move common
> code
> 
> v1:
> * No change
> 
> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> ---
>  examples/l2fwd/l2fwd_common.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 examples/l2fwd/l2fwd_common.h
> 

I think this patch can be merged to the next patch.
I don't see the need to have a separate patch just adding a header with no code.

Pablo
Anoob Joseph July 10, 2018, 3:16 a.m. UTC | #2 
Hi Pablo,

I'll merge this patch with the next one. Will do the same with 
checkpatch fixes too. Since this is a common benchmarking application, I 
wanted to highlight all the changes introduced. That's the reason for 
small patches.

Shall I send a v2 after doing this? Are there any other comments on this 
series?

Anoob

On 10-07-2018 04:16, De Lara Guarch, Pablo wrote:
> External Email
>
> Hi Anoob,
>
>> -----Original Message-----
>> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
>> Sent: Thursday, June 14, 2018 11:18 AM
>> To: Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>
>> Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>; Jerin Jacob
>> <jerin.jacob@caviumnetworks.com>; Narayana Prasad
>> <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
>> Subject: [PATCH v1 01/15] examples/l2fwd: add new header to move common
>> code
>>
>> v1:
>> * No change
>>
>> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
>> ---
>>   examples/l2fwd/l2fwd_common.h | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>   create mode 100644 examples/l2fwd/l2fwd_common.h
>>
> I think this patch can be merged to the next patch.
> I don't see the need to have a separate patch just adding a header with no code.
>
> Pablo
>
De Lara Guarch, Pablo July 10, 2018, 10:20 a.m. UTC | #3 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph
> Sent: Tuesday, July 10, 2018 4:16 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to
> move common code
> 
> Hi Pablo,
> 
> I'll merge this patch with the next one. Will do the same with checkpatch fixes
> too. Since this is a common benchmarking application, I wanted to highlight all
> the changes introduced. That's the reason for small patches.
> 
> Shall I send a v2 after doing this? Are there any other comments on this series?

That's all from me, thanks!

Pablo
diff mbox series

Patch

diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h
new file mode 100644
index 0000000..15059f4
--- /dev/null
+++ b/examples/l2fwd/l2fwd_common.h
@@ -0,0 +1,6 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Cavium, Inc
+ */
+#ifndef _L2FWD_COMMON_H_
+#define _L2FWD_COMMON_H_
+#endif /* _L2FWD_COMMON_H_ */