diff mbox series

[dpdk-dev] i40evf: don't reset device_info data

Message ID 20180606203125.90711-1-damarion@cisco.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [dpdk-dev] i40evf: don't reset device_info data |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Damjan Marion (damarion) June 6, 2018, 8:31 p.m. UTC 
  At this point valid data is already set by rte_eth_get_device_info.
device field becomes zero and consumer is not able to retrieve pci data.

Signed-off-by: Damjan Marion <damarion@cisco.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Qi Zhang June 15, 2018, 2:05 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Damjan Marion
> Sent: Thursday, June 7, 2018 4:31 AM
> To: dev@dpdk.org
> Cc: Damjan Marion <damarion@cisco.com>
> Subject: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
> 
> At this point valid data is already set by rte_eth_get_device_info.
> device field becomes zero and consumer is not able to retrieve pci data.
> 
> Signed-off-by: Damjan Marion <damarion@cisco.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Will add below fix line when apply
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Qi Zhang June 22, 2018, 11:59 a.m. UTC | #2 
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, June 15, 2018 10:05 PM
> To: Damjan Marion <damarion@cisco.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Damjan Marion
> > Sent: Thursday, June 7, 2018 4:31 AM
> > To: dev@dpdk.org
> > Cc: Damjan Marion <damarion@cisco.com>
> > Subject: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
> >
> > At this point valid data is already set by rte_eth_get_device_info.
> > device field becomes zero and consumer is not able to retrieve pci data.
> >
> > Signed-off-by: Damjan Marion <damarion@cisco.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Will add below fix line when apply
> Fixes: 4861cde46116 ("i40e: new poll mode driver")

Applied to dpdk-next-net-intel

Thanks!
Qi
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 804e44530..86b38d202 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2182,7 +2182,6 @@  i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
 	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-	memset(dev_info, 0, sizeof(*dev_info));
 	dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->min_rx_bufsize = I40E_BUF_SIZE_MIN;