diff mbox

[dpdk-dev,2/2] pci: remove unused function prototype

Message ID 20180521164150.24252-3-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger May 21, 2018, 4:41 p.m. UTC 
  Prototype for pci_unbind_kernel_driver exists but no code.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/bus/pci/private.h | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Gaëtan Rivet May 22, 2018, 9 a.m. UTC | #1 
On Mon, May 21, 2018 at 09:41:50AM -0700, Stephen Hemminger wrote:
> Prototype for pci_unbind_kernel_driver exists but no code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  drivers/bus/pci/private.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h
> index 02e2fb44367f..680879ed35a2 100644
> --- a/drivers/bus/pci/private.h
> +++ b/drivers/bus/pci/private.h
> @@ -106,16 +106,6 @@ void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev,
>   */
>  int pci_update_device(const struct rte_pci_addr *addr);
>  
> -/**
> - * Unbind kernel driver for this device
> - *
> - * This function is private to EAL.
> - *
> - * @return
> - *   0 on success, negative on error
> - */
> -int pci_unbind_kernel_driver(struct rte_pci_device *dev);
> -
>  /**
>   * Map the PCI resource of a PCI device in virtual memory
>   *
> -- 
> 2.17.0
>
Thomas Monjalon June 27, 2018, 4:37 p.m. UTC | #2 
22/05/2018 11:00, Gaëtan Rivet:
> On Mon, May 21, 2018 at 09:41:50AM -0700, Stephen Hemminger wrote:
> > Prototype for pci_unbind_kernel_driver exists but no code.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

It was a leftover of an old incomplete cleanup.

Applied, thanks
diff mbox

Patch

diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h
index 02e2fb44367f..680879ed35a2 100644
--- a/drivers/bus/pci/private.h
+++ b/drivers/bus/pci/private.h
@@ -106,16 +106,6 @@  void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev,
  */
 int pci_update_device(const struct rte_pci_addr *addr);
 
-/**
- * Unbind kernel driver for this device
- *
- * This function is private to EAL.
- *
- * @return
- *   0 on success, negative on error
- */
-int pci_unbind_kernel_driver(struct rte_pci_device *dev);
-
 /**
  * Map the PCI resource of a PCI device in virtual memory
  *