diff mbox

[dpdk-dev] net/i40e: fix flow RSS tci using error

Message ID 1522735776-27118-1-git-send-email-wei.zhao1@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Zhao1, Wei April 3, 2018, 6:09 a.m. UTC 
  Vlan tci configuration from testpmd is store in big endian, so it
need to be change to little endian before using.

Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Qi Zhang April 3, 2018, 2:03 p.m. UTC | #1 
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, April 3, 2018 2:10 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS tci using error
> 
> Vlan tci configuration from testpmd is store in big endian, so it need to be
> change to little endian before using.
> 
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Please don't forget to Cc: stable@dpdk.org, if you fix an issue for previous release.

Regards
Qi

> ---
>  drivers/net/i40e/i40e_flow.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> fa562d3..8d0a36b 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4151,7 +4151,8 @@ i40e_flow_parse_rss_pattern(__rte_unused struct
> rte_eth_dev *dev,
>  				if (vlan_mask->tci ==
>  					rte_cpu_to_be_16(I40E_TCI_MASK)) {
>  					info->region[0].user_priority[0] =
> -						(vlan_spec->tci >> 13) & 0x7;
> +						(rte_be_to_cpu_16(
> +						vlan_spec->tci) >> 13) & 0x7;
>  					info->region[0].user_priority_num = 1;
>  					info->queue_region_number = 1;
>  					*action_flag = 0;
> --
> 2.7.5
Zhang, Helin April 3, 2018, 3:17 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Tuesday, April 3, 2018 10:03 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, April 3, 2018 2:10 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS tci using error
> >
> > Vlan tci configuration from testpmd is store in big endian, so it need
> > to be change to little endian before using.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
Zhao1, Wei April 4, 2018, 1:29 a.m. UTC | #3 
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, April 3, 2018 10:03 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] net/i40e: fix flow RSS tci using error
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, April 3, 2018 2:10 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS tci using error
> >
> > Vlan tci configuration from testpmd is store in big endian, so it need
> > to be change to little endian before using.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Please don't forget to Cc: stable@dpdk.org, if you fix an issue for previous
> release.

Ok.

> 
> Regards
> Qi
> 
> > ---
> >  drivers/net/i40e/i40e_flow.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index fa562d3..8d0a36b 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4151,7 +4151,8 @@ i40e_flow_parse_rss_pattern(__rte_unused
> struct
> > rte_eth_dev *dev,
> >  				if (vlan_mask->tci ==
> >  					rte_cpu_to_be_16(I40E_TCI_MASK))
> {
> >  					info->region[0].user_priority[0] =
> > -						(vlan_spec->tci >> 13) & 0x7;
> > +						(rte_be_to_cpu_16(
> > +						vlan_spec->tci) >> 13) & 0x7;
> >  					info->region[0].user_priority_num =
> 1;
> >  					info->queue_region_number = 1;
> >  					*action_flag = 0;
> > --
> > 2.7.5
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index fa562d3..8d0a36b 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4151,7 +4151,8 @@  i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
 				if (vlan_mask->tci ==
 					rte_cpu_to_be_16(I40E_TCI_MASK)) {
 					info->region[0].user_priority[0] =
-						(vlan_spec->tci >> 13) & 0x7;
+						(rte_be_to_cpu_16(
+						vlan_spec->tci) >> 13) & 0x7;
 					info->region[0].user_priority_num = 1;
 					info->queue_region_number = 1;
 					*action_flag = 0;