[dpdk-dev] net/dpaa2: remove unused global variable

Message ID 20180210115736.7107-1-jerin.jacob@caviumnetworks.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Jerin Jacob Feb. 10, 2018, 11:57 a.m.
Due to the missing __packed definition, compiler treating
it as as global variable.

#grep "Allocating common symbols" -A 100 build/app/testacl.map
__packed   0x8  /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o)

Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing")

Cc: hemant.agrawal@nxp.com
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hemant Agrawal Feb. 10, 2018, 12:02 p.m. | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, February 10, 2018 5:28 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable
> Importance: High
> 
> Due to the missing __packed definition, compiler treating it as as global variable.

> 
> #grep "Allocating common symbols" -A 100 build/app/testacl.map
> __packed   0x8  /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o)

[Hemant] Which compiler, you mean you faced issue with testacl app? 

> 
> Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing")
> 
> Cc: hemant.agrawal@nxp.com
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

<snip>....
Jerin Jacob Feb. 10, 2018, 12:44 p.m. | #2
-----Original Message-----
> Date: Sat, 10 Feb 2018 12:02:24 +0000
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
>  <dev@dpdk.org>
> Subject: RE: [dpdk-dev]  [PATCH] net/dpaa2: remove unused global variable
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> > Sent: Saturday, February 10, 2018 5:28 PM
> > To: dev@dpdk.org
> > Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>
> > Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable
> > Importance: High
> > 
> > Due to the missing __packed definition, compiler treating it as as global variable.
> 
> > 
> > #grep "Allocating common symbols" -A 100 build/app/testacl.map
> > __packed   0x8  /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o)
> 
> [Hemant] Which compiler, you mean you faced issue with testacl app? 

arm64 gcc. Not specific to testacl. We were getting minor performance
regression (<1%) with l3fwd after the following change set.
http://dpdk.org/dev/patchwork/patch/34709/

I don't think, the above change set directly has anything due to issue.
I was chasing that issue and found that global variables has something
due to with change.Most probably because it has indirect effect of changing
the complete address generated in the binary and thus showing up some cached
alignment related artifacts.

> 
> > 
> > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing")
> > 
> > Cc: hemant.agrawal@nxp.com
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> <snip>....
Thomas Monjalon Feb. 13, 2018, 3:35 p.m. | #3
> > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing")
> > 
> > Cc: hemant.agrawal@nxp.com
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied, thanks

Patch

diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h b/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h
index 41931e858..779cdf2b2 100644
--- a/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h
+++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h
@@ -37,7 +37,7 @@  struct dpaa2_fas {
 	uint8_t ppid;
 	__le16 ifpid;
 	__le32 status;
-} __packed;
+}  __attribute__((__packed__));
 
 /**
  * HW Packet Annotation  Register structures