[dpdk-dev,v2] app/testpmd:vlan filter fail

Message ID 20180205023357.104418-1-yanglong.wu@intel.com
State Superseded, archived
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Yanglong Wu Feb. 5, 2018, 2:33 a.m.
This bug is caused by miss port configuration.
The port_conf for the DCB configuration should
inherit the same configuration of the port.

Fix:0074d02fc(convert to new Rx offloads API)
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
changing patch accoding to the review
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shahaf Shuler Feb. 5, 2018, 6:14 a.m. | #1
Hi Wu,

Few small comment. 

Monday, February 5, 2018 4:34 AM, Yanglong Wu:
> Subject: [PATCH v2] app/testpmd:vlan filter fail

The commit title can better describe the patch, something like: "app/testpmd: fix port DCB configuration"

> 
> This bug is caused by miss port configuration.

The above line is not needed. 

> The port_conf for the DCB configuration should inherit the same
> configuration of the port.
> 
> Fix:0074d02fc(convert to new Rx offloads API)

It needs to be :

Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")

> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v2:
> changing patch accoding to the review
> ---
>  app/test-pmd/testpmd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 5dc8ccac5..da1d9bd3a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid,
>  	/* Enter DCB configuration status */
>  	dcb_config = 1;
> 
> +	port_conf.rxmode = rte_port->dev_conf.rxmode;
> +	port_conf.txmode = rte_port->dev_conf.txmode;
> +
>  	/*set configuration of DCB in vt mode and DCB in non-vt mode*/
>  	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs,
> pfc_en);
>  	if (retval < 0)
> --

Otherwise  - Acked-by: Shahaf Shuler <shahafs@mellanox.com>

> 2.11.0
Yanglong Wu Feb. 5, 2018, 7:36 a.m. | #2
Thx! I will change it right now

-----Original Message-----
From: Shahaf Shuler [mailto:shahafs@mellanox.com] 
Sent: Monday, February 5, 2018 2:14 PM
To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
Subject: RE: [PATCH v2] app/testpmd:vlan filter fail

Hi Wu,

Few small comment. 

Monday, February 5, 2018 4:34 AM, Yanglong Wu:
> Subject: [PATCH v2] app/testpmd:vlan filter fail

The commit title can better describe the patch, something like: "app/testpmd: fix port DCB configuration"

> 
> This bug is caused by miss port configuration.

The above line is not needed. 

> The port_conf for the DCB configuration should inherit the same 
> configuration of the port.
> 
> Fix:0074d02fc(convert to new Rx offloads API)

It needs to be :

Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")

> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v2:
> changing patch accoding to the review
> ---
>  app/test-pmd/testpmd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 
> 5dc8ccac5..da1d9bd3a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid,
>  	/* Enter DCB configuration status */
>  	dcb_config = 1;
> 
> +	port_conf.rxmode = rte_port->dev_conf.rxmode;
> +	port_conf.txmode = rte_port->dev_conf.txmode;
> +
>  	/*set configuration of DCB in vt mode and DCB in non-vt mode*/
>  	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);
>  	if (retval < 0)
> --

Otherwise  - Acked-by: Shahaf Shuler <shahafs@mellanox.com>

> 2.11.0

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5dc8ccac5..da1d9bd3a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2324,6 +2324,9 @@  init_port_dcb_config(portid_t pid,
 	/* Enter DCB configuration status */
 	dcb_config = 1;

+	port_conf.rxmode = rte_port->dev_conf.rxmode;
+	port_conf.txmode = rte_port->dev_conf.txmode;
+
 	/*set configuration of DCB in vt mode and DCB in non-vt mode*/
 	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);
 	if (retval < 0)