[dpdk-dev,v2] net/bnxt: Fix to set timestamp flag

Message ID 20180202023858.27124-1-somnath.kotur@broadcom.com
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Somnath Kotur Feb. 2, 2018, 2:38 a.m.
The timestamp flag needed to be set in the offload flags
for the received pkt in case of PTP offload

Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
v1->v2: Trimmed subject line and added content in commit log
 drivers/net/bnxt/bnxt_rxr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Feb. 5, 2018, 4:09 p.m. | #1
On 2/2/2018 2:38 AM, Somnath Kotur wrote:
> The timestamp flag needed to be set in the offload flags
> for the received pkt in case of PTP offload

Hi Somnath,

Can you please add a fixes line?

> 
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> ---
> v1->v2: Trimmed subject line and added content in commit log
>  drivers/net/bnxt/bnxt_rxr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 82c93d6..430990d 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -459,7 +459,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
>  
>  	if ((rxcmp->flags_type & rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_MASK)) ==
>  	     RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)
> -		mbuf->ol_flags |= PKT_RX_IEEE1588_PTP;
> +		mbuf->ol_flags |= PKT_RX_IEEE1588_PTP | PKT_RX_IEEE1588_TMST;
>  
>  	if (agg_buf)
>  		bnxt_rx_pages(rxq, mbuf, &tmp_raw_cons, agg_buf);
>

Patch

diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 82c93d6..430990d 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -459,7 +459,7 @@  static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
 
 	if ((rxcmp->flags_type & rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_MASK)) ==
 	     RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)
-		mbuf->ol_flags |= PKT_RX_IEEE1588_PTP;
+		mbuf->ol_flags |= PKT_RX_IEEE1588_PTP | PKT_RX_IEEE1588_TMST;
 
 	if (agg_buf)
 		bnxt_rx_pages(rxq, mbuf, &tmp_raw_cons, agg_buf);