[dpdk-dev] examples/bbdev: fix out-of-bounds access

Message ID 1517408374-131055-1-git-send-email-amr.mokhtar@intel.com
State Accepted, archived
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Mokhtar, Amr Jan. 31, 2018, 2:19 p.m.
eth_address was improperly accessed in bbdev example
app, this patch removes the use of port_id, it is
irrelevant here.

Coverity issue: 257021
Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app")

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
---
 examples/bbdev_app/main.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Thomas Monjalon Jan. 31, 2018, 5:27 p.m. | #1
31/01/2018 15:19, Amr Mokhtar:
> eth_address was improperly accessed in bbdev example
> app, this patch removes the use of port_id, it is
> irrelevant here.
> 
> Coverity issue: 257021
> Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app")
> 
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>

Applied, thanks

Patch

diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c
index 2e5bd8c..a2835a4 100644
--- a/examples/bbdev_app/main.c
+++ b/examples/bbdev_app/main.c
@@ -282,12 +282,12 @@  print_mac(unsigned int portid, struct ether_addr *bbdev_ports_eth_address)
 {
 	printf("Port %u, MAC address: %02X:%02X:%02X:%02X:%02X:%02X\n\n",
 			(unsigned int) portid,
-			bbdev_ports_eth_address[portid].addr_bytes[0],
-			bbdev_ports_eth_address[portid].addr_bytes[1],
-			bbdev_ports_eth_address[portid].addr_bytes[2],
-			bbdev_ports_eth_address[portid].addr_bytes[3],
-			bbdev_ports_eth_address[portid].addr_bytes[4],
-			bbdev_ports_eth_address[portid].addr_bytes[5]);
+			bbdev_ports_eth_address->addr_bytes[0],
+			bbdev_ports_eth_address->addr_bytes[1],
+			bbdev_ports_eth_address->addr_bytes[2],
+			bbdev_ports_eth_address->addr_bytes[3],
+			bbdev_ports_eth_address->addr_bytes[4],
+			bbdev_ports_eth_address->addr_bytes[5]);
 }
 
 static inline void