From patchwork Wed Jan 31 11:15:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rybalchenko, Kirill" X-Patchwork-Id: 34762 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D41D1B77C; Wed, 31 Jan 2018 12:15:17 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7C2291B755; Wed, 31 Jan 2018 12:15:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 03:15:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,439,1511856000"; d="scan'208";a="200214372" Received: from silpixa00389036.ir.intel.com (HELO silpixa00389036.ger.corp.intel.com) ([10.237.223.231]) by fmsmga006.fm.intel.com with ESMTP; 31 Jan 2018 03:15:10 -0800 From: Kirill Rybalchenko To: dev@dpdk.org Cc: stable@dpdk.org, kirill.rybalchenko@intel.com, andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com Date: Wed, 31 Jan 2018 11:15:06 +0000 Message-Id: <1517397306-20440-1-git-send-email-kirill.rybalchenko@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH] doc: fix documentation for testpmd ddp add del function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Documentation and help string more clear describe meaning of arguments for ddp add del function. Fixes: 856ceb331b0a ("app/testpmd: enable DDP remove profile feature") Signed-off-by: Kirill Rybalchenko Acked-by: John McNamara --- app/test-pmd/cmdline.c | 8 ++++---- doc/guides/nics/i40e.rst | 8 ++++---- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 9f12c0f..314386e 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -671,10 +671,10 @@ static void cmd_help_long_parsed(void *parsed_result, " Set default traffic Management hierarchy on a port\n\n" #endif - "ddp add (port_id) (profile_path[,output_path])\n" + "ddp add (port_id) (profile_path[,backup_profile_path])\n" " Load a profile package on a port\n\n" - "ddp del (port_id) (profile_path)\n" + "ddp del (port_id) (backup_profile_path)\n" " Delete a profile package from a port\n\n" "ptype mapping get (port_id) (valid_only)\n" @@ -14488,7 +14488,7 @@ cmd_ddp_add_parsed( cmdline_parse_inst_t cmd_ddp_add = { .f = cmd_ddp_add_parsed, .data = NULL, - .help_str = "ddp add ", + .help_str = "ddp add ", .tokens = { (void *)&cmd_ddp_add_ddp, (void *)&cmd_ddp_add_add, @@ -14558,7 +14558,7 @@ cmd_ddp_del_parsed( cmdline_parse_inst_t cmd_ddp_del = { .f = cmd_ddp_del_parsed, .data = NULL, - .help_str = "ddp del ", + .help_str = "ddp del ", .tokens = { (void *)&cmd_ddp_del_ddp, (void *)&cmd_ddp_del_del, diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 50d5e36..b57c10d 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -394,17 +394,17 @@ The DDP functionality requires a NIC firmware version of 6.0 or greater. Current implementation supports MPLSoUDP/MPLSoGRE/GTP-C/GTP-U/PPPoE/PPPoL2TP, steering can be used with rte_flow API. -Load a profile which supports MPLSoUDP/MPLSoGRE: +Load a profile which supports MPLSoUDP/MPLSoGRE and store backup profile: .. code-block:: console - testpmd> ddp add 0 ./mpls.pkgo + testpmd> ddp add 0 ./mpls.pkgo,./backup.pkgo -Delete a MPLS profile: +Delete a MPLS profile and restore backup profile: .. code-block:: console - testpmd> ddp del 0 ./mpls.pkgo + testpmd> ddp del 0 ./backup.pkgo Get loaded DDP package info list: diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index d8c9ef0..39650d8 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1404,16 +1404,16 @@ Delete an E-tag forwarding filter on a port:: ddp add ~~~~~~~ -Load a dynamic device personalization (DDP) package:: +Load a dynamic device personalization (DDP) profile and store backup profile:: - testpmd> ddp add (port_id) (package_path[,output_path]) + testpmd> ddp add (port_id) (profile_path[,backup_profile_path]) ddp del ~~~~~~~ -Delete a dynamic device personalization package:: +Delete a dynamic device personalization profile and restore backup profile:: - testpmd> ddp del (port_id) (package_path) + testpmd> ddp del (port_id) (backup_profile_path) ptype mapping ~~~~~~~~~~~~~