diff mbox

[dpdk-dev] igb_uio: change the irq print type.

Message ID 1516724254-109282-1-git-send-email-xiangxia.m.yue@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Tonghao Zhang Jan. 23, 2018, 4:17 p.m. UTC 
  From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

The kernel uses the '%d' or '%ld' to print irq num.
But igb_uio may use the '%lx', then the log may confuse
the user what irq num has been used. The log is show as
below.

igb_uio 0000:00:03.0: irq 24 for MSI/MSI-X
igb_uio 0000:00:03.0: uio device registered with irq 18

kernel version: 3.10.0-514.16.1.el7

For avoiding to be confused, change the igb_uio irq
print type.

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
 lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Feb. 5, 2018, 11:17 p.m. UTC | #1 
23/01/2018 17:17, xiangxia.m.yue@gmail.com:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> The kernel uses the '%d' or '%ld' to print irq num.
> But igb_uio may use the '%lx', then the log may confuse
> the user what irq num has been used. The log is show as
> below.
> 
> igb_uio 0000:00:03.0: irq 24 for MSI/MSI-X
> igb_uio 0000:00:03.0: uio device registered with irq 18
> 
> kernel version: 3.10.0-514.16.1.el7
> 
> For avoiding to be confused, change the igb_uio irq
> print type.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index a3a98c1..81e44b5 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -299,7 +299,7 @@  struct rte_uio_pci_dev {
 		err = request_irq(udev->info.irq, igbuio_pci_irqhandler,
 				  udev->info.irq_flags, udev->info.name,
 				  udev);
-	dev_info(&udev->pdev->dev, "uio device registered with irq %lx\n",
+	dev_info(&udev->pdev->dev, "uio device registered with irq %ld\n",
 		 udev->info.irq);
 
 	return err;