diff mbox

[dpdk-dev] net/i40e: add break case in flow API

Message ID 20180112061332.63874-1-wei.zhao1@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Zhao1, Wei Jan. 12, 2018, 6:13 a.m. UTC 
  This bug may cause build error when there is no break
case code, so add it.

Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Qi Zhang Jan. 12, 2018, 6:47 a.m. UTC | #1 
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, January 12, 2018 2:14 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: add break case in flow API
> 
> This bug may cause build error when there is no break case code, so add it.
> 
> Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API")
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/i40e/i40e_flow.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 6106f78..cd9a9b6 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
>  	case RTE_ETH_FILTER_HASH:
>  		ret = i40e_config_rss_filter_del(dev,
>  			   (struct i40e_rte_flow_rss_conf *)flow->rule);
> +		break;
>  	default:
>  		PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
>  			    filter_type);
> --
> 2.9.3

Thanks Ferruh's capture.

Acked by: Qi Zhang <qi.z.zhang@intel.com>
Zhang, Helin Jan. 13, 2018, 5:55 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Friday, January 12, 2018 2:48 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Yigit, Ferruh
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, January 12, 2018 2:14 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: add break case in flow API
> >
> > This bug may cause build error when there is no break case code, so add it.
> >
> > Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  drivers/net/i40e/i40e_flow.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index
> > 6106f78..cd9a9b6 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> >  	case RTE_ETH_FILTER_HASH:
> >  		ret = i40e_config_rss_filter_del(dev,
> >  			   (struct i40e_rte_flow_rss_conf *)flow->rule);
> > +		break;
> >  	default:
> >  		PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> >  			    filter_type);
> > --
> > 2.9.3
> 
> Thanks Ferruh's capture.
> 
> Acked by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 6106f78..cd9a9b6 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4600,6 +4600,7 @@  i40e_flow_destroy(struct rte_eth_dev *dev,
 	case RTE_ETH_FILTER_HASH:
 		ret = i40e_config_rss_filter_del(dev,
 			   (struct i40e_rte_flow_rss_conf *)flow->rule);
+		break;
 	default:
 		PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
 			    filter_type);