diff mbox

[dpdk-dev,v3,34/39] examples/flow_filtering: convert to new ethdev offloads API

Message ID 6a91e2e8451eedea1db8a3486c4208b59c225a95.1514280005.git.shahafs@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shahaf Shuler Dec. 26, 2017, 9:23 a.m. UTC 
  Ethdev offloads API has changed since:

commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")

This commit support the new API.

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 examples/flow_filtering/main.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

Comments

Ori Kam Dec. 26, 2017, 1:57 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 11:24 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 34/39] examples/flow_filtering: convert to
> new ethdev offloads API
> 
> Ethdev offloads API has changed since:
> 
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit
> cba7f53b717d ("ethdev: introduce Tx queue offloads API")
> 
> This commit support the new API.
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  examples/flow_filtering/main.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index 7d739b4ae..f534f0639 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -138,18 +138,12 @@ init_port(void)
>  	struct rte_eth_conf port_conf = {
>  		.rxmode = {
>  			.split_hdr_size = 0,
> -			/**< Header Split disabled */
> -			.header_split   = 0,
> -			/**< IP checksum offload disabled */
> -			.hw_ip_checksum = 0,
> -			/**< VLAN filtering disabled */
> -			.hw_vlan_filter = 0,
> -			/**< Jumbo Frame Support disabled */
> -			.jumbo_frame    = 0,
> -			/**< CRC stripped by hardware */
> -			.hw_strip_crc   = 1,
> +			.ignore_offload_bitfield = 1,
> +			.offloads = DEV_RX_OFFLOAD_CRC_STRIP,
>  		},
>  	};
> +	struct rte_eth_rxconf rxq_conf;
> +	struct rte_eth_dev_info dev_info;
> 
>  	printf(":: initializing port: %d\n", port_id);
>  	ret = rte_eth_dev_configure(port_id,
> @@ -160,11 +154,14 @@ init_port(void)
>  			ret, port_id);
>  	}
> 
> +	rte_eth_dev_info_get(port_id, &dev_info);
> +	rxq_conf = dev_info.default_rxconf;
> +	rxq_conf.offloads = port_conf.rxmode.offloads;
>  	/* only set Rx queues: something we care only so far */
>  	for (i = 0; i < nr_queues; i++) {
>  		ret = rte_eth_rx_queue_setup(port_id, i, 512,
>  				     rte_eth_dev_socket_id(port_id),
> -				     NULL,
> +				     &rxq_conf,
>  				     mbuf_pool);
>  		if (ret < 0) {
>  			rte_exit(EXIT_FAILURE,
> --
> 2.12.0

Acked-by: Ori Kam <orika@mellanox.com>
diff mbox

Patch

diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index 7d739b4ae..f534f0639 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -138,18 +138,12 @@  init_port(void)
 	struct rte_eth_conf port_conf = {
 		.rxmode = {
 			.split_hdr_size = 0,
-			/**< Header Split disabled */
-			.header_split   = 0,
-			/**< IP checksum offload disabled */
-			.hw_ip_checksum = 0,
-			/**< VLAN filtering disabled */
-			.hw_vlan_filter = 0,
-			/**< Jumbo Frame Support disabled */
-			.jumbo_frame    = 0,
-			/**< CRC stripped by hardware */
-			.hw_strip_crc   = 1,
+			.ignore_offload_bitfield = 1,
+			.offloads = DEV_RX_OFFLOAD_CRC_STRIP,
 		},
 	};
+	struct rte_eth_rxconf rxq_conf;
+	struct rte_eth_dev_info dev_info;
 
 	printf(":: initializing port: %d\n", port_id);
 	ret = rte_eth_dev_configure(port_id,
@@ -160,11 +154,14 @@  init_port(void)
 			ret, port_id);
 	}
 
+	rte_eth_dev_info_get(port_id, &dev_info);
+	rxq_conf = dev_info.default_rxconf;
+	rxq_conf.offloads = port_conf.rxmode.offloads;
 	/* only set Rx queues: something we care only so far */
 	for (i = 0; i < nr_queues; i++) {
 		ret = rte_eth_rx_queue_setup(port_id, i, 512,
 				     rte_eth_dev_socket_id(port_id),
-				     NULL,
+				     &rxq_conf,
 				     mbuf_pool);
 		if (ret < 0) {
 			rte_exit(EXIT_FAILURE,