[dpdk-dev] cryptodev: Fix typo in qat.rst

Message ID 1511781216-2819-1-git-send-email-billy.o.mahony@intel.com
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Billy O'Mahony Nov. 27, 2017, 11:13 a.m.
Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
---
 doc/guides/cryptodevs/qat.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo Nov. 27, 2017, 11:20 a.m. | #1
> -----Original Message-----
> From: O Mahony, Billy
> Sent: Monday, November 27, 2017 11:14 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: [PATCH] cryptodev: Fix typo in qat.rst
> 
> Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> ---
>  doc/guides/cryptodevs/qat.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index cb17b6b..c8ef378 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions
> (VFs) using the sysfs file system  First find the BDFs (Bus-Device-Function) of
> the physical functions (PFs) of  your device, e.g.::
> 
> -    lspci -d : 37c8
> +    lspci -d:37c8
> 
>  You should see output similar to::
> 
> --
> 2.7.4

Hi Billy,

Since this is a patch for documentation, the title should start with "doc:",
as "cryptodev: ..." suggests that the patch is fixing something in the library code.

I will fix it for you, since the rest of the patch looks ok to me.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Billy O'Mahony Nov. 27, 2017, 3:33 p.m. | #2
Thanks, Pablo. Will remember for future ref.

Cheers,
Billy

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, November 27, 2017 11:20 AM
> To: O Mahony, Billy <billy.o.mahony@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] cryptodev: Fix typo in qat.rst
> 
> 
> 
> > -----Original Message-----
> > From: O Mahony, Billy
> > Sent: Monday, November 27, 2017 11:14 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > dev@dpdk.org
> > Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> > Subject: [PATCH] cryptodev: Fix typo in qat.rst
> >
> > Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> > ---
> >  doc/guides/cryptodevs/qat.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index cb17b6b..c8ef378 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions
> > (VFs) using the sysfs file system  First find the BDFs
> > (Bus-Device-Function) of the physical functions (PFs) of  your device, e.g.::
> >
> > -    lspci -d : 37c8
> > +    lspci -d:37c8
> >
> >  You should see output similar to::
> >
> > --
> > 2.7.4
> 
> Hi Billy,
> 
> Since this is a patch for documentation, the title should start with "doc:", as
> "cryptodev: ..." suggests that the patch is fixing something in the library code.
> 
> I will fix it for you, since the rest of the patch looks ok to me.
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo Dec. 11, 2017, 10:40 a.m. | #3
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Monday, November 27, 2017 11:20 AM
> To: O Mahony, Billy <billy.o.mahony@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
> 
> 
> 
> > -----Original Message-----
> > From: O Mahony, Billy
> > Sent: Monday, November 27, 2017 11:14 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > dev@dpdk.org
> > Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> > Subject: [PATCH] cryptodev: Fix typo in qat.rst
> >
> > Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> > ---
> >  doc/guides/cryptodevs/qat.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index cb17b6b..c8ef378 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -166,7 +166,7 @@ Next, you need to expose the Virtual Functions
> > (VFs) using the sysfs file system  First find the BDFs
> > (Bus-Device-Function) of the physical functions (PFs) of  your device, e.g.::
> >
> > -    lspci -d : 37c8
> > +    lspci -d:37c8
> >
> >  You should see output similar to::
> >
> > --
> > 2.7.4
> 
> Hi Billy,
> 
> Since this is a patch for documentation, the title should start with "doc:", as
> "cryptodev: ..." suggests that the patch is fixing something in the library
> code.
> 
> I will fix it for you, since the rest of the patch looks ok to me.
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

Patch

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index cb17b6b..c8ef378 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -166,7 +166,7 @@  Next, you need to expose the Virtual Functions (VFs) using the sysfs file system
 First find the BDFs (Bus-Device-Function) of the physical functions (PFs) of
 your device, e.g.::
 
-    lspci -d : 37c8
+    lspci -d:37c8
 
 You should see output similar to::