[dpdk-dev,2/5] app/testpmd: remove txqflags

Message ID 20171123120804.143897-3-shahafs@mellanox.com
State Superseded, archived
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Shahaf Shuler Nov. 23, 2017, 12:08 p.m.
Since testpmd is now using the new Ethdev offloads API there is no
need for the txqflags configuration.

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 app/test-pmd/cmdline.c                      | 69 ------------------------
 app/test-pmd/config.c                       |  4 +-
 app/test-pmd/parameters.c                   | 14 +----
 app/test-pmd/testpmd.c                      |  8 ---
 app/test-pmd/testpmd.h                      |  1 -
 doc/guides/testpmd_app_ug/run_app.rst       | 12 -----
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 ----
 7 files changed, 2 insertions(+), 117 deletions(-)

Comments

Ferruh Yigit Dec. 4, 2017, 10:31 p.m. | #1
On 11/23/2017 4:08 AM, Shahaf Shuler wrote:
> Since testpmd is now using the new Ethdev offloads API there is no
> need for the txqflags configuration.

txqflag command-line option (--txqflags=0xXXXXXXXX) and command (port config all
txqflags value) are way to dynamically provide Tx offload configuration to testpmd.

Why you are removing them without providing equivalent feature with new offload
APIs?

Patch 3/4 & 4/5 adds new command-line options to enable some of recently
introduced Tx offloads in testpmd, why not add a generic way to update all Tx
offloads instead of those two specific offloads?

Also this patch removing ability to display current Tx offload configuration....

> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

<...>
Shahaf Shuler Dec. 5, 2017, 6:48 a.m. | #2
Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit:
> On 11/23/2017 4:08 AM, Shahaf Shuler wrote:

> > Since testpmd is now using the new Ethdev offloads API there is no

> > need for the txqflags configuration.

> 

> txqflag command-line option (--txqflags=0xXXXXXXXX) and command (port

> config all txqflags value) are way to dynamically provide Tx offload

> configuration to testpmd.

> 

> Why you are removing them without providing equivalent feature with new

> offload APIs?


There is one, and this is why the new offloads API simplifies applications life. 
The txq_flags were introduced so application can disable some of the Tx offloads from the time the Tx offloads were set by default.

Now the Tx offloads are all disabled by default. And there is an option to set each one of the using DEV_TX_OFFLOAD_* flags.
Look on the Rx side (there the Rx offloads were disabled by default in the old API). there is no rxq_flags. 

> 

> Patch 3/4 & 4/5 adds new command-line options to enable some of recently

> introduced Tx offloads in testpmd, why not add a generic way to update all

> Tx offloads instead of those two specific offloads?


Because those 2 new offloads were missing a way to set in testpmd.
The rest of the offloads can be set using the CLI commands exists today.

Am not sure we want every Tx offloads to be set from both CLI and command line arguments.
It wasn't before (for example there was no --disable-tso flags). 

> 

> Also this patch removing ability to display current Tx offload configuration....


Can you point where ?

> 

> >

> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

> > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> 

> <...>
Ferruh Yigit Dec. 6, 2017, 11:04 p.m. | #3
On 12/4/2017 10:48 PM, Shahaf Shuler wrote:
> Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit:
>> On 11/23/2017 4:08 AM, Shahaf Shuler wrote:
>>> Since testpmd is now using the new Ethdev offloads API there is no
>>> need for the txqflags configuration.
>>
>> txqflag command-line option (--txqflags=0xXXXXXXXX) and command (port
>> config all txqflags value) are way to dynamically provide Tx offload
>> configuration to testpmd.
>>
>> Why you are removing them without providing equivalent feature with new
>> offload APIs?
> 
> There is one, and this is why the new offloads API simplifies applications life. 
> The txq_flags were introduced so application can disable some of the Tx offloads from the time the Tx offloads were set by default.
> 
> Now the Tx offloads are all disabled by default. And there is an option to set each one of the using DEV_TX_OFFLOAD_* flags.
> Look on the Rx side (there the Rx offloads were disabled by default in the old API). there is no rxq_flags. 

I mean providing a testpmd command and command-line option.
Or am I missing it, after this update is there a way to update enabled Tx
offloads in testpmd via command and command-line?

> 
>>
>> Patch 3/4 & 4/5 adds new command-line options to enable some of recently
>> introduced Tx offloads in testpmd, why not add a generic way to update all
>> Tx offloads instead of those two specific offloads?
> 
> Because those 2 new offloads were missing a way to set in testpmd.
> The rest of the offloads can be set using the CLI commands exists today.
> 
> Am not sure we want every Tx offloads to be set from both CLI and command line arguments.
> It wasn't before (for example there was no --disable-tso flags). 

I was thinking a generic command-line instead of introducing one for all,
overall single variable represents all offload values, why not set it at once,
as --txqflags you are removing in this patch.

> 
>>
>> Also this patch removing ability to display current Tx offload configuration....
> 
> Can you point where ?

I mean following:

  -	printf("  TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n",
  -	       tx_conf->tx_rs_thresh, tx_conf->txq_flags);
  +	printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);

Why not an offloads replacement of this one?

> 
>>
>>>
>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>> <...>
>
Shahaf Shuler Dec. 7, 2017, 7:56 a.m. | #4
Thursday, December 7, 2017 1:05 AM, Ferruh Yigit:
> On 12/4/2017 10:48 PM, Shahaf Shuler wrote:

> > Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit:

> >> On 11/23/2017 4:08 AM, Shahaf Shuler wrote:

> >>> Since testpmd is now using the new Ethdev offloads API there is no

> >>> need for the txqflags configuration.

> >>

> >> txqflag command-line option (--txqflags=0xXXXXXXXX) and command

> (port

> >> config all txqflags value) are way to dynamically provide Tx offload

> >> configuration to testpmd.

> >>

> >> Why you are removing them without providing equivalent feature with

> >> new offload APIs?

> >

> > There is one, and this is why the new offloads API simplifies applications

> life.

> > The txq_flags were introduced so application can disable some of the Tx

> offloads from the time the Tx offloads were set by default.

> >

> > Now the Tx offloads are all disabled by default. And there is an option to

> set each one of the using DEV_TX_OFFLOAD_* flags.

> > Look on the Rx side (there the Rx offloads were disabled by default in the

> old API). there is no rxq_flags.

> 

> I mean providing a testpmd command and command-line option.

> Or am I missing it, after this update is there a way to update enabled Tx

> offloads in testpmd via command and command-line?


There is a way to update via CLI
For example when doing "tso set <mss> <port>" the DEV_TX_OFFLOAD_TSO will be set
When doing tx_vlan add <port> <vlan> the DEV_TX_OFFLOAD_VLAN_INSERT will be set
Same for every Tx offloads besides DEV_TX_OFFLOAD_MULTI_SEGS  and DEV_TX_OFFLOAD_MBUF_FAST_FREE which I added on separate patches. 

But to make it precise you didn’t had before (with the txq_flags) a way to disable TSO from the command line (the is no TXQ flag for that) nor the tunnel TSO. 

> 

> >

> >>

> >> Patch 3/4 & 4/5 adds new command-line options to enable some of

> >> recently introduced Tx offloads in testpmd, why not add a generic way

> >> to update all Tx offloads instead of those two specific offloads?

> >

> > Because those 2 new offloads were missing a way to set in testpmd.

> > The rest of the offloads can be set using the CLI commands exists today.

> >

> > Am not sure we want every Tx offloads to be set from both CLI and

> command line arguments.

> > It wasn't before (for example there was no --disable-tso flags).

> 

> I was thinking a generic command-line instead of introducing one for all,

> overall single variable represents all offload values, why not set it at once, as

> --txqflags you are removing in this patch.


We can do it. yes. 

> 

> >

> >>

> >> Also this patch removing ability to display current Tx offload

> configuration....

> >

> > Can you point where ?

> 

> I mean following:

> 

>   -	printf("  TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n",

>   -	       tx_conf->tx_rs_thresh, tx_conf->txq_flags);

>   +	printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);

> 

> Why not an offloads replacement of this one?


Will be added. 

> 

> >

> >>

> >>>

> >>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

> >>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> >>

> >> <...>

> >
Maciej Czekaj Dec. 12, 2017, 12:45 p.m. | #5
-- Oryginal message --
> Thursday, December 7, 2017 1:05 AM, Ferruh Yigit:
>> On 12/4/2017 10:48 PM, Shahaf Shuler wrote:
>>> Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit:
>>>> On 11/23/2017 4:08 AM, Shahaf Shuler wrote:
>>>>> Since testpmd is now using the new Ethdev offloads API there is no
>>>>> need for the txqflags configuration.
>>>> txqflag command-line option (--txqflags=0xXXXXXXXX) and command
>> (port
>>>> config all txqflags value) are way to dynamically provide Tx offload
>>>> configuration to testpmd.
>>>>
>>>> Why you are removing them without providing equivalent feature with
>>>> new offload APIs?
>>> There is one, and this is why the new offloads API simplifies applications
>> life.
>>> The txq_flags were introduced so application can disable some of the Tx
>> offloads from the time the Tx offloads were set by default.
>>> Now the Tx offloads are all disabled by default. And there is an option to
>> set each one of the using DEV_TX_OFFLOAD_* flags.
>>> Look on the Rx side (there the Rx offloads were disabled by default in the
>> old API). there is no rxq_flags.
>>
>> I mean providing a testpmd command and command-line option.
>> Or am I missing it, after this update is there a way to update enabled Tx
>> offloads in testpmd via command and command-line?
> There is a way to update via CLI
> For example when doing "tso set <mss> <port>" the DEV_TX_OFFLOAD_TSO will be set
> When doing tx_vlan add <port> <vlan> the DEV_TX_OFFLOAD_VLAN_INSERT will be set
> Same for every Tx offloads besides DEV_TX_OFFLOAD_MULTI_SEGS  and DEV_TX_OFFLOAD_MBUF_FAST_FREE which I added on separate patches.
>
> But to make it precise you didn’t had before (with the txq_flags) a way to disable TSO from the command line (the is no TXQ flag for that) nor the tunnel TSO.
>
>>>> Patch 3/4 & 4/5 adds new command-line options to enable some of
>>>> recently introduced Tx offloads in testpmd, why not add a generic way
>>>> to update all Tx offloads instead of those two specific offloads?
>>> Because those 2 new offloads were missing a way to set in testpmd.
>>> The rest of the offloads can be set using the CLI commands exists today.
>>>
>>> Am not sure we want every Tx offloads to be set from both CLI and
>> command line arguments.
>>> It wasn't before (for example there was no --disable-tso flags).
>> I was thinking a generic command-line instead of introducing one for all,
>> overall single variable represents all offload values, why not set it at once, as
>> --txqflags you are removing in this patch.
> We can do it. yes.

+1 for Ferruh. --txqflags argument was very handy in testing features in 
batch mode. Let us have something equivalent.

>
>>>> Also this patch removing ability to display current Tx offload
>> configuration....
>>> Can you point where ?
>> I mean following:
>>
>>    -	printf("  TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n",
>>    -	       tx_conf->tx_rs_thresh, tx_conf->txq_flags);
>>    +	printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);
>>
>> Why not an offloads replacement of this one?
> Will be added.
>
>>>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>>>>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>>> <...>
Shahaf Shuler Dec. 13, 2017, 7:25 a.m. | #6
>>      We can do it. yes.

>+1 for Ferruh. --txqflags argument was very handy in testing features in batch mode. Let us have something equivalent.


It is there. Checkout v2 of the series, an equivalent parameter was added: tx-offloads.


--Shahaf

From: Maciej Czekaj [mailto:maciej.czekaj@caviumnetworks.com]

Sent: Tuesday, December 12, 2017 2:45 PM
To: Shahaf Shuler <shahafs@mellanox.com>; Ferruh Yigit <ferruh.yigit@intel.com>; jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags



-- Oryginal message --

Thursday, December 7, 2017 1:05 AM, Ferruh Yigit:

On 12/4/2017 10:48 PM, Shahaf Shuler wrote:

Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit:

On 11/23/2017 4:08 AM, Shahaf Shuler wrote:

Since testpmd is now using the new Ethdev offloads API there is no

need for the txqflags configuration.



txqflag command-line option (--txqflags=0xXXXXXXXX) and command

(port

config all txqflags value) are way to dynamically provide Tx offload

configuration to testpmd.



Why you are removing them without providing equivalent feature with

new offload APIs?



There is one, and this is why the new offloads API simplifies applications

life.

The txq_flags were introduced so application can disable some of the Tx

offloads from the time the Tx offloads were set by default.



Now the Tx offloads are all disabled by default. And there is an option to

set each one of the using DEV_TX_OFFLOAD_* flags.

Look on the Rx side (there the Rx offloads were disabled by default in the

old API). there is no rxq_flags.



I mean providing a testpmd command and command-line option.

Or am I missing it, after this update is there a way to update enabled Tx

offloads in testpmd via command and command-line?



There is a way to update via CLI

For example when doing "tso set <mss> <port>" the DEV_TX_OFFLOAD_TSO will be set

When doing tx_vlan add <port> <vlan> the DEV_TX_OFFLOAD_VLAN_INSERT will be set

Same for every Tx offloads besides DEV_TX_OFFLOAD_MULTI_SEGS  and DEV_TX_OFFLOAD_MBUF_FAST_FREE which I added on separate patches.



But to make it precise you didn’t had before (with the txq_flags) a way to disable TSO from the command line (the is no TXQ flag for that) nor the tunnel TSO.









Patch 3/4 & 4/5 adds new command-line options to enable some of

recently introduced Tx offloads in testpmd, why not add a generic way

to update all Tx offloads instead of those two specific offloads?



Because those 2 new offloads were missing a way to set in testpmd.

The rest of the offloads can be set using the CLI commands exists today.



Am not sure we want every Tx offloads to be set from both CLI and

command line arguments.

It wasn't before (for example there was no --disable-tso flags).



I was thinking a generic command-line instead of introducing one for all,

overall single variable represents all offload values, why not set it at once, as

--txqflags you are removing in this patch.



We can do it. yes.

+1 for Ferruh. --txqflags argument was very handy in testing features in batch mode. Let us have something equivalent.













Also this patch removing ability to display current Tx offload

configuration....



Can you point where ?



I mean following:



  -       printf("  TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n",

  -              tx_conf->tx_rs_thresh, tx_conf->txq_flags);

  +       printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);



Why not an offloads replacement of this one?



Will be added.











Signed-off-by: Shahaf Shuler <shahafs@mellanox.com><mailto:shahafs@mellanox.com>


Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com><mailto:nelio.laranjeiro@6wind.com>




<...>

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b0f2325c8..9e3f02ec5 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3092,74 +3092,6 @@  cmdline_parse_inst_t cmd_set_txsplit = {
 	},
 };
 
-/* *** CONFIG TX QUEUE FLAGS *** */
-
-struct cmd_config_txqflags_result {
-	cmdline_fixed_string_t port;
-	cmdline_fixed_string_t config;
-	cmdline_fixed_string_t all;
-	cmdline_fixed_string_t what;
-	int32_t hexvalue;
-};
-
-static void cmd_config_txqflags_parsed(void *parsed_result,
-				__attribute__((unused)) struct cmdline *cl,
-				__attribute__((unused)) void *data)
-{
-	struct cmd_config_txqflags_result *res = parsed_result;
-
-	if (!all_ports_stopped()) {
-		printf("Please stop all ports first\n");
-		return;
-	}
-
-	if (strcmp(res->what, "txqflags")) {
-		printf("Unknown parameter\n");
-		return;
-	}
-
-	if (res->hexvalue >= 0) {
-		txq_flags = res->hexvalue;
-	} else {
-		printf("txqflags must be >= 0\n");
-		return;
-	}
-
-	init_port_config();
-
-	cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1);
-}
-
-cmdline_parse_token_string_t cmd_config_txqflags_port =
-	TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, port,
-				 "port");
-cmdline_parse_token_string_t cmd_config_txqflags_config =
-	TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, config,
-				 "config");
-cmdline_parse_token_string_t cmd_config_txqflags_all =
-	TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, all,
-				 "all");
-cmdline_parse_token_string_t cmd_config_txqflags_what =
-	TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, what,
-				 "txqflags");
-cmdline_parse_token_num_t cmd_config_txqflags_value =
-	TOKEN_NUM_INITIALIZER(struct cmd_config_txqflags_result,
-				hexvalue, INT32);
-
-cmdline_parse_inst_t cmd_config_txqflags = {
-	.f = cmd_config_txqflags_parsed,
-	.data = NULL,
-	.help_str = "port config all txqflags <value>",
-	.tokens = {
-		(void *)&cmd_config_txqflags_port,
-		(void *)&cmd_config_txqflags_config,
-		(void *)&cmd_config_txqflags_all,
-		(void *)&cmd_config_txqflags_what,
-		(void *)&cmd_config_txqflags_value,
-		NULL,
-	},
-};
-
 /* *** ADD/REMOVE ALL VLAN IDENTIFIERS TO/FROM A PORT VLAN RX FILTER *** */
 struct cmd_rx_vlan_filter_all_result {
 	cmdline_fixed_string_t rx_vlan;
@@ -15729,7 +15661,6 @@  cmdline_parse_ctx_t main_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_config_rx_mode_flag,
 	(cmdline_parse_inst_t *)&cmd_config_rss,
 	(cmdline_parse_inst_t *)&cmd_config_rxtx_queue,
-	(cmdline_parse_inst_t *)&cmd_config_txqflags,
 	(cmdline_parse_inst_t *)&cmd_config_rss_reta,
 	(cmdline_parse_inst_t *)&cmd_showport_reta,
 	(cmdline_parse_inst_t *)&cmd_config_burst,
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9b6ffeca9..089e9f4cf 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -417,7 +417,6 @@  tx_queue_infos_display(portid_t port_id, uint16_t queue_id)
 	printf("\nTX writeback threshold: %hhu", qinfo.conf.tx_thresh.wthresh);
 	printf("\nTX RS threshold: %hu", qinfo.conf.tx_rs_thresh);
 	printf("\nTX free threshold: %hu", qinfo.conf.tx_free_thresh);
-	printf("\nTX flags: %#x", qinfo.conf.txq_flags);
 	printf("\nTX deferred start: %s",
 		(qinfo.conf.tx_deferred_start != 0) ? "on" : "off");
 	printf("\nNumber of TXDs: %hu", qinfo.nb_desc);
@@ -1702,8 +1701,7 @@  rxtx_config_display(void)
 	printf("  TX threshold registers: pthresh=%d hthresh=%d wthresh=%d\n",
 	       tx_conf->tx_thresh.pthresh, tx_conf->tx_thresh.hthresh,
 	       tx_conf->tx_thresh.wthresh);
-	printf("  TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n",
-	       tx_conf->tx_rs_thresh, tx_conf->txq_flags);
+	printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);
 }
 
 void
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 0ba73cad5..1a145c387 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -99,7 +99,7 @@  usage(char* progname)
 	       "--rss-ip | --rss-udp | "
 	       "--rxpt= | --rxht= | --rxwt= | --rxfreet= | "
 	       "--txpt= | --txht= | --txwt= | --txfreet= | "
-	       "--txrst= | --txqflags= ]\n",
+	       "--txrst= ]\n",
 	       progname);
 #ifdef RTE_LIBRTE_CMDLINE
 	printf("  --interactive: run in interactive mode.\n");
@@ -192,8 +192,6 @@  usage(char* progname)
 	       "(0 <= N <= value of txd).\n");
 	printf("  --txrst=N: set the transmit RS bit threshold of TX rings to N "
 	       "(0 <= N <= value of txd).\n");
-	printf("  --txqflags=0xXXXXXXXX: hexadecimal bitmask of TX queue flags "
-	       "(0 <= N <= 0x7FFFFFFF).\n");
 	printf("  --tx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping]: "
 	       "tx queues statistics counters mapping "
 	       "(0 <= mapping <= %d).\n", RTE_ETHDEV_QUEUE_STAT_CNTRS - 1);
@@ -630,7 +628,6 @@  launch_args_parse(int argc, char** argv)
 		{ "txwt",			1, 0, 0 },
 		{ "txfreet",			1, 0, 0 },
 		{ "txrst",			1, 0, 0 },
-		{ "txqflags",			1, 0, 0 },
 		{ "rxpt",			1, 0, 0 },
 		{ "rxht",			1, 0, 0 },
 		{ "rxwt",			1, 0, 0 },
@@ -1004,15 +1001,6 @@  launch_args_parse(int argc, char** argv)
 				else
 					rte_exit(EXIT_FAILURE, "txrst must be >= 0\n");
 			}
-			if (!strcmp(lgopts[opt_idx].name, "txqflags")) {
-				char *end = NULL;
-				n = strtoul(optarg, &end, 16);
-				if (n >= 0)
-					txq_flags = (int32_t)n;
-				else
-					rte_exit(EXIT_FAILURE,
-						 "txqflags must be >= 0\n");
-			}
 			if (!strcmp(lgopts[opt_idx].name, "rxd")) {
 				n = atoi(optarg);
 				if (n > 0) {
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index e3a7c26b8..a97edcadd 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -259,11 +259,6 @@  int16_t tx_free_thresh = RTE_PMD_PARAM_UNSET;
 int16_t tx_rs_thresh = RTE_PMD_PARAM_UNSET;
 
 /*
- * Configurable value of TX queue flags.
- */
-int32_t txq_flags = RTE_PMD_PARAM_UNSET;
-
-/*
  * Receive Side Scaling (RSS) configuration.
  */
 uint64_t rss_hf = ETH_RSS_IP; /* RSS IP by default. */
@@ -2072,9 +2067,6 @@  rxtx_port_config(struct rte_port *port)
 
 	if (tx_free_thresh != RTE_PMD_PARAM_UNSET)
 		port->tx_conf.tx_free_thresh = tx_free_thresh;
-
-	if (txq_flags != RTE_PMD_PARAM_UNSET)
-		port->tx_conf.txq_flags = txq_flags;
 }
 
 void
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 1639d27e7..6af70e02a 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -427,7 +427,6 @@  extern int16_t rx_free_thresh;
 extern int8_t rx_drop_en;
 extern int16_t tx_free_thresh;
 extern int16_t tx_rs_thresh;
-extern int32_t txq_flags;
 
 extern uint8_t dcb_config;
 extern uint8_t dcb_test;
diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index 4c0d2cede..cb94582b9 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -447,18 +447,6 @@  The commandline options are:
     Set the transmit RS bit threshold of TX rings to N, where 0 <= N <= value of ``--txd``.
     The default value is 0.
 
-*   ``--txqflags=0xXXXXXXXX``
-
-    Set the hexadecimal bitmask of TX queue flags, where 0 <= N <= 0x7FFFFFFF.
-    The default value is 0.
-
-    .. note::
-
-       When using hardware offload functions such as vlan or checksum
-       add ``txqflags=0`` to force the full-featured TX code path.
-       In some PMDs this may already be the default.
-
-
 *   ``--rx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping)]``
 
     Set the RX queues statistics counters mapping 0 <= mapping <= 15.
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 9789139af..8e73519a4 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -354,8 +354,6 @@  The available information categories are:
   also modify the default hierarchy or specify the new hierarchy through CLI for
   implementing QoS scheduler.  Requires ``CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y`` ``CONFIG_RTE_LIBRTE_SCHED=y``.
 
-Note: TX timestamping is only available in the "Full Featured" TX path. To force ``testpmd`` into this mode set ``--txqflags=0``.
-
 Example::
 
    testpmd> set fwd rxonly
@@ -1681,15 +1679,6 @@  RX scatter mode is off by default.
 
 The ``on`` option is equivalent to the ``--enable-scatter`` command-line option.
 
-port config - TX queue flags
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-Set a hexadecimal bitmap of TX queue flags for all ports::
-
-   testpmd> port config all txqflags value
-
-This command is equivalent to the ``--txqflags`` command-line option.
-
 port config - RX Checksum
 ~~~~~~~~~~~~~~~~~~~~~~~~~