From patchwork Thu Nov 23 12:02:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 31538 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BFE02BBB; Thu, 23 Nov 2017 13:03:17 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10067.outbound.protection.outlook.com [40.107.1.67]) by dpdk.org (Postfix) with ESMTP id B02C62B84; Thu, 23 Nov 2017 13:03:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=S+S2UcgNnd+PQH8tWgcids1k7/8B+BPbnKtddFKLs8M=; b=pxeiD3xNZAo5tTXUUDY8+NrEOaKdh0d623JSvjLLuAlEucVCULUwYAw3Joe4JYZi+Hpht+0GuwzcbH0+HnCTRXugPKsLKqVD6OuJVlLuwt+PpZzLHnAI77luinPAVVAJLUxG17jxI9l/GkeRIyv0HJzb4R+Jw+VnEMkfId0eLFo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by AM4PR05MB3138.eurprd05.prod.outlook.com (2603:10a6:205:3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Thu, 23 Nov 2017 12:03:12 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, yskoh@mellanox.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 23 Nov 2017 14:02:50 +0200 Message-Id: <20171123120252.143695-5-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171123120252.143695-1-shahafs@mellanox.com> References: <20171123120252.143695-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: DB3PR0202CA0031.eurprd02.prod.outlook.com (2603:10a6:8:1::44) To AM4PR05MB3138.eurprd05.prod.outlook.com (2603:10a6:205:3::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4deb5ced-af7b-4a10-7fe1-08d5326a2c3c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600025)(4604075)(2017052603199); SRVR:AM4PR05MB3138; X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3138; 3:xlzOzBcED7iqd4XJEZQmpe5MDxGfcXQx+A686wCRjGllg7D8chx96ERIrw8vwgkTfQF/OTiz/Jfp2SEeL+YPwBEp0kQLnL7GpNbgXGiGNu+BZqxZYAjCgPlVzuKW/2UAngGZaxQlLT6eUcFfGsmEWNtkkkGk6/K8j3l9DUhoU8PJW6g10OEMdfyv7APRxYt27vJawNbR+1q2mAVrZE95z4hfLfe0xpRA2eNyHl5Ez5kZhJY9Keb6wi4p3rbScriR; 25:LKzdx4vpX0kT+mRkUOs9ytN0ojmefp8+1s+4BOp29PWCuvM2p1nx5fia6ThLOsWIuTkagTFMkhN9OhXd1CkbWPLfOEoiFmqmE0z/dq8Zeds0cyM8+bbMFt/zWdKVutgeuhYZJBYqVl3CXX4TK0+5JpwZnba6twPdv8yh76BWOEegAYJr1vHrKXD3yS61gtm3z/fWhTwlevRIAFkP5SO3ZwwlwtN64A0wRbi7D9z71hn0s01MY9kGL03OzOrSvg4wVm67ul7P94kSxzXYSV4cv50rOf+YcZiu4kucD7O9D0oijGzRuXTOdBfYBTorMnK9RB2/s109N0iAoMoztkJnt/243VhH0dO/roAyUkVSgdI=; 31:U20WLPYcLgm+Q1tPswWEDdWW4ff8tBtMKlwKCnp8CEvtiX5umHD5xMHW08wpJr5+5cyD1I8ZEOAQxrkuHi/WzAolEV1FAEZmxJAqvtOXrfBv2c6zFyANdvQT09ZR5kvzELToEwKIO+dRxlGGmlOdA7RhLU1erSgUg8eq4payVKAbO1PcL1n1F3e2q2RD3Pa+qvEUehL2/BOzK41+i2jqiQ4kfDBGVsFQ66kdYkmVKAY= X-MS-TrafficTypeDiagnostic: AM4PR05MB3138: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3138; 20:JhvHLfzs0PA6Gkqq1IZe4V3WM8jU5SU3ZLO15ijqB32NPK3nE5WhFsxYCV3lG84KIaMOv1w8jMttPxmwI8VZx8YBp7UuZpe9dovDKHJ5VnYOlGUcgQrmjy6ZxkxT2Ypr+cr0SkwK2JJQD2MuxzaOCKD5NoMsLurwf7dZOymSr1UeTeicyrLQdfEbwB9I/V4dOB+SDeU5sNsoJ9Wd06Jxx8N/FWUjRTdZ4/VOrIK4bvHQjdFg7TbifOHemF0Nzlx+jwpY1ybmkdfBniC28VWaUgiQzUGjUS45cmA6HPkQyKnYENGiFjzw230owvtE6HenQ8UIQLNslkVrfae+RIS7/3a/0jfgyZt3g/5L9ekb3ga4gnURVDszG9CfwK8eNIpwWGNoH5WsHOrGs+2JYdnRHKsFZYAQ+ez0pfnhy5AnIx2qcOXju4UQURr7Xn8BxCqge/XS262hQwadXAzFhyej0ktr62SpsRElZ9yoeRmq2AvlTWR8+5ctwDsB+sS8Dqeh; 4:lKrazyPMUqfsqKyFWzLZChX6sxmmg0dNl39p3m9tvMippnsYs3V4EJ+el1l9EyRsE3Ff+gPJcziPfoGRjJzzOF7if2VaVkHoY6VdCySYVL7KK3OPnyhrwvF/29liFMz2VerRhFHsdPduUHs40miSbfP/BjsI7Kuwk2fVrsCNKaFQVdIe3x4cD/P/9xR5zF5gMjGnI/4hmUsZqSKB8sX8fLU0OKcZ0QQndQfbe8Bb3uAOOkBttDrDIWLZqzlG+/2T/cajEaVogOl6TdUwsOspAw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(3231022)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR05MB3138; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR05MB3138; X-Forefront-PRVS: 05009853EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(366004)(199003)(189002)(97736004)(33026002)(8676002)(53936002)(305945005)(68736007)(1076002)(189998001)(52116002)(4326008)(2950100002)(7736002)(2906002)(101416001)(6666003)(5660300001)(81166006)(76176999)(50986999)(81156014)(25786009)(478600001)(106356001)(47776003)(105586002)(316002)(5003940100001)(8936002)(50226002)(3846002)(69596002)(6116002)(16586007)(55016002)(86362001)(66066001)(21086003)(48376002)(50466002)(16526018)(36756003)(33646002)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3138; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR05MB3138; 23:Xdz3Qbh4VOL75pX+Nt21vut0NsyTEGPVojE3LUYER?= z5FKg3eeR5mvAGJkd6cthzmtBS7+fL0W+K0LlKkMsh8wWStiq+NaJoHlV+6zilKpPk8pZe4tSarhlxXf/jehMXMqcO1DfhhPZBd118qL+e88f3Ys6DcKZ7XLnnN3OCHjwldn7QoAqJQunpO26lIwzRskhAF2kxzzhSULtNojRHPjkTXAtui/D7+WnAc7KE0eMr1OdcN/uCmLTVVStRrLHt7g6wi0kplrF1F4ZUEoSHhQ2SAIwjLIlSYc7zZ1I3xs/5cQ99QklcehvEwXsMsnSF1egnCz8vQ+XcLxTCoCJSrzb4fb+kk1mocymAoZg7LD39ISqbRbHS3TKd3mKY8tf9MY3D7RjcqdgjFc4L1a0nwQDF/XaU8GMoud5TzUXPIvevFvENkKDSTGHps+lZGdMPpemqaUOEpLMCj3wUHTnsU06jyxMGydQsDz+Te/uhwJHgB+S7uPTJN/h/EqFkWL4jMLdZC0YSldtBleunqtNs6J7vZ9wndbSKrCD9rXozjuSQwami11tIOpREK+IsNt6Qlk5oPiJRzv1M1Y7eteB0k2sUuZVclT/2dIb3FztlsZ+meWeAnH6Rs4kifyXryTUy8nkCbLjwbMxIchlaKnEsxz4MSyLHEdhxqNAOCSjzuhhlSoJdoDvL87+WZbsDKN/y9dNUbOeGVo3S/cyESM/iJuXQAe6QOm8P64/72VSpK63cYG7gQqbjBtpiRYSnryDfrnclBeoOqVYlcrVttp61WJ8jWvKCzteTqw6YeVvR7rvRhzs6kUlKrnfER5sKs1MDKGrPBCIoZCYYVZR7mOPCEXIhFiCFFrkkg1BqGvacgzHXkf3hDkudST8mNu5m7SMROPQUi0RO9rpfrNLUq7JJbLnO6NZUwqP1GYJ8IxUDiK5sprRqowVPrMI3fFaODzTd1LaFXCej9yL65NzStXcwUa/+9GYs6xSLLQA0JVkHwc70e3GTHCsWaUbzEpOh469xu6fIqk2qhpX4Q6CpYT3O5ogrgbTgbjve5vzqsFUVh8x60lWRWbRXIdmVQGY8iTXHbKFXYv+c4WFU0oqz9WATyKtHCLpWcJd239Nvfrg2b7C690SYRDwSp5Rt7yll6tBQ/P5Lv8TNcB1fGHOMte6XWJ4fh2ElFeK+P7VYff1iZhi4= X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3138; 6:XVcrNfSYbzfIZsagC4Dm9DlrdVpIQT4tccj6Lqsrs1SfeGohzTxNQVMR9wM1RaxLDb9AYGPM5p1v292YygS+BLmLeNPZGtAfzDwH6Q7gKuz08bC/XoaL1gRbxxiLWQy71rLIWCIi8k8jXwM0f2uuC20Lsn9DJxpFxtJhrpfVnomE24E5onknzx+dUccdTWqSsV1ueuEKGNsGyDqlA1NJ3Y44S4Z0w2KuxRJo3STiJUGSBoNr3JrOH+zw0HOan/FPtV1qTzNlMB8FE7/mmpTvcNQzy7Ric+40Ur4nuofYT+hJgVlunoI+L8HpBPnv+uPUubuqjVTdb6Cz+a492CLkymap6pp7R3SEzdPankcOrrg=; 5:zZy8vJKRUt7pcewRCUKV8dssltoosgRGbQbEEnUVb4bODmmpOcIIDg9BYErWD4SJNf3ZlvbsLfHe2+aVcLE6Damux1vqf0u3YA216NoH+9GLcpT864vgWkxbIVmbHs2NB1FMMh8c50Zn7YB3OxhMZuIUSnFdr6FFWq2w7anWuUw=; 24:yr9LLzy6pqyuBmyYnVJ7NRxLcZWFh626PId9mLALjIA1/qR0zSs6D4NsBXjvIoCAQPZHSuicocOgTnLG+W/WVldE6b9fhcod+er7+YGoOb0=; 7:b0K8tapCbp086P++VjkqrWZ6hPWXSfn3P1bUINvNPNxMB+vP9q8gvFy6jR3vn2LrVORyC25lc5x/qJGEjKGjGYw5sBxgUmKUKr8eUOzJwsCMok4uFXv46TVIiULwSIofHmiKvKeHOvbGyXVmyQdnqwqnTDruHIL8oIxGfiJWyQNJgUSMvwF94ELPcAQXLatGGVvlD3hGY4venYJ5sRO064MB0TZ+lH6+x3cTj/IL4Ow6ElaaMR5msZ/oI9vTyYDB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2017 12:03:12.5533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4deb5ced-af7b-4a10-7fe1-08d5326a2c3c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3138 Subject: [dpdk-dev] [PATCH 4/6] net/mlx5: fix VLAN configuration after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ethdev layer has an API to configure vlan setting on the flight, i.e. when the port state is start. calling such API when the port is stopped may cause segmentation fault as the related Verbs contexts has not been created yet. Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue objects") Cc: nelio.laranjeiro@6wind.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_vlan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_vlan.c b/drivers/net/mlx5/mlx5_vlan.c index dc82643fc..128c2b6b6 100644 --- a/drivers/net/mlx5/mlx5_vlan.c +++ b/drivers/net/mlx5/mlx5_vlan.c @@ -127,6 +127,11 @@ priv_vlan_strip_queue_set(struct priv *priv, uint16_t idx, int on) DEBUG("set VLAN offloads 0x%x for port %d queue %d", vlan_offloads, rxq->port_id, idx); + if (!rxq_ctrl->ibv) { + /* Update related bits in RX queue. */ + rxq->vlan_strip = !!on; + return; + } mod = (struct ibv_wq_attr){ .attr_mask = IBV_WQ_ATTR_FLAGS, .flags_mask = IBV_WQ_FLAGS_CVLAN_STRIPPING,