[dpdk-dev,v2,3/3] security: fix pedantic compilation

Message ID e5e8c5eb0f2e2cd7eb10c4d38e79872b9dfb0f1e.1511431327.git.nelio.laranjeiro@6wind.com
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Nélio Laranjeiro Nov. 23, 2017, 10:02 a.m.
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_security.h:229:8: error: struct has no members [-Werror=pedantic]
  struct rte_security_macsec_xform {
         ^~~~~~~~~~~~~~~~~~~~~~~~~
 /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_security.h:453:3: error: struct has no members [-Werror=pedantic]
    struct {
    ^~~~~~

Fixes: c261d1431bd8 ("security: introduce security API and framework")
Cc: akhil.goyal@nxp.com
Cc: stable@dpdk.org

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 lib/librte_security/rte_security.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Akhil Goyal Nov. 24, 2017, 9:34 a.m. | #1
Acked-by: Akhil Goyal <akhil.goyal@nxp.com
Pablo de Lara Jan. 8, 2018, 12:35 p.m. | #2
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Nelio
> Laranjeiro
> Sent: Thursday, November 23, 2017 10:03 AM
> To: Akhil Goyal <akhil.goyal@nxp.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; Gaetan Rivet <gaetan.rivet@6wind.com>;
> stable@dpdk.org
> Subject: [dpdk-stable] [PATCH v2 3/3] security: fix pedantic compilation
> 
>  /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_security.h:229:8:
> error: struct has no members [-Werror=pedantic]
>   struct rte_security_macsec_xform {
>          ^~~~~~~~~~~~~~~~~~~~~~~~~
>  /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_security.h:453:3:
> error: struct has no members [-Werror=pedantic]
>     struct {
>     ^~~~~~
> 
> Fixes: c261d1431bd8 ("security: introduce security API and framework")
> Cc: akhil.goyal@nxp.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

Patch

diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h
index 679c0a696..bcce7a189 100644
--- a/lib/librte_security/rte_security.h
+++ b/lib/librte_security/rte_security.h
@@ -228,6 +228,7 @@  struct rte_security_ipsec_xform {
  */
 struct rte_security_macsec_xform {
 	/** To be Filled */
+	int dummy;
 };
 
 /**
@@ -471,6 +472,7 @@  struct rte_security_capability {
 		/**< IPsec capability */
 		struct {
 			/* To be Filled */
+			int dummy;
 		} macsec;
 		/**< MACsec capability */
 	};