[dpdk-dev,1/3] eal: update legacy modules dynamic logs regex

Message ID 20171122092806.17194-1-pbhagavatula@caviumnetworks.com
State Superseded, archived
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Pavan Nikhilesh Nov. 22, 2017, 9:28 a.m.
Update legacy log types regex strings used for registering dynamic logs.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 Note:
 This patchset is based on patch set
 http://dpdk.org/dev/patchwork/patch/31443/
 followed by ml discussion
 http://dpdk.org/ml/archives/dev/2017-November/081953.html

 lib/librte_eal/common/eal_common_log.c | 39 +++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 19 deletions(-)

--
2.14.1

Comments

Ferruh Yigit Nov. 22, 2017, 10:57 p.m. | #1
On 11/22/2017 1:28 AM, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

For series
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Olivier Matz Dec. 7, 2017, 1:14 p.m. | #2
On Wed, Nov 22, 2017 at 02:58:04PM +0530, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  Note:
>  This patchset is based on patch set
>  http://dpdk.org/dev/patchwork/patch/31443/
>  followed by ml discussion
>  http://dpdk.org/ml/archives/dev/2017-November/081953.html
> 
>  lib/librte_eal/common/eal_common_log.c | 39 +++++++++++++++++-----------------
>  1 file changed, 20 insertions(+), 19 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index e894b75ec..fa9ac7247 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -219,26 +219,27 @@ struct logtype {
>  };
> 
>  static const struct logtype logtype_strings[] = {
> -	{RTE_LOGTYPE_EAL,        "eal"},
> -	{RTE_LOGTYPE_MALLOC,     "malloc"},
> -	{RTE_LOGTYPE_RING,       "ring"},
> -	{RTE_LOGTYPE_MEMPOOL,    "mempool"},
> -	{RTE_LOGTYPE_TIMER,      "timer"},
> +	{RTE_LOGTYPE_EAL,        "lib.eal"},
> +	{RTE_LOGTYPE_MALLOC,     "lib.malloc"},
> +	{RTE_LOGTYPE_RING,       "lib.ring"},
> +	{RTE_LOGTYPE_MEMPOOL,    "lib.mempool"},
> +	{RTE_LOGTYPE_TIMER,      "lib.timer"},

[...]

I agree it's much better to have the library prefixed by "lib.".

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Patch

diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index e894b75ec..fa9ac7247 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -219,26 +219,27 @@  struct logtype {
 };

 static const struct logtype logtype_strings[] = {
-	{RTE_LOGTYPE_EAL,        "eal"},
-	{RTE_LOGTYPE_MALLOC,     "malloc"},
-	{RTE_LOGTYPE_RING,       "ring"},
-	{RTE_LOGTYPE_MEMPOOL,    "mempool"},
-	{RTE_LOGTYPE_TIMER,      "timer"},
+	{RTE_LOGTYPE_EAL,        "lib.eal"},
+	{RTE_LOGTYPE_MALLOC,     "lib.malloc"},
+	{RTE_LOGTYPE_RING,       "lib.ring"},
+	{RTE_LOGTYPE_MEMPOOL,    "lib.mempool"},
+	{RTE_LOGTYPE_TIMER,      "lib.timer"},
 	{RTE_LOGTYPE_PMD,        "pmd"},
-	{RTE_LOGTYPE_HASH,       "hash"},
-	{RTE_LOGTYPE_LPM,        "lpm"},
-	{RTE_LOGTYPE_KNI,        "kni"},
-	{RTE_LOGTYPE_ACL,        "acl"},
-	{RTE_LOGTYPE_POWER,      "power"},
-	{RTE_LOGTYPE_METER,      "meter"},
-	{RTE_LOGTYPE_SCHED,      "sched"},
-	{RTE_LOGTYPE_PORT,       "port"},
-	{RTE_LOGTYPE_TABLE,      "table"},
-	{RTE_LOGTYPE_PIPELINE,   "pipeline"},
-	{RTE_LOGTYPE_MBUF,       "mbuf"},
-	{RTE_LOGTYPE_CRYPTODEV,  "cryptodev"},
-	{RTE_LOGTYPE_EFD,        "efd"},
-	{RTE_LOGTYPE_EVENTDEV,   "eventdev"},
+	{RTE_LOGTYPE_HASH,       "lib.hash"},
+	{RTE_LOGTYPE_LPM,        "lib.lpm"},
+	{RTE_LOGTYPE_KNI,        "lib.kni"},
+	{RTE_LOGTYPE_ACL,        "lib.acl"},
+	{RTE_LOGTYPE_POWER,      "lib.power"},
+	{RTE_LOGTYPE_METER,      "lib.meter"},
+	{RTE_LOGTYPE_SCHED,      "lib.sched"},
+	{RTE_LOGTYPE_PORT,       "lib.port"},
+	{RTE_LOGTYPE_TABLE,      "lib.table"},
+	{RTE_LOGTYPE_PIPELINE,   "lib.pipeline"},
+	{RTE_LOGTYPE_MBUF,       "lib.mbuf"},
+	{RTE_LOGTYPE_CRYPTODEV,  "lib.cryptodev"},
+	{RTE_LOGTYPE_EFD,        "lib.efd"},
+	{RTE_LOGTYPE_EVENTDEV,   "lib.eventdev"},
+	{RTE_LOGTYPE_GSO,        "lib.gso"},
 	{RTE_LOGTYPE_USER1,      "user1"},
 	{RTE_LOGTYPE_USER2,      "user2"},
 	{RTE_LOGTYPE_USER3,      "user3"},