[dpdk-dev,6/6] doc: add mbuf VLAN flag to PMD todo list

Message ID 20171121014241.61050-6-ferruh.yigit@intel.com
State Rejected, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Ferruh Yigit Nov. 21, 2017, 1:42 a.m.
To track modification:
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")

Proposed deadline for PMDs is v18.02

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/guides/nics/todo.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Ferruh Yigit Nov. 21, 2017, 1:53 a.m. | #1
On 11/20/2017 5:42 PM, Ferruh Yigit wrote:
> To track modification:
> 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")

I recognized that almost all are by Olivier, cc'ed :)

> Proposed deadline for PMDs is v18.02
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

<...>
Hemant Agrawal Dec. 6, 2017, 9:24 a.m. | #2
On 11/21/2017 7:12 AM, Ferruh Yigit wrote:
> To track modification:
> 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/guides/nics/todo.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 61dd9cbc9..493a49ff2 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
>   |                   | | thunderx, vhost, virtio,     |          |                |                                   |
>   |                   | | vmxnet3                      |          |                |                                   |
>   +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | | check new mbuf  | | af_packet, ark, avp, bnx2x,  | v18.02   | 380a7aab1ae2   | mbuf flag PKT_RX_VLAN_PKT renamed |
> + | | VLAN flag       | | bnxt, bonding, cxgbe, dpaa,  |          |                | to PKT_RX_VLAN and its meaning    |
> + | | PKT_RX_VLAN     | | dpaa2, e1000, ena, enic,     |          |                | changed, confirm PMD uses new     |
> + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                | flag correct.                     |
> + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
> + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> + |                   | | vmxnet3                      |          |                |                                   |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
>
w.r.t dpaa and dpaa2
Reviewed-by:  Hemant Agrawal <hemant.agrawal@nxp.com>
Mcnamara, John Dec. 11, 2017, 2:16 p.m. | #3
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, November 21, 2017 1:43 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list
> 
> To track modification:
> 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> 
> Proposed deadline for PMDs is v18.02
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>


It might be worth putting | before all the text in the first column,
even if it is just a single item, since it will justify the text in
the same way.

Also it might be worth adding it to the text in the last column so
that the column isn't too wide.

Acked-by: John McNamara <john.mcnamara@intel.com>
Andrew Rybchenko Dec. 29, 2017, 11:50 a.m. | #4
On 11/21/2017 04:42 AM, Ferruh Yigit wrote:
> To track modification:
> 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   doc/guides/nics/todo.rst | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 61dd9cbc9..493a49ff2 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
>    |                   | | thunderx, vhost, virtio,     |          |                |                                   |
>    |                   | | vmxnet3                      |          |                |                                   |
>    +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | | check new mbuf  | | af_packet, ark, avp, bnx2x,  | v18.02   | 380a7aab1ae2   | mbuf flag PKT_RX_VLAN_PKT renamed |
> + | | VLAN flag       | | bnxt, bonding, cxgbe, dpaa,  |          |                | to PKT_RX_VLAN and its meaning    |
> + | | PKT_RX_VLAN     | | dpaa2, e1000, ena, enic,     |          |                | changed, confirm PMD uses new     |
> + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                | flag correct.                     |
> + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
> + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> + |                   | | vmxnet3                      |          |                |                                   |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+

sfc may be excluded from the list since neither old nor new flag is used.
Of course, I can send a patch to remove it, if required.
Stephen Hemminger Dec. 29, 2017, 5:09 p.m. | #5
On Tue, 21 Nov 2017 01:42:41 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> To track modification:
> 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> 
> Proposed deadline for PMDs is v18.02
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/guides/nics/todo.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 61dd9cbc9..493a49ff2 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
>   |                   | | thunderx, vhost, virtio,     |          |                |                                   |
>   |                   | | vmxnet3                      |          |                |                                   |
>   +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | | check new mbuf  | | af_packet, ark, avp, bnx2x,  | v18.02   | 380a7aab1ae2   | mbuf flag PKT_RX_VLAN_PKT renamed |
> + | | VLAN flag       | | bnxt, bonding, cxgbe, dpaa,  |          |                | to PKT_RX_VLAN and its meaning    |
> + | | PKT_RX_VLAN     | | dpaa2, e1000, ena, enic,     |          |                | changed, confirm PMD uses new     |
> + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                | flag correct.                     |
> + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
> + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> + |                   | | vmxnet3                      |          |                |                                   |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+


NAK
Fix the other drivers.

This open source, if you introduce a new behavior it is the responsibility of the person adding
the new stuff to fix every other driver.
Olivier Matz Jan. 3, 2018, 2:14 p.m. | #6
On Fri, Dec 29, 2017 at 09:09:25AM -0800, Stephen Hemminger wrote:
> On Tue, 21 Nov 2017 01:42:41 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > To track modification:
> > 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> > 
> > Proposed deadline for PMDs is v18.02
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> >  doc/guides/nics/todo.rst | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> > index 61dd9cbc9..493a49ff2 100644
> > --- a/doc/guides/nics/todo.rst
> > +++ b/doc/guides/nics/todo.rst
> > @@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
> >   |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> >   |                   | | vmxnet3                      |          |                |                                   |
> >   +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> > + | | check new mbuf  | | af_packet, ark, avp, bnx2x,  | v18.02   | 380a7aab1ae2   | mbuf flag PKT_RX_VLAN_PKT renamed |
> > + | | VLAN flag       | | bnxt, bonding, cxgbe, dpaa,  |          |                | to PKT_RX_VLAN and its meaning    |
> > + | | PKT_RX_VLAN     | | dpaa2, e1000, ena, enic,     |          |                | changed, confirm PMD uses new     |
> > + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                | flag correct.                     |
> > + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
> > + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
> > + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> > + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> > + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> > + |                   | | vmxnet3                      |          |                |                                   |
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> 
> 
> NAK
> Fix the other drivers.
> 
> This open source, if you introduce a new behavior it is the responsibility of the person adding
> the new stuff to fix every other driver.

Actually, no new behavior was introduced. The meaning of the vlan flags
has been clarified. The purpose of this note is to ask the maintainers
to ensure that the behavior of the PMDs matches the API. This operation
is not easy to do for someone that does not know the hardware, and
that cannot test it.

Patch

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 61dd9cbc9..493a49ff2 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -83,3 +83,14 @@  This is the list for tracking required PMD changes triggered by library modifica
  |                   | | thunderx, vhost, virtio,     |          |                |                                   |
  |                   | | vmxnet3                      |          |                |                                   |
  +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | check new mbuf  | | af_packet, ark, avp, bnx2x,  | v18.02   | 380a7aab1ae2   | mbuf flag PKT_RX_VLAN_PKT renamed |
+ | | VLAN flag       | | bnxt, bonding, cxgbe, dpaa,  |          |                | to PKT_RX_VLAN and its meaning    |
+ | | PKT_RX_VLAN     | | dpaa2, e1000, ena, enic,     |          |                | changed, confirm PMD uses new     |
+ |                   | | failsafe, fm10k, i40e, ixgbe,|          |                | flag correct.                     |
+ |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
+ |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
+ |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
+ |                   | | softnic, szedata2, tap,      |          |                |                                   |
+ |                   | | thunderx, vhost, virtio,     |          |                |                                   |
+ |                   | | vmxnet3                      |          |                |                                   |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+