From patchwork Thu Nov 9 12:43:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 31298 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3282C1B684; Thu, 9 Nov 2017 13:43:04 +0100 (CET) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id ADBF71B683 for ; Thu, 9 Nov 2017 13:43:02 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id y80so16781623wmd.0 for ; Thu, 09 Nov 2017 04:43:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=vXcpUxyMS0u1s8ee2391ivS7zRfERIxXx/tQD8X1oNg=; b=CPTHoK+S5EGtJLBvYvQmlpq8vbLnq7k4xTKOiOrkLJzMFg12EQfLMZJ7M1f8pNwIri CP4G4f6cmlEeT9IaVA7GVm+4F7a/0jnKgNyBkb5F/22EReMbkToPFWc7K1M91FZbWBXM QfP9+25Q0HHEDtAwL5Qa3xEJWP//HoGQIB5rHaom50Wymu0q+XRRrzsUmt71kBqmWIWE uxbjwyUeTfIEBD+XeuCUTH6DkROrPwNIWV7o8PzauUixNQmYJNWuUF0DTn+6U2y13Qhd oa+a2eNGKJyLWc69evRCCeITsJqnYfV3Bl8XaI5DGUIHmtZ7PZW5j+Jxl7EB0e2damyk SyjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vXcpUxyMS0u1s8ee2391ivS7zRfERIxXx/tQD8X1oNg=; b=H3TtbT+25H4Dai2IeG/yHAvIsvzEfuqkKXuw5z4pSIScHCQUGfMbQ116R6kz3HoJFi WU0eL65JhyIlch6+ZIyOueNwgbl3ag/WLTNIbEV4I37vS2lwxPJVZR8610ppcLuqviCG v3nPeAGoua8od0hncf4V03gcdXzsbY/6cJHu03Z5F7tQu7Q15HcGlzLlOq1Uheogq/kG +QxvX0G8qLpol7oi2zdbExiFUzLgwVupUrszpoGJug9Yv8wkwcGm2dCMhDVRzMAhr03D CSGmwjGs2eA7S3CZSvkRj4uCebmHejs4lwdvBxxVBf+ONCg4M4OzpHvdhtKiz16vQdJm NYsg== X-Gm-Message-State: AJaThX6R7VKoJPU65gjVlYAUB14GoroLOrncMqfNU9wsfXle6xWAvHq3 sLRRr8yVpcAjA2pL73/bKs++C46P0A== X-Google-Smtp-Source: ABhQp+RraprThWXXV9qvCI5s1ZnuIvEt8nBviOeXaFw9B3gr0KezCiJ41t0/Mi4RPyqtVaYva15Kyw== X-Received: by 10.80.172.74 with SMTP id w10mr457927edc.257.1510231382189; Thu, 09 Nov 2017 04:43:02 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y3sm5580161edd.73.2017.11.09.04.43.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Nov 2017 04:43:01 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Thu, 9 Nov 2017 13:43:06 +0100 Message-Id: <33f03283d9d7c5cadbeb7c6495148e1eb527ac50.1510231343.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow director rules comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When deleting/replacing a flow director rule the first rule of the list was always the one replaced instead of the corresponding one. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index cd99cb075..3df8fba4e 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -2914,13 +2914,16 @@ priv_fdir_filter_delete(struct priv *priv, flow_h = flow_spec; if (memcmp(spec, flow_spec, RTE_MIN(attr_h->size, flow_h->size))) - continue; + goto wrong_flow; spec = (void *)((uintptr_t)attr + attr_h->size); flow_spec = (void *)((uintptr_t)flow_attr + flow_h->size); } /* At this point, the flow match. */ break; +wrong_flow: + /* The flow does not match. */ + continue; } if (flow) priv_flow_destroy(priv, &priv->flows, flow);