[dpdk-dev] security: fix anonymous unions in structure definitions

Message ID 20171109122357.32333-1-akhil.goyal@nxp.com
State Accepted, archived
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Akhil Goyal Nov. 9, 2017, 12:23 p.m.
Fixes: c261d1431bd8 ("security: introduce security API and framework")

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 lib/librte_security/rte_security.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

De Lara Guarch, Pablo Nov. 9, 2017, 2:23 p.m. | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
> Sent: Thursday, November 9, 2017 12:24 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>;
> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;
> thomas@monjalon.net; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [dpdk-dev] [PATCH] security: fix anonymous unions in structure
> definitions
> 
> Fixes: c261d1431bd8 ("security: introduce security API and framework")
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Thomas Monjalon Nov. 10, 2017, 1:52 a.m. | #2
> > Fixes: c261d1431bd8 ("security: introduce security API and framework")
> > 
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

I'm surprised we have not hit this issue before.

Applied, thanks
Ferruh Yigit Nov. 10, 2017, 2:15 a.m. | #3
On 11/9/2017 5:52 PM, Thomas Monjalon wrote:
>>> Fixes: c261d1431bd8 ("security: introduce security API and framework")
>>>
>>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>>
>> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> I'm surprised we have not hit this issue before.

I think this only can be observed with gcc pedantic option, we don't compile
DPDK with this option, only some drivers supports pedantic flag.

> 
> Applied, thanks
>

Patch

diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h
index 7e687d2..653929b 100644
--- a/lib/librte_security/rte_security.h
+++ b/lib/librte_security/rte_security.h
@@ -266,6 +266,7 @@  struct rte_security_session_conf {
 	/**< Type of action to be performed on the session */
 	enum rte_security_session_protocol protocol;
 	/**< Security protocol to be configured */
+	RTE_STD_C11
 	union {
 		struct rte_security_ipsec_xform ipsec;
 		struct rte_security_macsec_xform macsec;
@@ -406,6 +407,7 @@  struct rte_security_stats {
 	enum rte_security_session_protocol protocol;
 	/**< Security protocol to be configured */
 
+	RTE_STD_C11
 	union {
 		struct rte_security_macsec_stats macsec;
 		struct rte_security_ipsec_stats ipsec;
@@ -486,6 +488,7 @@  struct rte_security_capability_idx {
 	enum rte_security_session_action_type action;
 	enum rte_security_session_protocol protocol;
 
+	RTE_STD_C11
 	union {
 		struct {
 			enum rte_security_ipsec_sa_protocol proto;