[dpdk-dev,18.02-rc2] net/qede: remove VF Tx switch option

Message ID 20171108004106.5072-1-thomas@monjalon.net
State Superseded, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon Nov. 8, 2017, 12:41 a.m.
The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH
has been added just before the 17.11 release.
Such new options are forbidden and must be replaced by a run-time option.
If it is not replaced in 18.02-rc1, this removal will be applied.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 config/common_base             | 1 -
 drivers/net/qede/qede_ethdev.c | 2 --
 2 files changed, 3 deletions(-)

Comments

Ferruh Yigit Jan. 11, 2018, 5:50 p.m. | #1
On 11/8/2017 12:41 AM, Thomas Monjalon wrote:
> The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH
> has been added just before the 17.11 release.
> Such new options are forbidden and must be replaced by a run-time option.
> If it is not replaced in 18.02-rc1, this removal will be applied.

I hope this is not forgotten!

> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  config/common_base             | 1 -
>  drivers/net/qede/qede_ethdev.c | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/config/common_base b/config/common_base
> index 34f04a9fe..9ae5ec30f 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -415,7 +415,6 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
>  CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
>  CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
>  CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n
>  #Provides abs path/name of the firmware file.
>  #Empty string denotes driver will use default firmware
>  CONFIG_RTE_LIBRTE_QEDE_FW=""
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index 883214515..0de3a2760 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -453,12 +453,10 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)
>  	params.update_vport_active_tx_flg = 1;
>  	params.vport_active_rx_flg = flg;
>  	params.vport_active_tx_flg = flg;
> -#ifndef RTE_LIBRTE_QEDE_VF_TX_SWITCH
>  	if (IS_VF(edev)) {
>  		params.update_tx_switching_flg = 1;
>  		params.tx_switching_flg = !flg;
>  	}
> -#endif
>  	for_each_hwfn(edev, i) {
>  		p_hwfn = &edev->hwfns[i];
>  		params.opaque_fid = p_hwfn->hw_info.opaque_fid;
>
Mody, Rasesh Jan. 11, 2018, 7:03 p.m. | #2
Hi Ferruh,

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit

> Sent: Thursday, January 11, 2018 9:50 AM

> 

> On 11/8/2017 12:41 AM, Thomas Monjalon wrote:

> > The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH

> > has been added just before the 17.11 release.

> > Such new options are forbidden and must be replaced by a run-time

> option.

> > If it is not replaced in 18.02-rc1, this removal will be applied.

> 

> I hope this is not forgotten!


We'll submit this shortly.

Thanks!
-Rasesh
> 

> >

> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

> > ---

> >  config/common_base             | 1 -

> >  drivers/net/qede/qede_ethdev.c | 2 --

> >  2 files changed, 3 deletions(-)

> >

> > diff --git a/config/common_base b/config/common_base index

> > 34f04a9fe..9ae5ec30f 100644

> > --- a/config/common_base

> > +++ b/config/common_base

> > @@ -415,7 +415,6 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n

> >  CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n

> >  CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n

> >  CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n

> > -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n

> >  #Provides abs path/name of the firmware file.

> >  #Empty string denotes driver will use default firmware

> > CONFIG_RTE_LIBRTE_QEDE_FW=""

> > diff --git a/drivers/net/qede/qede_ethdev.c

> > b/drivers/net/qede/qede_ethdev.c index 883214515..0de3a2760 100644

> > --- a/drivers/net/qede/qede_ethdev.c

> > +++ b/drivers/net/qede/qede_ethdev.c

> > @@ -453,12 +453,10 @@ int qede_activate_vport(struct rte_eth_dev

> *eth_dev, bool flg)

> >  	params.update_vport_active_tx_flg = 1;

> >  	params.vport_active_rx_flg = flg;

> >  	params.vport_active_tx_flg = flg;

> > -#ifndef RTE_LIBRTE_QEDE_VF_TX_SWITCH

> >  	if (IS_VF(edev)) {

> >  		params.update_tx_switching_flg = 1;

> >  		params.tx_switching_flg = !flg;

> >  	}

> > -#endif

> >  	for_each_hwfn(edev, i) {

> >  		p_hwfn = &edev->hwfns[i];

> >  		params.opaque_fid = p_hwfn->hw_info.opaque_fid;

> >
Mody, Rasesh Jan. 12, 2018, 10 p.m. | #3
> From: Mody, Rasesh

> Sent: Thursday, January 11, 2018 11:03 AM

> To: 'Ferruh Yigit' <ferruh.yigit@intel.com>; Thomas Monjalon

> <thomas@monjalon.net>; Patil, Harish <Harish.Patil@cavium.com>

> Cc: dev@dpdk.org

> Subject: RE: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch

> option

> 

> Hi Ferruh,

> 

> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit

> > Sent: Thursday, January 11, 2018 9:50 AM

> >

> > On 11/8/2017 12:41 AM, Thomas Monjalon wrote:

> > > The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH

> > > has been added just before the 17.11 release.

> > > Such new options are forbidden and must be replaced by a run-time

> > option.

> > > If it is not replaced in 18.02-rc1, this removal will be applied.

> >

> > I hope this is not forgotten!

> 

> We'll submit this shortly.


Please check the patch link below that introduces a run-time driver option and replaces compile time option. It supersedes a patch, submitted by Thomas earlier,  that only removes compile time option.
https://dpdk.org/dev/patchwork/patch/33696/

Thanks!
-Rasesh

Patch

diff --git a/config/common_base b/config/common_base
index 34f04a9fe..9ae5ec30f 100644
--- a/config/common_base
+++ b/config/common_base
@@ -415,7 +415,6 @@  CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
-CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n
 #Provides abs path/name of the firmware file.
 #Empty string denotes driver will use default firmware
 CONFIG_RTE_LIBRTE_QEDE_FW=""
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 883214515..0de3a2760 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -453,12 +453,10 @@  int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)
 	params.update_vport_active_tx_flg = 1;
 	params.vport_active_rx_flg = flg;
 	params.vport_active_tx_flg = flg;
-#ifndef RTE_LIBRTE_QEDE_VF_TX_SWITCH
 	if (IS_VF(edev)) {
 		params.update_tx_switching_flg = 1;
 		params.tx_switching_flg = !flg;
 	}
-#endif
 	for_each_hwfn(edev, i) {
 		p_hwfn = &edev->hwfns[i];
 		params.opaque_fid = p_hwfn->hw_info.opaque_fid;